On Fri, Apr 24, 2020 at 07:20:23PM +1200, Boris A. Dekshteyn wrote:
In your future patches, please include a ChangeLog-style line in the
body of the commit message. You can look at the commit history for some
examples. In the case of new packages, it's customary to write
* gnu/packages/xdisorg.scm (kbdd): New variable.
It's generally a bad idea to use GitHub's autogenerated tarball, since
it is occasionally regenerated, which changes the hash. See point 13 of
"(guix)Submitting Patches". This is also pointed out by `guix lint`,
please make sure to run it on your packages.
I got surprised that this phase is necessary, as gnu-build-system
already includes the 'bootstrap phase. I tried removing it and the
package still builds. Was that not the case for you?
Usually, alphabetical order is preferred unless there's a reason to
The leading pluses almost certainly shouldn't be there. The description
is written somewhat oddly. When you're out of inspiration for a
description, you can adapt Debian's. In fact, the description used by
Debian made it much more clear to me why I'd want to use the package:
(synopsis "Per-window keyboard layout switching daemon for X")
(description "@command{kbdd} is a simple keyboard layout switching
program, which is designed to run in an X11 session and remember
keyboard layouts on a per-window basis. That can be very handy for a
user of a non-US keyboard who does not want to jump through layouts back
and forth while typing in terminals (mostly in a latin alphabet) and
some kind of chat (in native language).
@command{kbdd} also supports D-Bus signals, which makes it possible to
create layout indicator widgets.")
Thanks for your contributions! Would you mind sending an updated patch?
(To the same bug number, 40810@debbugs.gnu.org. Also, please CC me, as I
don't subscribe to the guix-patches mailing list.)