[PATCH] gnu: emacs-use-package: Make sure manual is built and installed

DoneSubmitted by Evan Straw.
Details
2 participants
  • Brett Gilio
  • Evan Straw
Owner
unassigned
Severity
normal
E
E
Evan Straw wrote on 14 Apr 2020 02:32
(address . guix-patches@gnu.org)
87lfmy29gd.fsf@gmail.com
Hi all,
When trying to use use-package today I discovered that it has a Texinfo
manual, but this manual is not built or installed by the Guix
package. The patch below should remedy this.

-- Evan <evan.straw99@gmail.com>
From 62c94580a0d083a7ba703ed92d941c945bb90ae0 Mon Sep 17 00:00:00 2001
From: Evan Straw <evan.straw99@gmail.com>
Date: Mon, 13 Apr 2020 17:29:20 -0700
Subject: [PATCH] gnu: emacs-use-package: Make sure manual is built and
installed.

* gnu/packages/emacs-xyz.scm (emacs-use-package): Make sure manual is built
and installed.
---
gnu/packages/emacs-xyz.scm | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)

Toggle diff (36 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index bd1ce3a298..ee20eb9053 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9563,13 +9563,28 @@ abbreviation of the mode line displays (lighters) of minor modes.")
                (base32
                 "1b7mjjh0d6fmkkd9vyj64vca27xqhga0nvyrrcqxpqjn62zq046y"))))
     (build-system emacs-build-system)
+    (native-inputs
+     `(("texinfo" ,texinfo)))
     (propagated-inputs
      `(("emacs-diminish" ,emacs-diminish)))
     (arguments
      `(#:tests? #t
        #:test-command '("emacs" "--batch"
                         "-l" "use-package-tests.el"
-                        "-f" "ert-run-tests-batch-and-exit")))
+                        "-f" "ert-run-tests-batch-and-exit")
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'install 'install-manual
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (info-dir (string-append out "/share/info")))
+               (mkdir-p info-dir)
+               (install-file "use-package.info" info-dir)
+               #t)))
+         (add-before 'install-manual 'build-manual
+           (lambda _
+             (invoke "makeinfo" "use-package.texi")
+             #t)))))
     (home-page "https://github.com/jwiegley/use-package")
     (synopsis "Declaration for simplifying your .emacs")
     (description "The use-package macro allows you to isolate package
-- 
2.20.1
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE6f/SZXb4DLdwy+VR9TDDtKKp8G0FAl6VBKIACgkQ9TDDtKKp
8G3HAA/+NmtQt3/B1oOtkm8LngNCf51GMJJ/BSqWysfCXjqWpz544rI5k50jW3xW
OYSStZuPdKJjqbLDaINwQOb6w9Fcyr6253WmOkpjyvzKvjP30FEldYLISm9BjPrR
JqkoW7fcI+r7AqkVgZIqb9INqrMyHTj7UunQLIVYURgyBv3veEeAwovdDulvcfr7
/A+AjG6rkMEZt8rbwXmsPk/L6j6mnfQg42ocnvlSe+k/XmaUYbQ4XCPoR72ipHHU
bEV8m7dk8Mw1eF8Mic3uzi2TP5Jvt0ExUEdH+C/PEZDUy2Hw549+1chIF1gvw+oB
iBWjvMszafHTYpRbGqYyNyZvz1pp5HipZ1pNrPhG1pSdrNPmYn/lM25lTCUUUT2c
IA8wByIFKnm/0KRpM+kbUpPK2sAFF2leqCiaYgZPAtmyA+zN1XP1f+R/sX+Eme0t
tyAjDTwAYWvHKq7BLUGI6mlRYUVpwZ6EQvduNBRp3bnuVmmlDuRb/5s1EsmgsNZm
a3VydgXbOiYWv/HJ22Em70u1vbsYmMyyvmn3VmBY+Zhd1ak7c+vpUJdaw/UpeM8a
lMsEaDkN+BqtObNfLIkAHZW+7cXQgKOHYoBF1AtmIxL1pqHmLyo9nT9ZdVjgARaY
KIpbrQssjy331iYqgfE7Q5NjN1X4cKla8hg/XWm4ud+0aPfYIfU=
=tGOT
-----END PGP SIGNATURE-----

B
B
Brett Gilio wrote on 25 Jul 2020 04:05
(name . Evan Straw)(address . evan.straw99@gmail.com)(address . 40615-done@debbugs.gnu.org)
875zac4adl.fsf@gnu.org
Hi Evan,

Thank you for the patch! Sorry it is so late getting to be reviewed. I
have made a few changes to the commit message and the sub-header. Pushed
to master with 30aa5dd7e7180d163d409b080bf89e8a15a5ba4d.

Brett Gilio
Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 40615@debbugs.gnu.org