[PATCH] gnu: Add lsp-plugins.

Alexandros Theodotou wrote on 6 Apr 2020 17:08

Recipients:(name . Guix patches)(address . guix-patches@gnu.org)

Message-ID:5e2c5de3bd13ab94f1a9fc48f65e002b75cde9df.camel@zrythm.org

Hi,
This patch adds LSP plugins (https://lsp-plug.in/).
Thanks,Alex

Alexandros Theodotou wrote on 7 Apr 2020 22:08

Recipients:(address . 40471@debbugs.gnu.org)

Message-ID:2ba1186e3cdefb109e293aba0337c95ab6cea6f4.camel@zrythm.org

Oops, here's the patch.

From 5426409d1d392b8f5fab184a64526d597dd690fa Mon Sep 17 00:00:00 2001
* gnu/packages/music.scm (lsp-plugins): new variable.--- gnu/packages/music.scm | 43 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+)

Toggle diff (53 lines)diff --git a/gnu/packages/music.scm b/gnu/packages/music.scmindex ee402bad4d..41c93c5a90 100644--- a/gnu/packages/music.scm+++ b/gnu/packages/music.scm@@ -5380,3 +5380,46 @@ filtered, pitch shifted and ultimately disintegrated.  This is an unofficial port of the Regrader plugin created by Igorski.  It is available as an LV2 plugin and a standalone JACK application.")     (license license:expat)))++(define-public lsp-plugins+  (package+    (name "lsp-plugins")+    (version "1.1.17")+    (source+      (origin+        (method git-fetch)+        (uri (git-reference+               (url "https://github.com/sadko4u/lsp-plugins.git")+               (commit (string-append "lsp-plugins-" version))))+        (file-name (git-file-name name version))+        (sha256+          (base32+            "04w3lhnbnfynrr3zpcr7cdrlddxa6v3mdmj7rvbxi2xbczbqpa15"))))+    (build-system gnu-build-system)+    (arguments+     `(#:make-flags+       (list "CC=gcc" "BUILD_MODULES=\"lv2 ladspa jack\"" "VST_UI=0"+             (string-append "PREFIX=" (assoc-ref %outputs "out"))+             (string-append "ETC_PATH=" (assoc-ref %outputs "out") "/etc"))+       #:phases+       (modify-phases %standard-phases+         (delete 'configure) ; no configure+         (replace 'check+           (lambda _+             (invoke "make" "test"))))))+    (inputs+      `(("cairo", cairo)+        ("hicolor-icon-theme", hicolor-icon-theme)+        ("jack", jack-1)+        ("ladspa", ladspa)+        ("libsndfile", libsndfile)+        ("lv2", lv2)+        ("mesa", mesa)))+    (native-inputs+      `(("pkg-config", pkg-config)))+    (synopsis "Audio plugin collection")+    (description "LSP (Linux Studio Plugins) is a collection of audio+plugins available as LADSPA/LV2 plugins and as standalone JACK+applications.")+    (home-page "https://lsp-plug.in/")+    (license license:lgpl3)))-- 2.26.0

Efraim Flashner wrote on 6 May 2020 21:55

Re: [bug#40471] [PATCH] gnu: Add lsp-plugins.

Recipients:(name . Alexandros Theodotou)(address . alex@zrythm.org)(address . 40471@debbugs.gnu.org)

Message-ID:20200506195525.GF2359@E5400

This actually failed to build for me, even when I bumped the version upto 1.1.19. Can you take a look at it?
Thanks

-- Efraim Flashner <efraim@flashner.co.il> אפרים פלשנרGPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351Confidentiality cannot be guaranteed on emails sent or received unencrypted

Alexandros Theodotou wrote on 27 May 2020 02:06

Recipients:(name . Efraim Flashner)(address . efraim@flashner.co.il)(address . 40471@debbugs.gnu.org)

Message-ID:4df3ebd1eb7b6bfbdac5f4840e13756427ca0a8f.camel@zrythm.org

Fixed! The failure was due to the lv2 upgrade. The upstream has fixedthis in the new release.
See new patch attached.
Thanks,Alex
On Wed, 2020-05-06 at 22:55 +0300, Efraim Flashner wrote:

Toggle quote (7 lines)> This actually failed to build for me, even when I bumped the version> up> to 1.1.19. Can you take a look at it?> > Thanks> >

From b3aa2ea22bc2be15a7ab11c792ea85a1ec3900d6 Mon Sep 17 00:00:00 2001
* gnu/packages/music.scm (lsp-plugins): new variable.--- gnu/packages/music.scm | 43 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+)

Toggle diff (56 lines)diff --git a/gnu/packages/music.scm b/gnu/packages/music.scmindex 2c6be8eba8..f01978d118 100644--- a/gnu/packages/music.scm+++ b/gnu/packages/music.scm@@ -4863,6 +4863,49 @@ effects.  It contains a bitcrusher, delay, distortion, equalizer, compressor, and reverb.")     (license license:gpl2+))) +(define-public lsp-plugins+  (package+    (name "lsp-plugins")+    (version "1.1.21")+    (source+      (origin+        (method git-fetch)+        (uri (git-reference+               (url "https://github.com/sadko4u/lsp-plugins.git")+               (commit (string-append "lsp-plugins-" version))))+        (file-name (git-file-name name version))+        (sha256+          (base32+            "1zw0iip6ki9k65kh8dp53x7l4va4mi5rj793n2yn4p9y84qzwrz9"))))+    (build-system gnu-build-system)+    (arguments+     `(#:make-flags+       (list "CC=gcc" "BUILD_MODULES=\"lv2 ladspa jack\"" "VST_UI=0"+             (string-append "PREFIX=" (assoc-ref %outputs "out"))+             (string-append "ETC_PATH=" (assoc-ref %outputs "out") "/etc"))+       #:phases+       (modify-phases %standard-phases+         (delete 'configure) ; no configure+         (replace 'check+           (lambda _+             (invoke "make" "test"))))))+    (inputs+      `(("cairo", cairo)+        ("hicolor-icon-theme", hicolor-icon-theme)+        ("jack", jack-1)+        ("ladspa", ladspa)+        ("libsndfile", libsndfile)+        ("lv2", lv2)+        ("mesa", mesa)))+    (native-inputs+      `(("pkg-config", pkg-config)))+    (synopsis "Audio plugin collection")+    (description "LSP (Linux Studio Plugins) is a collection of audio+plugins available as LADSPA/LV2 plugins and as standalone JACK+applications.")+    (home-page "https://lsp-plug.in/")+    (license license:lgpl3)))+ (define-public sherlock-lv2   (package     (name "sherlock-lv2")-- 2.26.2

Efraim Flashner wrote on 27 May 2020 11:25

Recipients:(name . Alexandros Theodotou)(address . alex@zrythm.org)(address . 40471-done@debbugs.gnu.org)

Message-ID:20200527092508.GA10771@E5400

Patched pushed with a few changes:
On Wed, May 27, 2020 at 01:06:38AM +0100, Alexandros Theodotou wrote:

Toggle quote (53 lines)> Fixed! The failure was due to the lv2 upgrade. The upstream has fixed> this in the new release.> > See new patch attached.> > Thanks,> Alex> > On Wed, 2020-05-06 at 22:55 +0300, Efraim Flashner wrote:> > This actually failed to build for me, even when I bumped the version> > up> > to 1.1.19. Can you take a look at it?> > > > Thanks> > > > 
> From b3aa2ea22bc2be15a7ab11c792ea85a1ec3900d6 Mon Sep 17 00:00:00 2001> From: Alexandros Theodotou <alex@zrythm.org>> Date: Wed, 27 May 2020 01:04:42 +0100> Subject: [PATCH] gnu: Add lsp-plugins.> > * gnu/packages/music.scm (lsp-plugins): new variable.> --->  gnu/packages/music.scm | 43 ++++++++++++++++++++++++++++++++++++++++++>  1 file changed, 43 insertions(+)> > diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm> index 2c6be8eba8..f01978d118 100644> --- a/gnu/packages/music.scm> +++ b/gnu/packages/music.scm> @@ -4863,6 +4863,49 @@ effects.  It contains a bitcrusher, delay, distortion, equalizer, compressor,>  and reverb.")>      (license license:gpl2+)))>  > +(define-public lsp-plugins> +  (package> +    (name "lsp-plugins")> +    (version "1.1.21")> +    (source> +      (origin> +        (method git-fetch)> +        (uri (git-reference> +               (url "https://github.com/sadko4u/lsp-plugins.git")> +               (commit (string-append "lsp-plugins-" version))))> +        (file-name (git-file-name name version))> +        (sha256> +          (base32> +            "1zw0iip6ki9k65kh8dp53x7l4va4mi5rj793n2yn4p9y84qzwrz9"))))> +    (build-system gnu-build-system)> +    (arguments> +     `(#:make-flags

I changed the CC=gcc line so that it can cross compile

Toggle quote (7 lines)

> + (list "CC=gcc" "BUILD_MODULES=\"lv2 ladspa jack\"" "VST_UI=0"> + (string-append "PREFIX=" (assoc-ref %outputs "out"))> + (string-append "ETC_PATH=" (assoc-ref %outputs "out") "/etc"))> + #:phases> + (modify-phases %standard-phases> + (delete 'configure) ; no configure

I changed this to a #:test-flag

Toggle quote (4 lines)

> + (replace 'check> + (lambda _> + (invoke "make" "test"))))))

And I re-indented so that the ` was under the 'i' in inputs.Same with native-inputs.

Toggle quote (27 lines)> +    (inputs> +      `(("cairo", cairo)> +        ("hicolor-icon-theme", hicolor-icon-theme)> +        ("jack", jack-1)> +        ("ladspa", ladspa)> +        ("libsndfile", libsndfile)> +        ("lv2", lv2)> +        ("mesa", mesa)))> +    (native-inputs> +      `(("pkg-config", pkg-config)))> +    (synopsis "Audio plugin collection")> +    (description "LSP (Linux Studio Plugins) is a collection of audio> +plugins available as LADSPA/LV2 plugins and as standalone JACK> +applications.")> +    (home-page "https://lsp-plug.in/")> +    (license license:lgpl3)))> +>  (define-public sherlock-lv2>    (package>      (name "sherlock-lv2")> -- > 2.26.2> 

-- Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנרGPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351Confidentiality cannot be guaranteed on emails sent or received unencrypted

Closed

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date