[PATCH] gnu: kmod: Update to 27.

---

This patch need to be merge on core-updates because > 2200 packages will need

to be rebuilt. Without this patch (in particular `--sysconfdir=/etc`) it's

not possible to pass module arguments to `kernel-module-loader` from

https://issues.guix.info/issue/40274.

gnu/packages/linux.scm | 9 +++++----

1 file changed, 5 insertions(+), 4 deletions(-)

Brice Waegeneire <brice@waegenei.re> writes:

As the core-updates branch is frozen right now, could you submit this

patch as a 'kmod/next' variable? See e.g. 'help2man/latest' or

'automake-1.16.2' for inspiration.

After the core-updates merge, we can do a larger 'staging' round that

updates the default 'kmod'.

I wonder if we should patch eudev to use

/run/current-system/profile/bin/ instead of /gnu/store/...kmod/bin so

that we can update kmod without triggering a huge rebuild.

On 2020-04-05 14:45, Marius Bakke wrote:

I can do that but I would need to adjust %modprobe-wrapper for

`kernel-loader-module` to work without the crutch at 8c88e24229 since

the service

gets its modprobe from "/proc/sys/kernel/modprobe".

eudev uses libkmod to to use it's kmod feature so I'm not sure how to do

this.

Brice Waegeneire <brice@waegenei.re> writes:

Huh, what kind of sorcery is this? :-)

Let's hold this patch until core-updates is merged, then I think we can

run it through 'staging'.

Oh right, I didn't realize there was a libkmod.

---

This patch isn't related with #40274[0] anymore, the “--sysconfdir” flag has

been removed as well as the reverting commit. As discussed in[1] the

configuration of modprobe will be done, in an other patch series, by setting

the “MODPROBE_OPTIONS” varaible in the wrapper returned by

“/proc/sys/kernel/modprobe”.

[0] https://issues.guix.info/issue/40274

[1]: https://lists.gnu.org/archive/html/guix-devel/2020-04/msg00108.html

gnu/packages/linux.scm | 9 +++++----

1 file changed, 5 insertions(+), 4 deletions(-)

Hi Brice,

I get

depmod: WARNING: could not open modules.order at /lib/modules/4.4.4: No such file or directory

depmod: WARNING: could not open modules.builtin at /lib/modules/4.4.4: No such file or directory

depmod: WARNING: could not open modules.order at /lib/modules/4.4.4: No such file or directory

depmod: WARNING: could not open modules.builtin at /lib/modules/4.4.4: No such file or directory

[...]

TESTSUITE: 'depmod_search_order_external_last' [7595] exited with return code 0

TESTSUITE: ERR: sizes do not match /tmp/guix-build-kmod-27.drv-0/kmod-27/testsuite/rootfs/test-depmod/search-order-external-last/lib/modules/4.4.4/correct-modules.dep /tmp/guix-build-kmod-27.drv-0/kmod-27/testsuite/rootfs/test-depmod/search-order-external-last/lib/modules/4.4.4/modules.dep

TESTSUITE: ERR: FAILED: exit ok but outputs do not match: depmod_search_order_external_last

TESTSUITE: ------

FAIL testsuite/test-depmod (exit status: 1)

with your patch on staging...

[native-inputs]: Add 'automake' and 'autoconf'.

[arguments]: Add phase 'disable-tests'. Add configure flag

'--disable-test-modules'. Enable tests.

---

This version disable the 3 tests failling when '--sysconfdir=/etc' isn't used

as warned by “warning: Some tests will fail without --sysconfdir=/etc”.

gnu/packages/linux.scm | 20 +++++++++++++++-----

1 file changed, 15 insertions(+), 5 deletions(-)

Hello Danny,

On 2020-04-13 11:20, Danny Milosavljevic wrote:

Thanks for the heads up. As written in the Makefile not using

“--sysconfdir=/etc” will make some tests fail, these tests are now

disable

in v4. BTW this patch should go on core-updates.

Cheers,

- Brice

Ping?

[native-inputs]: Add 'automake' and 'autoconf'.

[arguments]: Add phase 'disable-tests'. Add configure flag

'--disable-test-modules'. Enable tests.

---

Phase 'disable-tests' returns #t.

gnu/packages/linux.scm | 21 ++++++++++++++++-----

1 file changed, 16 insertions(+), 5 deletions(-)

Pushed on staging as 8229ce3116c1f522c7157ab2dcd50dc2d765686a.