It would be good to wrap gnome-chess to include it's own share directoryin the XDG_DATA_DIRS environment variable. Without that, I can't justrun it , but when I set that variable correctly , it works :) 1:→ /gnu/store/jv8jpq23iic13j7zdl8mdc30vcv508wh-gnome-chess-3.36.0/bin/gnome-chess (gnome-chess:10039): GLib-GIO-ERROR **: 08:31:52.482: Settings schema 'org.gnome.Chess' is not installedTrace/breakpoint trap 2:→ XDG_DATA_DIRS="$XDG_DATA_DIRS:/gnu/store/jv8jpq23iic13j7zdl8mdc30vcv508wh-gnome-chess-3.36.0/share" /gnu/store/jv8jpq23iic13j7zdl8mdc30vcv508wh-gnome-chess-3.36.0/bin/gnome-chess
This wrapping is something that would automatically be done through theglib-or-gtk-build-system, but maybe not automatically through the mesonbuild system.
Toggle quote (21 lines)> + (inputs> + `(("gtk+" ,gtk+)> + ("librsvg" ,librsvg)))> + (native-inputs> + `(("gettext" ,gettext-minimal)> + ("glib:bin" ,glib "bin") ; for desktop-file-validate and appstream-util> + ("itstool" ,itstool)> + ("pkg-config" ,pkg-config)> + ("vala" ,vala)))> + (home-page "https://wiki.gnome.org/Apps/Chess")> + (synopsis "Chess board for GNOME")> + (description "GNOME Chess provides a 2D board for playing chess games> +against human or computer players. It supports loading and saving games in> +Portable Game Notation. To play against a computer, install a chess engine> +such as chess or stockfish.")> + (license license:gpl3+)))> +> (define-public gnubg> (package> (name "gnubg")
Apart from the wrapping I mentioned above, this looks good to me :) Thanks, Chris
* gnu/packages/games.scm (gnome-chess): New variable.--- Thanks for the review and suggestion. I've added the #glib-or-gtk? #targument, and it looks like the wrapping happens correctly. gnu/packages/games.scm | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+)
(name . Jack Hill)(address . email@example.com)
Jack Hill <firstname.lastname@example.org> writes:
Toggle quote (6 lines)> * gnu/packages/games.scm (gnome-chess): New variable.> --->> Thanks for the review and suggestion. I've added the #glib-or-gtk? #t> argument, and it looks like the wrapping happens correctly.
Great, I've pushed this as 63406c0bfd0d016098ef593dcc8bfc412df36bea. Thanks for the patch!