[PATCH] Enable tests for python-aiohttp

  • Done
  • quality assurance status badge
Details
2 participants
  • Lars-Dominik Braun
  • Ludovic Courtès
Owner
unassigned
Submitted by
Lars-Dominik Braun
Severity
normal
L
L
Lars-Dominik Braun wrote on 27 Mar 2020 14:10
(address . guix-patches@gnu.org)
20200327131008.GC4578@zpidnp36
Hi,

this patch-set enables tests for python-aiohttp.

gunicorn 20.0.4 fixes a critical bug that prevents using it on a guix system
and python-pytest-forked is required for the tests. We also need to cut through
a circular dependency (gunicorn<->aiohttp), thus gunicorn-bootstrap is introduced.

Cheers,
Lars
From 405d7831be08b7f00643b7b28a88ce60c2ebcd00 Mon Sep 17 00:00:00 2001
From: Lars-Dominik Braun <ldb@leibniz-psychology.org>
Date: Fri, 27 Mar 2020 13:55:03 +0100
Subject: [PATCH 1/3] gnu: gunicorn: Update to 20.0.4

* gnu/packages/python-web.scm (gunicorn) [version]: Update to 20.0.4
[arguments] Re-enable previously failing tests
---
gnu/packages/python-web.scm | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)

Toggle diff (35 lines)
diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 26e2fe04ec..19c08026f2 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -3390,14 +3390,14 @@ hard or impossible to fix in cssselect.")
(define-public gunicorn
(package
(name "gunicorn")
- (version "20.0.0")
+ (version "20.0.4")
(source
(origin
(method url-fetch)
(uri (pypi-uri "gunicorn" version))
(sha256
(base32
- "0l1zm8a0vz8ws3lkn8q9a0f93ipdzyvlf2zlwdj5xyadh6jdwsgg"))))
+ "09n6fc019bgrvph1s5h1lwhn2avcsprw6ncd203qhra3i8mvn10r"))))
(outputs '("out" "doc"))
(build-system python-build-system)
(arguments
@@ -3413,11 +3413,6 @@ hard or impossible to fix in cssselect.")
(lambda _
(setenv "PYTHONPATH"
(string-append ".:" (getenv "PYTHONPATH")))
- ;; Remove test modules failing due to libc not found due to
- ;; section '.dynamic' not found in libc.so
- (delete-file "tests/test_arbiter.py")
- (delete-file "tests/test_config.py")
- (delete-file "tests/test_sock.py")
(invoke "pytest")))
(add-after 'install 'install-doc
(lambda* (#:key outputs #:allow-other-keys)
--
2.20.1
From 02c51b326e72a501cc00216a34355ce0512ca449 Mon Sep 17 00:00:00 2001
From: Lars-Dominik Braun <ldb@leibniz-psychology.org>
Date: Fri, 27 Mar 2020 13:57:00 +0100
Subject: [PATCH 2/3] gnu: Add python-pytest-forked

* gnu/packages/check.scm (python-pytest-forked): New variable.
---
gnu/packages/check.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)

Toggle diff (38 lines)
diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
index 1b60b99ce1..ef0d4e3aec 100644
--- a/gnu/packages/check.scm
+++ b/gnu/packages/check.scm
@@ -1025,6 +1025,31 @@ result back.")
timeout has been exceeded.")
(license license:expat)))
+(define-public python-pytest-forked
+ (package
+ (name "python-pytest-forked")
+ (version "1.1.3")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (pypi-uri "pytest-forked" version))
+ (sha256
+ (base32
+ "000i4q7my2fq4l49n8idx2c812dql97qv6qpm2vhrrn9v6g6j18q"))))
+ (build-system python-build-system)
+ (propagated-inputs
+ `(("python-pytest" ,python-pytest)))
+ (native-inputs
+ `(("python-setuptools-scm" ,python-setuptools-scm)))
+ (home-page
+ "https://github.com/pytest-dev/pytest-forked")
+ (synopsis
+ "Run tests in isolated forked subprocesses")
+ (description
+ "Pytest plugin which will run each test in a subprocess and will report if
+a test crashed the process.")
+ (license license:expat)))
+
(define-public python-scripttest
(package
(name "python-scripttest")
--
2.20.1
-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEEyk+M9DfXR4/aBV/UQhN3ARo3hEYFAl59+ywACgkQQhN3ARo3
hEal6Qv/W5aX4XhACLIegFKMcTSX/xaPc1l/peMLIdsr0Rt2UA0RS8O2G1a87fDW
9k7fY6sJnLiwv9ESTiJnEoryGS7NfJAjpVZAzoPa4NRfqdr/86eEU1/bxLSexXDN
wf7U2P2seU84g7GE8Dr7apMOsRd4I4UZ+kKf/0kvkbv0axjquxUBn+t/dMmwMkG4
ZRyjPNU9jpsSs/cq+gKbObxRnymmFuMhRLKmoW9xM10r1TENKvmfAO11/pUChXHr
Y3I8aKt4ikzoql+iP56Kyj8v7pgbF+RpVTyaPHfFonOsqJiAjMM1THReywzjWOyN
lafGJQgsUe6kVUAltFMWZAsBnWAmbklfE22M0eqIB4s6ofkwcyNc3XBJlOuoo2N7
+P9TBkdHMGKTiW6amqhD4Gi8BTnfCeT79PY4q8NZv7bghM4e3nZVSDYVybgoxIdE
N2RePccuZTOTXGbqy3W9jYvZ1tnqwYUxZaMVL3z3LW5phmuAfjhWr0jj6thBKyDT
vSU+05WO
=a2Tz
-----END PGP SIGNATURE-----


L
L
Ludovic Courtès wrote on 2 Apr 2020 00:05
(name . Lars-Dominik Braun)(address . ldb@leibniz-psychology.org)(address . 40251-done@debbugs.gnu.org)
87h7y2svya.fsf@gnu.org
Hello,

Lars-Dominik Braun <ldb@leibniz-psychology.org> skribis:

Toggle quote (8 lines)
> From 405d7831be08b7f00643b7b28a88ce60c2ebcd00 Mon Sep 17 00:00:00 2001
> From: Lars-Dominik Braun <ldb@leibniz-psychology.org>
> Date: Fri, 27 Mar 2020 13:55:03 +0100
> Subject: [PATCH 1/3] gnu: gunicorn: Update to 20.0.4
>
> * gnu/packages/python-web.scm (gunicorn) [version]: Update to 20.0.4
> [arguments] Re-enable previously failing tests

[...]

Toggle quote (7 lines)
> From 02c51b326e72a501cc00216a34355ce0512ca449 Mon Sep 17 00:00:00 2001
> From: Lars-Dominik Braun <ldb@leibniz-psychology.org>
> Date: Fri, 27 Mar 2020 13:57:00 +0100
> Subject: [PATCH 2/3] gnu: Add python-pytest-forked
>
> * gnu/packages/check.scm (python-pytest-forked): New variable.

[...]

Toggle quote (10 lines)
> From f3bbf527ca17d509a1c755960d0f7fc2c3daf8ea Mon Sep 17 00:00:00 2001
> From: Lars-Dominik Braun <ldb@leibniz-psychology.org>
> Date: Fri, 27 Mar 2020 13:58:11 +0100
> Subject: [PATCH 3/3] gnu: python-aiohttp: Enable tests
>
> * gnu/packages/python-web.scm (python-aiohttp) [arguments]: Enable tests
> [native-inputs] Add test dependencies [patches] Add test case patch
> * gnu/packages/patches/python-aiohttp-3.6.2-no-warning-fail.patch: New file
> * gnu/local.mk (dist_patch_DATA): Add it

Applied all three patches, thanks!

Ludo’.
Closed
?