[PATCH] Update emacs-org-recent-headings.

  • Done
  • quality assurance status badge
Details
5 participants
  • Morgan.J.Smith
  • Brian Leung
  • Ludovic Courtès
  • Nicolas Goaziou
  • Maxim Cournoyer
Owner
unassigned
Submitted by
Brian Leung
Severity
normal
B
B
Brian Leung wrote on 19 Aug 2019 08:34
(address . guix-patches@gnu.org)
CAAc=MEycq2ivBcsxBBSk24LfQpt=SS2=guU9YfZnDL9_G--G6w@mail.gmail.com
The version of emacs-org-recent-headings on Guix doesn't work correctly for
people with Helm installed. I submitted patches to the upstream maintainer
of emacs-org-recent-headings. Attached is a Guix patch incorporating the
changes.
Attachment: file
Attachment: 0001-gnu-emacs-org-recent-headings-Update-to-0.1-1.6336a0.patch
L
L
Ludovic Courtès wrote on 27 Aug 2019 12:30
(name . Brian Leung)(address . bkleung89@gmail.com)(address . 37080@debbugs.gnu.org)
87lfverjcq.fsf@gnu.org
Hi Brian,

Brian Leung <bkleung89@gmail.com> skribis:

Toggle quote (5 lines)
> The version of emacs-org-recent-headings on Guix doesn't work correctly for
> people with Helm installed. I submitted patches to the upstream maintainer
> of emacs-org-recent-headings. Attached is a Guix patch incorporating the
> changes.

Have these patches been applied upstream?

Since we’re building from an upstream commit, we might just as well wait
until the changes are available upstream.

Thanks,
Ludo’.
B
B
Brian Leung wrote on 27 Aug 2019 18:52
(name . Ludovic Courtès)(address . ludo@gnu.org)
CAAc=MEy6Va6Ln=5Lpr1b_m+1A-N+HvdK0u2ORzyRf7pcRFmbiA@mail.gmail.com
Hi Ludovic,

The patches haven't been applied upstream. The upstream maintainer doesn't
review PRs in a timely manner, so I thought it might be worth submitting
the patch here.

Thanks,
Brian

On Tue, Aug 27, 2019 at 12:30 PM Ludovic Courtès <ludo@gnu.org> wrote:

Toggle quote (19 lines)
> Hi Brian,
>
> Brian Leung <bkleung89@gmail.com> skribis:
>
> > The version of emacs-org-recent-headings on Guix doesn't work correctly
> for
> > people with Helm installed. I submitted patches to the upstream
> maintainer
> > of emacs-org-recent-headings. Attached is a Guix patch incorporating the
> > changes.
>
> Have these patches been applied upstream?
>
> Since we’re building from an upstream commit, we might just as well wait
> until the changes are available upstream.
>
> Thanks,
> Ludo’.
>
Attachment: file
M
M
Maxim Cournoyer wrote on 10 Sep 2019 06:24
(name . Brian Leung)(address . bkleung89@gmail.com)
87tv9ksrqr.fsf@gmail.com
Hello Brian,

Brian Leung <bkleung89@gmail.com> writes:

Toggle quote (30 lines)
> Hi Ludovic,
>
> The patches haven't been applied upstream. The upstream maintainer doesn't
> review PRs in a timely manner, so I thought it might be worth submitting
> the patch here.
>
> Thanks,
> Brian
>
> On Tue, Aug 27, 2019 at 12:30 PM Ludovic Courtès <ludo@gnu.org> wrote:
>
>> Hi Brian,
>>
>> Brian Leung <bkleung89@gmail.com> skribis:
>>
>> > The version of emacs-org-recent-headings on Guix doesn't work correctly
>> for
>> > people with Helm installed. I submitted patches to the upstream
>> maintainer
>> > of emacs-org-recent-headings. Attached is a Guix patch incorporating the
>> > changes.
>>
>> Have these patches been applied upstream?
>>
>> Since we’re building from an upstream commit, we might just as well wait
>> until the changes are available upstream.
>>
>> Thanks,
>> Ludo’.

+1, especially since the patches submitted upstream are still a WIP, AFAICT.

Let's wait until a conclusion for a fix is reached and merged upstream
before we continue.

Thanks for your efforts in investigating the problem and working on a fix.

Maxim
M
M
Morgan.J.Smith wrote on 23 Nov 2021 05:26
[PATCH] gnu: emacs-org-recent-headings: Update to 0.1-0.97418d5.
(name . Morgan Smith)(address . Morgan.J.Smith@outlook.com)
BYAPR05MB40232BE6478FA2E8D8FF388EC5609@BYAPR05MB4023.namprd05.prod.outlook.com
From: Morgan Smith <Morgan.J.Smith@outlook.com>

* gnu/packages/emacs-xyz.scm (emacs-org-recent-headings): Update to 0.1-0.97418d5.
[propagated-inputs]: Add emacs-s and emacs-helm
---

Looks like the issue got fixed upstream.



gnu/packages/emacs-xyz.scm | 46 +++++++++++++++++++++-----------------
1 file changed, 25 insertions(+), 21 deletions(-)

Toggle diff (60 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f98425eab9..0fb3ee3a0c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -17702,28 +17702,32 @@ (define-public emacs-frecency
(license license:gpl3+))))
(define-public emacs-org-recent-headings
- (package
- (name "emacs-org-recent-headings")
- (version "0.1")
- (source (origin
- (method git-fetch)
- (uri (git-reference
- (url "https://github.com/alphapapa/org-recent-headings")
- (commit version)))
- (file-name (git-file-name name version))
- (sha256
- (base32
- "0gsrzmg3mssh9s28yjm9m866fnhm1pcligssz1q6brga6dm6f2yy"))))
- (build-system emacs-build-system)
- (propagated-inputs
- `(("emacs-org" ,emacs-org)
- ("emacs-dash" ,emacs-dash)
- ("emacs-frecency" ,emacs-frecency)))
- (home-page "https://github.com/alphapapa/org-recent-headings")
- (synopsis "Navigate to recently used Org headings and lists")
- (description "This package maintains a list of recently used Org headings,
+ (let ((commit "97418d581ea030f0718794e50b005e9bae44582e")
+ (revision "0"))
+ (package
+ (name "emacs-org-recent-headings")
+ (version (git-version "0.1" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/alphapapa/org-recent-headings")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1y11rlnhi36lzhc1cagninv6hlcwbvj88xfr0g0xzpbzy7hys021"))))
+ (build-system emacs-build-system)
+ (propagated-inputs
+ `(("emacs-dash" ,emacs-dash)
+ ("emacs-frecency" ,emacs-frecency)
+ ("emacs-helm" ,emacs-helm)
+ ("emacs-org" ,emacs-org)
+ ("emacs-s" ,emacs-s)))
+ (home-page "https://github.com/alphapapa/org-recent-headings")
+ (synopsis "Navigate to recently used Org headings and lists")
+ (description "This package maintains a list of recently used Org headings,
as well as functions for navigating between these headings.")
- (license license:gpl3+)))
+ (license license:gpl3+))))
(define-public emacs-org-super-agenda
(package
--
2.34.0
N
N
Nicolas Goaziou wrote on 23 Nov 2021 10:33
(address . Morgan.J.Smith@outlook.com)
87bl2btdwf.fsf@nicolasgoaziou.fr
Hello,

Morgan.J.Smith@outlook.com writes:

Toggle quote (3 lines)
> * gnu/packages/emacs-xyz.scm (emacs-org-recent-headings): Update to 0.1-0.97418d5.
> [propagated-inputs]: Add emacs-s and emacs-helm

Applied. Thank you.

Regards,
--
Nicolas Goaziou
Closed
?