[PATCH] reconfigure: Reload all shepherd files when upgrading services.

  • Done
  • quality assurance status badge
Details
2 participants
  • Danny Milosavljevic
  • Jakob L. Kreuze
Owner
unassigned
Submitted by
Jakob L. Kreuze
Severity
normal
J
J
Jakob L. Kreuze wrote on 31 Jul 2019 20:13
(address . guix-patches@gnu.org)
87r266cbte.fsf@sdf.lonestar.org
Reported by Robert Vollmert <rob@vllmrt.net>.

* guix/scripts/system/reconfigure.scm (upgrade-shepherd-services): Load
all service files, rather than just those of services to be started.
---
guix/scripts/system/reconfigure.scm | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

Toggle diff (20 lines)
diff --git a/guix/scripts/system/reconfigure.scm b/guix/scripts/system/reconfigure.scm
index 8c7d461585..dee0c24bd2 100644
--- a/guix/scripts/system/reconfigure.scm
+++ b/guix/scripts/system/reconfigure.scm
@@ -161,12 +161,7 @@ services as defined by OS."
target-services)
(map live-service-canonical-name
live-services)))
- (service-files
- (map shepherd-service-file
- (filter (lambda (service)
- (memq (shepherd-service-canonical-name service)
- to-start))
- target-services))))
+ (service-files (map shepherd-service-file target-services)))
(eval #~(primitive-load #$(upgrade-services-program service-files
to-start
to-unload
--
2.22.0
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEa1VJLOiXAjQ2BGSm9Qb9Fp2P2VoFAl1B2i0ACgkQ9Qb9Fp2P
2VqI4A//e+wlKv9WUa8VsNrg5bGo0R1uyitmrQAecEKY8kCSsEmgXLkMynyyemX2
rUQkLGsCnHbekq6390qaVCeHzRVmdMSq0afkl0Oa6/zgLeH/8Ek6652Tw6HFA1oS
Q40IJEf07uYbLUnzaBQOkmMPqZQ5vTPHuIq5+RC4cv/6YUi7C20hisq66XvBGf+A
v/vtzXDwTQPExg59/0CZ/TyHuCqt+6xBGA35nDxvQCpdX85jTLVED0Gmkytl0Qdu
5tugVUZAYRDraMetzgg3pSlFGh3h94DPUWbcyhIscZkgIV4acoyvITy6t2CxvwcJ
P2ZLENg7JaV6BYvay8rn03jL0V6LRBVOGaDLslk463k9nw9neDXNUn5PHxtuMuDR
cANn+InX9KPLxHj6Mc5FXvRI8yn+0oVR8qSaXJMnPi+SCE7ZSTku0wIRsBcmshsc
x8ApdiOov+1KDKrFK6s2yPnV5/cHVgNiu46jIIehqSJR57F68f3Xu1v/LETqSlB8
TRf2MfNbQP1r993iSAW116FrQGK5JGIqXXf+OH5CiC5WSOZnuCkGfaAJbvxA8Lmv
/40FSbTRT78Q67sTqdzXmAgJWCRy6lLvsqW0YVY2ou4hd9SXnF9worQZfg+S/uXN
PKD6RKwqSFEV8rzJ54qtJvbAph1jSF3cRoSDyRgPLV3scawgZi8=
=opdx
-----END PGP SIGNATURE-----

D
D
Danny Milosavljevic wrote on 2 Aug 2019 11:21
(name . Jakob L. Kreuze)(address . zerodaysfordays@sdf.lonestar.org)(address . 36880-done@debbugs.gnu.org)
20190802112156.770e9c1a@scratchpost.org
I've pushed that patch to guix master as commit 1db6f137d93b59409fedb3deb24c876649e1b8f2 now.

Thanks!
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl1EALQACgkQ5xo1VCww
uqVeKAf7BLrZ3Ase9v2AoZfdsdLvUU9RjgqZVRH+plneg37sS+1D7C5dtikSfx7e
LJhczLlYAwes/l9sjX7b93Pdh7zbN9JYlpPBfnTZHqNIIpVcAhph7LMWbGCFkvfV
NlCwNPchM2Yh4m3RLkQNN/7EqIdHhvQKpH7vnvIM8GEYdpPhg9AQX8Tk5ikrwA7f
CmdDq5au4XbWvRTi1apiBQn4XP1xpGREBiA3vEd2LtJQDtfLSadkTBE7NwcEwjPr
VLIq3YTdZ6Zq13nS/DQfWjP4RkWV0+ciUBgB4TiBfEb1dLOGLrBF97E9sDAGkcCl
4sp/45Cf6OvyeM+iyDG8ccittpVSEQ==
=9iB2
-----END PGP SIGNATURE-----


Closed
J
J
Jakob L. Kreuze wrote on 2 Aug 2019 17:08
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)(address . 36880-done@debbugs.gnu.org)
87pnln1u6r.fsf@sdf.lonestar.org
Danny Milosavljevic <dannym@scratchpost.org> writes:

Toggle quote (4 lines)
> I've pushed that patch to guix master as commit 1db6f137d93b59409fedb3deb24c876649e1b8f2 now.
>
> Thanks!

Excellent; thank you, Danny!

Regards,
Jakob
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEa1VJLOiXAjQ2BGSm9Qb9Fp2P2VoFAl1EUewACgkQ9Qb9Fp2P
2VqUDBAAp1rR4LtZq/3GuXx67pLDj6yukT25Z8KHl7fAGijX4S/afL4WNulTgn1D
c+G5J2eNKs9QyPnBaPMThZkLbe3GsEaZ4XcqnO7+MruUmkISpklfY3IW++y5VYsn
5pgSr1nJ5bRzfkbv8Prc3upDG5PsObeXMYDKw7rCEXANIa6oxe1VUoub+7BKejVE
sFY2UtxsBKpO/DDLAZHHmUnYQR2uMq6mwpjFMUah+ahBEUK2Jy+BxRhVB2LwdH5H
myUDBBpasSq1G7EkrafbLh5Pot/mjjepBRe7NXLMbSdWs5o5pXoewNAnQshOHScT
ic6WYI/E/BQRQRQuy/bGbzG0v2T8fRHppE8qp9K6E5kxkwTiq6e8m4WQiEQ7vWGa
Lpk2Jd9q61srXbDAEiAl+XLepgHI9f/bgoTbYj+5aTlaUpZDbqY/S9lxkOUBBGD3
SBNtH3ZBxbRx8UR3n8rsZ2p0KZirTf0e4kk72rxsJT8HeeRaVfEvKE8gZg7i4CUL
zJB7PcdogsimLGtWisXOubviLh2d2lOxyzfQksQAuurWZKDPQlpgWIJF+STWp1qW
0vlm8vfycbkxO0/fMng0XJ58wzzfL7NjuN5ALu1iJUi8jcB3+Yt6N3g8Jke65/nC
FzKDNTaqc28pYTWIumJe/zD/aRcnnCHWLr6HKrjc+m1d17hU+v8=
=1BwD
-----END PGP SIGNATURE-----

Closed
?