gitolite broken: created repositories keep references to /usr/bin for hooks

OpenSubmitted by ng0.
Details
2 participants
  • ng0
  • Danny Milosavljevic
Owner
unassigned
Severity
normal
N
(address . bug-guix@gnu.org)
20170303215819.bttmrfsbhlxyipmy@abyayala
Our gitolite package currently creates all(including gitolite-admin.git) git repositories with references to"/usr/bin/perl" as shebang, which makes it completely useless onserverside.Given that the server side in the case of a gitolite from Guix runs anenvironment where you will not run perl from /usr/bin/, you will have tochange all hooks manually currently.
When you install perl into the profile of the user which hosts therepositories and change the shebangs, gitolite can be used.
N
Re: bug#25957: Acknowledgement (gitolite broken: created repositories keep references to /usr/bin for hooks)
(address . 25957@debbugs.gnu.org)
20170303222743.wf777eedaauuof3f@abyayala
What makes this worse, with every update (push) of gitolite-adminrepository the shebang of "hooks/update" is reset.Other repositories seem to keep changes in the hooks shebangs sofar.
N
(address . 25957@debbugs.gnu.org)
20170304133242.towlmzdcm6x43hvi@abyayala
On 17-03-03 22:27:43, ng0 wrote:
Toggle quote (8 lines)> What makes this worse, with every update (push) of gitolite-admin> repository the shebang of "hooks/update" is reset.> Other repositories seem to keep changes in the hooks shebangs so> far.> > >
When I build gitolite from guix, this looks trivial to fix.
[user@abyayala /gnu/store/jw252kw9blfh1lrrib3yk4fkbj5mvdpm-gitolite-3.6.5/share/gitolite]$ egrep -nr "/usr/"commands/svnserve:9:$svnserve ||= "/usr/bin/svnserve -r /var/svn/ -t --tunnel-user=%u";lib/Gitolite/Test/Tsh.pm:42:# path when cwd is [...] at /usr/share/perl5/File/Temp.pm line 902".lib/Gitolite/Hooks/PostUpdate.pm:62:#!/usr/bin/perllib/Gitolite/Hooks/Update.pm:158:#!/usr/bin/perllib/Gitolite/Cache.pm:127: open( REDIS, "|-", "/usr/sbin/redis-server", "-" ) or die "start redis server failed: $!";

The parts I want to fix as my immediately affect every user, are inthe directory "lib/Gitolite/Hooks/", I have no idea about redis, butI think there should be a reference to /gnu/store/ reddis and not"/usr/sbin/redis-server". Different problem, related bug.. This can besolved in a commit after this bug.
D
D
Danny Milosavljevic wrote on 4 Mar 2017 16:43
(name . ng0)(address . contact.ng0@cryptolab.net)(address . 25957@debbugs.gnu.org)
20170304164309.08e43b4c@scratchpost.org
Hi ng0,
Toggle quote (4 lines)> I think there should be a reference to /gnu/store/ reddis and not> "/usr/sbin/redis-server". Different problem, related bug.. This can be> solved in a commit after this bug.
Yeah.
I would question why a normal application needs to start a redis *server* in the first place. Sounds strange to me. But I agree that if it wants to do that it should use a store reference.
https://redis.io/topics/admin says "Redis is designed to be a very long running process in your server" so that definitely reads to me that a normal program shouldn't just start redis-server when it feels like it (and I hope it stops it again later? After reading the source code it doesn't appear that way...).
http://gitolite.com/gitolite/cache.html says "WARNING: this has not been tested in a while. YMMV". Uhhhh. Not confidence-inspiring.
N
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)(address . 25957@debbugs.gnu.org)
20170304173339.ubumkmfdfrkbascj@abyayala
On 17-03-04 16:43:09, Danny Milosavljevic wrote:
Toggle quote (14 lines)> Hi ng0,> > > I think there should be a reference to /gnu/store/ reddis and not> > "/usr/sbin/redis-server". Different problem, related bug.. This can be> > solved in a commit after this bug.> > Yeah.> > I would question why a normal application needs to start a redis *server* in the first place. Sounds strange to me. But I agree that if it wants to do that it should use a store reference.> > <https://redis.io/topics/admin> says "Redis is designed to be a very long running process in your server" so that definitely reads to me that a normal program shouldn't just start redis-server when it feels like it (and I hope it stops it again later? After reading the source code it doesn't appear that way...).> > <http://gitolite.com/gitolite/cache.html> says "WARNING: this has not been tested in a while. YMMV". Uhhhh. Not confidence-inspiring.
It was the first time I read about reddis in gitolite context, and inall the time I used gitolite I never really needed it when building orrunning.I disregard this as not very important and not really important at allto fix. It should be fixed in the long run, but my main concern wasusability of gitolite, which has been addressed in one of the twopatches I've sent.
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send email to 25957@debbugs.gnu.org