[PATCH 2/2] gnu: Add xnedit and motif

  • Done
  • quality assurance status badge
Details
4 participants
  • Andy Tai
  • ???
  • Andy Tai
  • Simon Tournier
Owner
unassigned
Submitted by
Andy Tai
Severity
normal
A
A
Andy Tai wrote on 29 Jan 2023 05:20
(address . guix-patches@gnu.org)(name . Andy Tai)(address . atai@atai.org)
20230129042001.30367-1-atai@atai.org
* gnu/packages/text-editors.scm (xnedit): New variable
---
gnu/packages/text-editors.scm | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)

Toggle diff (58 lines)
diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index 9dd5d7793f..3898ab1eb7 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -21,6 +21,7 @@
;;; Copyright © 2022 Foo Chuan Wei <chuanwei.foo@hotmail.com>
;;; Copyright © 2022 zamfofex <zamfofex@twdb.moe>
;;; Copyright © 2022 jgart <jgart@dismail.de>
+;;; Copyright © 2022 Andy Tai <atai@atai.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -75,6 +76,7 @@ (define-module (gnu packages text-editors)
#:use-module (gnu packages hunspell)
#:use-module (gnu packages icu4c)
#:use-module (gnu packages image)
+ #:use-module (gnu packages lesstif)
#:use-module (gnu packages libbsd)
#:use-module (gnu packages llvm)
#:use-module (gnu packages lua)
@@ -1391,3 +1393,35 @@ (define-public lite-xl
The aim of Lite XL compared to lite is to be more user-friendly, improve the
quality of font rendering, and reduce CPU usage.")
(license license:expat)))
+
+(define-public xnedit
+ (package
+ (name "xnedit")
+ (version "1.4.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://sourceforge/xnedit/" name "-"
+ version ".tar.gz"))
+ (sha256
+ (base32
+ "0fw3li7hr47hckm9pl1njx30lfr6cx2p094ir8zmgr91hyxidgld"))))
+
+ (build-system gnu-build-system)
+ (arguments
+ (list
+ #:make-flags #~(list (string-append "PREFIX=" #$output)
+ (string-append "CC=" #$(cc-for-target)))
+ #:tests? #f ;no tests
+ #:phases #~(modify-phases %standard-phases
+ (delete 'configure)
+ (replace 'build
+ (lambda* (#:key make-flags #:allow-other-keys)
+ (apply invoke "make" "linux" make-flags))))))
+ (inputs (list motif pcre))
+ (native-inputs (list pkg-config))
+ (home-page "https://sourceforge.net/projects/xnedit/")
+ (synopsis "Fast and classic X11 text editor")
+ (description
+ "XNEdit is a fast and classic X11 text editor, based on NEdit,
+with full unicode support and antialiased text rendering.")
+ (license license:gpl2+)))
--
2.39.1
A
A
Andy Tai wrote on 29 Jan 2023 05:24
[PATCH 1/2] gnu: Add motif and xnedit
(address . 61134@debbugs.gnu.org)(name . Andy Tai)(address . atai@atai.org)
20230129042425.30552-1-atai@atai.org
* gnu/packages/lesstif.scm (motif): New variable
---
gnu/packages/lesstif.scm | 40 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)

Toggle diff (65 lines)
diff --git a/gnu/packages/lesstif.scm b/gnu/packages/lesstif.scm
index 8f017f41be..1ab471e4fa 100644
--- a/gnu/packages/lesstif.scm
+++ b/gnu/packages/lesstif.scm
@@ -1,5 +1,6 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2013 Andreas Enge <andreas@enge.fr>
+;;; Copyright © 2022 Andy Tai <atai@atai.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -21,6 +22,12 @@ (define-module (gnu packages lesstif)
#:use-module (guix packages)
#:use-module (guix download)
#:use-module (guix build-system gnu)
+ #:use-module (guix git-download)
+ #:use-module (gnu packages autotools)
+ #:use-module (gnu packages c)
+ #:use-module (gnu packages flex)
+ #:use-module (gnu packages fontutils)
+ #:use-module (gnu packages pkg-config)
#:use-module (gnu packages xorg))
@@ -46,3 +53,36 @@ (define-public lesstif
(synopsis "Clone of the Motif toolkit for the X window system")
(description "Clone of the Motif toolkit for the X window system.")
(license license:gpl2+))) ; some files are lgpl2.1+ or x11
+
+(define-public motif
+ ;; This commit is from September 2021 and v2.3.8 from 2017.
+ (let ((commit "59858b0811e8d9dfaeb142f2b5a96f55482be1ed")
+ (revision "0"))
+ (package
+ (name "motif")
+ (version (git-version "2.3.8" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://git.code.sf.net/p/motif/code")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0yycq0vzga9qmgbfzn2d02ilpwxixwdv2j1d8sddl4dripcrg21m"))))
+ (build-system gnu-build-system)
+ (inputs
+ (list libx11 xorgproto))
+ (propagated-inputs
+ (list fontconfig freetype libxext libxft libxpm libxt xbitmaps))
+ (native-inputs
+ (list autoconf automake byacc flex libtool pkg-config))
+ (home-page "https://motif.ics.com/motif")
+ (synopsis "Motif toolkit for the X window system")
+ (description "Motif is a standard graphical user interface, (as
+defined by the IEEE 1295 specification), used on more than 200 hardware and
+software platforms. It provides application developers, end users, and system
+vendors with a widely used environment for standardizing
+application presentation on a wide range of platforms.")
+ (license license:lgpl2.1+))))

base-commit: c6ec9c7af9814f84f293f62235eab9d0649751a7
--
2.39.1
A
A
Andy Tai wrote on 30 Jan 2023 16:35
Re: bug#59093: [PATCH] Add motif and xnedit
(name . Simon Tournier)(address . zimon.toutoune@gmail.com)
CAJsg1E-Q0Fft_JEdEK7uKLARugT9k=suRSf3yUQ=mvwJ1RXYMg@mail.gmail.com
I did it so Guix QA can pick it up to queue it for testing.

Guix QA seemed confused about the old bug, always in a failed state

On Mon, Jan 30, 2023 at 4:47 AM Simon Tournier <zimon.toutoune@gmail.com> wrote:
Toggle quote (14 lines)
>
> Hi,
>
> On sam., 28 janv. 2023 at 20:16, Andy Tai <lichengtai@gmail.com> wrote:
>
> > close 59093
>
> Why do you close it? And then you open #61134 [1] with the same patch.
>
> 1: <http://issues.guix.gnu.org/issue/61134>
>
>
> Cheers,
> simon
S
S
Simon Tournier wrote on 31 Jan 2023 10:56
Re: [bug#59093] [PATCH] Add motif and xnedit
(name . Andy Tai)(address . lichengtai@gmail.com)
86fsbrvxhb.fsf@gmail.com
Hi,

On Mon, 30 Jan 2023 at 07:35, Andy Tai <lichengtai@gmail.com> wrote:

Toggle quote (2 lines)
> Guix QA seemed confused about the old bug, always in a failed state

It appears to me better to point the issues and then maybe fix them
instead of bypassing them. My 2 cents.

Cheers,
simon
A
A
Andy Tai wrote on 31 Jan 2023 18:15
(name . Simon Tournier)(address . zimon.toutoune@gmail.com)
CAJsg1E_wKTZcLmZZFgYBHzR34nBYBEcosZrCTcqzzovY4eTnpQ@mail.gmail.com
you meant fixing the issue in Guix QA?

It goes without saying that Guix QA is far from the code in question
of this issue and my question on Guix QA also went unanswered on the
mailing list.



On Tue, Jan 31, 2023 at 3:36 AM Simon Tournier <zimon.toutoune@gmail.com> wrote:
Toggle quote (12 lines)
>
> Hi,
>
> On Mon, 30 Jan 2023 at 07:35, Andy Tai <lichengtai@gmail.com> wrote:
>
> > Guix QA seemed confused about the old bug, always in a failed state
>
> It appears to me better to point the issues and then maybe fix them
> instead of bypassing them. My 2 cents.
>
> Cheers,
> simon
A
A
Andy Tai wrote on 31 Jan 2023 19:12
(name . Simon Tournier)(address . zimon.toutoune@gmail.com)
CAJsg1E-kT9Nr626adUzi4OkCuLSvQp0fB+5vnP6FH3-NDPHSWg@mail.gmail.com
To clarify, when I mentioned Guix QA shows failure, Guiox QA was
showing "failure" trying to queue the issue to build, not that Gux QA
was showing some build log with the patch failing to build in some
way.

So I don't know if you are saying people should look at Guix QA
sources and help to fix that. That is possible, of course, but people
contributing to Guix patches may have no background at all at how Guix
QA works.

On Tue, Jan 31, 2023 at 9:15 AM Andy Tai <atai@atai.org> wrote:
Toggle quote (25 lines)
>
> you meant fixing the issue in Guix QA?
>
> It goes without saying that Guix QA is far from the code in question
> of this issue and my question on Guix QA also went unanswered on the
> mailing list.
>
>
>
> On Tue, Jan 31, 2023 at 3:36 AM Simon Tournier <zimon.toutoune@gmail.com> wrote:
> >
> > Hi,
> >
> > On Mon, 30 Jan 2023 at 07:35, Andy Tai <lichengtai@gmail.com> wrote:
> >
> > > Guix QA seemed confused about the old bug, always in a failed state
> >
> > It appears to me better to point the issues and then maybe fix them
> > instead of bypassing them. My 2 cents.
> >
> > Cheers,
> > simon



--
Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
Year 2023 ??112?
????????????
????????????
S
S
Simon Tournier wrote on 1 Feb 2023 11:08
Re: [bug#61134] [bug#59093] [PATCH] Add motif and xnedit
(name . Andy Tai)(address . atai@atai.org)
86zg9xu28m.fsf@gmail.com
Hi Andy,

On Tue, 31 Jan 2023 at 10:12, Andy Tai <atai@atai.org> wrote:
Toggle quote (10 lines)
> To clarify, when I mentioned Guix QA shows failure, Guiox QA was
> showing "failure" trying to queue the issue to build, not that Gux QA
> was showing some build log with the patch failing to build in some
> way.
>
> So I don't know if you are saying people should look at Guix QA
> sources and help to fix that. That is possible, of course, but people
> contributing to Guix patches may have no background at all at how Guix
> QA works.

I have understood the first time. :-)

I wrote: «It appears to me better to point the issues and then maybe fix
them instead of bypassing them. My 2 cents.»

I am not saying that you should fix issues with QA, obviously not.
Instead, I am proposing that if you notice something unexpected with QA,
you should report it and not silently bypass it.

“Report it” means for example drop an email to guix-devel or open a bug
or roam on #guix and tell. I do not know what is the best and it does
not mean that the issue about QA will be fixed. It just helps in
improving the tools, IMHO.

Well, for what it is worth, I am trying to say that silently close and
reopen another ticket because QA does not behave as expected is a
short-term hack – and yes it is often necessary to have the task done
now :-) – but by silently closing it does not help for the longer term.

Thanks for your contributions and taking the time to discuss how we
could collectively improve Guix. :-)

Cheers,
simon
?
?
??? wrote on 10 Feb 2023 07:10
Re: bug#61134: [PATCH 2/2] gnu: Add xnedit and motif
(name . Andy Tai)(address . atai@atai.org)(address . 61134-done@debbugs.gnu.org)
87h6vuhwz6.fsf@envs.net
Andy Tai <atai@atai.org> writes:

Toggle quote (2 lines)
> * gnu/packages/text-editors.scm (xnedit): New variable

Pushed, thank you!
Closed
?