Unbound variables in Guix Home

  • Done
  • quality assurance status badge
Details
2 participants
  • Andrew Tropin
  • Oleg Pykhalov
Owner
unassigned
Submitted by
Oleg Pykhalov
Severity
normal
O
O
Oleg Pykhalov wrote on 27 Sep 2021 23:15
(name . bug-guix)(address . bug-guix@gnu.org)(name . Andrew Tropin)(address . andrew@trop.in)
87k0j14t56.fsf@gmail.com
Hi Guix,

We have unbound variables in some Guix Home files:
Toggle snippet (12 lines)
gnu/home-services/configuration.scm:56:6: warning: possibly unbound variable `formatted-message'
gnu/home-services/configuration.scm:57:7: warning: possibly unbound variable `G_'
gnu/home-services/xdg.scm:309:43: warning: possibly unbound variable `maybe-list'
gnu/home-services/xdg.scm:330:13: warning: possibly unbound variable `list->human-readable-list'
guix/scripts/home/import.scm:210:18: warning: possibly unbound variable `package-version'
guix/scripts/home/import.scm:210:35: warning: possibly unbound variable `find-packages-by-name'
guix/scripts/home/import.scm:222:23: warning: possibly unbound variable `cut'
guix/scripts/home/import.scm:222:27: warning: possibly unbound variable `version>?'
guix/scripts/home/import.scm:222:45: warning: possibly unbound variable `<>'
guix/scripts/home/import.scm:225:16: warning: possibly unbound variable `version-unique-prefix'

maybe-list and list->human-readable-list come from
gnu/home-services-utils.scm in rde project.

Oleg.
-----BEGIN PGP SIGNATURE-----

iQJIBAEBCgAyFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAmFSNHUUHGdvLndpZ3Vz
dEBnbWFpbC5jb20ACgkQFn+OpQAa+pxcGQ/+Ooci//+FzKcSRP1VAPXZxe4fMVWJ
1ADm10JL4v+yGYTdyLnclFfE4sPzDqU4fbjMKo1lXE/mn6I53XwaWVBQwPJsObCZ
DUTf7BVkAXXGnQvUCnfp/nrEzuSAkNrhPeS9SegdTKGJ/ocMnoqM3dof8xumuzlj
PCah4yvubq1nszck9zB92spgYWri1E8ir87U1kan2uK29F7vC7/0nobxIcUF1B/K
93h0zZqBQOmyQvFvabLvOS10IIWUEZBCohE9xi45/1moSZhseIX0GvP52rbIEfOJ
zbxWHgG/3n5k6gnCreNYXrlE7h/lnlJYxzfF2NsNftr81DE+QXokTi+Ljnzu0eyO
EJZfiz0mZ/oLdtFA+O/dfh1RvfHfDMz/Oavj+Qmllc/PgprGSe7wwChSJGDZVgIG
xJ9jfEL+ERdt9O+iqubnDIUiB8Y7gJv+ea8lsWTzScT4Gw2hNxf06KYQXAlAntZV
OYATYaD77EyMTQ3qeVpJb6SGqrHTxIgHYm5MzSptWdR3n0EyIN1OaE5A+K2KZ+K3
7Of8KsfDByIGror9LX0KBHJQvRg6xoYVXbK0MGJ6ZQRdmpKQ6OR9Sz4WA0J1M7Mc
H7nnlV2fYJr0ikrIznzLi2NFn5lXEZgtEkVXZlJqy1Q1vXGMw0ZaY5fNtlg8u8+A
T8UjJx7hHVtS0NE=
=PXDY
-----END PGP SIGNATURE-----

A
A
Andrew Tropin wrote on 28 Sep 2021 11:35
87a6jxghzq.fsf@trop.in
On 2021-09-28 00:15, Oleg Pykhalov wrote:

Toggle quote (21 lines)
> Hi Guix,
>
> We have unbound variables in some Guix Home files:
> --8<---------------cut here---------------start------------->8---
> gnu/home-services/configuration.scm:56:6: warning: possibly unbound variable `formatted-message'
> gnu/home-services/configuration.scm:57:7: warning: possibly unbound variable `G_'
> gnu/home-services/xdg.scm:309:43: warning: possibly unbound variable `maybe-list'
> gnu/home-services/xdg.scm:330:13: warning: possibly unbound variable `list->human-readable-list'
> guix/scripts/home/import.scm:210:18: warning: possibly unbound variable `package-version'
> guix/scripts/home/import.scm:210:35: warning: possibly unbound variable `find-packages-by-name'
> guix/scripts/home/import.scm:222:23: warning: possibly unbound variable `cut'
> guix/scripts/home/import.scm:222:27: warning: possibly unbound variable `version>?'
> guix/scripts/home/import.scm:222:45: warning: possibly unbound variable `<>'
> guix/scripts/home/import.scm:225:16: warning: possibly unbound variable `version-unique-prefix'
> --8<---------------cut here---------------end--------------->8---
>
> maybe-list and list->human-readable-list come from
> gnu/home-services-utils.scm in rde project.
>
> Oleg.

My bad) Here it is:
Attachment: 0001-home-services-Add-missing-imports-and-function-defin.patch
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmFS4ekACgkQIgjSCVjB
3rBXAA/8Cv+g8uxRqGDGX5JkGxb06l0d8edrlETzUGHTwzyIeWDL2Lpw7oLV9CFD
P361VQt7+oc/WQe/8lx/6xtj3NwxR7UzMOr2NEczr+Xtwjyzymo/NKCB63mBbDqF
H4oaOgNT0woTxcAZnClvY/QgzsQUIBNto3x17m78g8SXn4TUQ6Kv9sdXfStyGVwR
WFI10Qe6i0YVgvAchm3HbjM9hBgzC35owCTKt7+bxssHbdrFIZubMssMY/GNMPAm
GCa1BulUHLLUg4/2aepqUbXZqFUqF3jAgJn2vIVPmAAtJa+pM7lVe0x4ctp/Dj/E
Vjon8GEhFdgQIhGZMe2kFK96nZm5eNp71ftgiSENwvb13s0pCT26H0PEYalFonSM
bw8FUVeH/AwVj3Mkw/tMQga4pQDpluC6ShOwMRL/W+0DTmSJeYikpdYmD6IQk/8G
RzvLDisLKFNrHfBesvlk0YVTBzIxh5fw9zlOMdUXYUwqbavxfhik1K4PH+qqSsoy
yb525ikvMOFh9kF5J44+2IvdolaeFqCuqFgO9sC8tpRuGgEHh7CpL3Kix1STOpjs
pwXQZIxBsxzWBBLmhpuaXTdjr6OVCp9G3A3DE6ZSIIvWnQ9+lRJrepzId0ES8XgF
mpHtkB1v2iqhdO+9Fkj71ZIeH8+8rqn/71rcCxAuv8yzGrY5l4s=
=6XzT
-----END PGP SIGNATURE-----

O
O
Oleg Pykhalov wrote on 28 Sep 2021 13:06
(address . 50856-done@debbugs.gnu.org)(name . Andrew Tropin)(address . andrew@trop.in)
87zgrx7ydj.fsf@gmail.com
Andrew Tropin <andrew@trop.in> writes:

[…]

Toggle quote (17 lines)
> From 634e6cbb7153ea02fb2ace6d39dae4055ed0c73c Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew@trop.in>
> Date: Tue, 28 Sep 2021 12:30:55 +0300
> Subject: [PATCH] home-services: Add missing imports and function definition.
>
> * gnu/home-services/configuration.scm: Add missing imports.
> * gnu/home-services/utils.scm (list->human-readable-list): Add new function.
> * gnu/home-services/configuration.scm: Add missing imports.
> * gnu/home-services/xdg.scm: Fix ensure-list function.
> * guix/scripts/home/import.scm: Add missing imports.
> ---
> gnu/home-services/configuration.scm | 2 ++
> gnu/home-services/utils.scm | 30 ++++++++++++++++++++++++++++-
> gnu/home-services/xdg.scm | 12 +++++++-----
> guix/scripts/home/import.scm | 4 ++++
> 4 files changed, 42 insertions(+), 6 deletions(-)

Applied, thank you!

Oleg.
-----BEGIN PGP SIGNATURE-----

iQJIBAEBCgAyFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAmFS9zgUHGdvLndpZ3Vz
dEBnbWFpbC5jb20ACgkQFn+OpQAa+pxevg/8DBAUJF/LIctXiH6J0XRQoJeZJVqZ
GWyocy3umK3NbOMXIi33XBATV6wRT+aoWdZO2wGrfbNAA8aJKE+IxeKw/Igp/1+k
gMllZdJTun3rCtdVW8FqDckLnKyt9OfnH1N08FAk+MH9pLdwNieik5cv9Ly1dBkC
WjbRhogy8wrpetI5TmfRJlZPbJw72cEQD78OQ7nAEUwpTLTvoPI7Q8wXXlrz2ViV
7fQGEaDx3dfIAEhcuWdB+LNhVFst2kZX6W7bDnRJ9U9fjgC6gJQNLmY4O5axK1Pp
aZxRTHskxNsaj41llBzd9OvZP4v8PKpUsTMoo7N6GhzLGLlFtdTzHH0/yqy2lL0q
6MgIeAMrp63nODbrbgaDcXpx6QnxV+iFlVrD5YPvj4fb5oMz8HKS7PYRQxMkXyPN
4TwiztYswfC+cVjYyT+PDpxEbRAl0nf7xFRNjSTO4oH6VFjk3npIJ4eCepihSEKe
Tept66muOSyGoTSfVcHZYtr7ELUmfy1FspVAyJ/O0zLy9nem8IM4iXSbzO/2GEh7
UweWXh1oyoxduoHEmkKNIvDAHrSALVTJEY9va5JjNwY3kZqska//wsL+3GOuLSNS
rKC0TBBetfZrVpQ7oMrdkH31I+482MKKRJYfNDrGjDRs3kVTBhTYoDvPZ+6QGkzw
lHpVhoxao3sp7xQ=
=t/+I
-----END PGP SIGNATURE-----

Closed
?