From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 18 05:10:53 2021 Received: (at 50814) by debbugs.gnu.org; 18 Oct 2021 09:10:53 +0000 Received: from localhost ([127.0.0.1]:46006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcOfU-0004QQ-UB for submit@debbugs.gnu.org; Mon, 18 Oct 2021 05:10:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcOfS-0004QB-AX for 50814@debbugs.gnu.org; Mon, 18 Oct 2021 05:10:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60634) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcOfM-0002cb-Ox; Mon, 18 Oct 2021 05:10:44 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=50988 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcOfJ-0008RK-NG; Mon, 18 Oct 2021 05:10:44 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Attila Lendvai Subject: Re: bug#50814: [PATCH] guix: git-authenticate: Also authenticate the channel intro commit. References: <20210926101928.3877-1-attila@lendvai.name> <878rz2xq23.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 27 =?utf-8?Q?Vend=C3=A9miaire?= an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 18 Oct 2021 11:10:39 +0200 In-Reply-To: (Attila Lendvai's message of "Sun, 17 Oct 2021 10:09:24 +0000") Message-ID: <878ryqbsvk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50814 Cc: 50814@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Attila, Attila Lendvai skribis: >> i'll investigate again later by running the test without the fix, and wr= ite >> up my results here, or better yet, in a better commit message. > > i ran the test without my fix, and indeed it fails at two points: Sorry, which test is failing? Is that part of the patches you sent? I need more context. :-) [...] >> Alright. Please next time open one issue per topic: that=E2=80=99s a go= od >> way to maximize the chances that review happens in a timely fashion. >> :-) > > > can i mark dependencies between issues/patchsets? > > because all that i could do here is split this into two sets of > commits (because of the dependencies between the commits): > > 1) the 3 test commits, and > 2) the 2 guix commits. > > i thought that separating the test that is exhibiting the bug, from > the fix that fixes it, would only hinder the process. Yes, in general it=E2=80=99s best to have the test and the fix in the same commit. However, at this point, I=E2=80=99m not sure which =E2=80=9Cbug=E2=80=9D we= =E2=80=99re talking about. What you described in your initial message is not a bug in my view: https://issues.guix.gnu.org/50814#28 >> I understand the behavior was surprising to you, but I=E2=80=99d like to= see >> if we can pinpoint why. Can you think of anything that could be >> added to the documentation? > > > if we assume that everyone reads and internalizes every page of the > documentation of every software that they use, then i guess nothing > needs to be added. > > but if our goal is to maximize the effectiveness of the users, then no > amount of static, free-flowing text can compete with a warning that is > signalled in close context to the issue. Sure, I agree. However, you=E2=80=99re clearly a power user at this point :-), and we=E2= =80=99re talking about one of the most sensitive pieces of code in Guix. I think it=E2=80=99s important to make sure we=E2=80=99re on the same level of unde= rstanding of the design and current implementation; I also think it=E2=80=99s not unreasonable to expect channel writers to pay attention to documentation on these matters. I=E2=80=99m not saying that we should not change anything, but rather that = it=E2=80=99s not like a simple usability/UX issue. I hope this makes sense! Ludo=E2=80=99.