From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 16 09:45:18 2021 Received: (at submit) by debbugs.gnu.org; 16 Sep 2021 13:45:18 +0000 Received: from localhost ([127.0.0.1]:54160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQrhU-0002as-0C for submit@debbugs.gnu.org; Thu, 16 Sep 2021 09:45:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:36500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQrhG-0002Ma-5N for submit@debbugs.gnu.org; Thu, 16 Sep 2021 09:45:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQrhF-0008DN-Ll for guix-patches@gnu.org; Thu, 16 Sep 2021 09:45:01 -0400 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]:34458) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQrhE-0001ct-1M for guix-patches@gnu.org; Thu, 16 Sep 2021 09:45:01 -0400 Received: by mail-qt1-x82b.google.com with SMTP id 2so5548796qtw.1 for ; Thu, 16 Sep 2021 06:44:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rekahsoft.ca; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=vDkldQMNLuxGQxPRYHICpDZ57+w//DK3xpaBqoOMSQQ=; b=yWkAPqcUcqiHA3Am7vVyFpTE0B0fxL16kQ2V1xUg6uLfh/Sypci7JUqSrdIYuuurdL Ifk2ErPifSFtKZh75TysU6ksRqvE2DYolu3MU/ZFlJ9AST1ixGInilR6Bv2+VKeX00MU M451xpkC+nbTky7UnIGth8CGFb0wzyAQsXQKdc432MQ6Tb47PHKce7da+cxIyD6MrrJX 9AvtU6jwrGWxEvmnK80NsWb6JYiojvhqYkdHQF4lkHfko6196pfpqTINQN0FIthRlVCA 8uAQepjiTwsfvqzEc6iSSJlvqKpIxo6cPMg0oWwPxCTwzxhSwojjvKWlqvwC2QNfivO6 HS0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=vDkldQMNLuxGQxPRYHICpDZ57+w//DK3xpaBqoOMSQQ=; b=oCgfEAn0ER0NEW/4ib8YTVd1e+daCwaQOh6+POoSt+6nzjNn/3gs8Qsq3cyhOEu3zl 1J7zZdJgVQk/cjx54tYSY1jZXNigVg+zhQiehQQRXsQQP/4TSISbxwzUM7XEuFuWrtSC rBrPlFFqVEY3/b6NsXMlLnQrxljbkWvku2irHUdgCacFrR3t/MCjTMHYBXZd7hEHEiR2 VOeQZGYNBo+usz+A+yoixAg/gtZPVMGoyPnrP951FqBdG2gCjoRe8npcrCcyzbEC45l6 iCSfW4m1dNKUXni6j7Rctw84KzD221hoFL+gT0ds3eEL6TS7alV7fEkR9vORHgmeNZ6A OPvg== X-Gm-Message-State: AOAM530lOwusBVqWCWTdVcQ8e9puskPATeZkBtZMz3nRSMsR/OAUL3Jn DiJkHU2tCEZdgooYfJprDQdqNwtFKbpH8w== X-Google-Smtp-Source: ABdhPJwsJkTdbNVg4znGtSIDhSKfMZQTOWH911ow80r2Hxc9LZaiiZo9wwUjXmgytoLfujfHlJl9HQ== X-Received: by 2002:ac8:7003:: with SMTP id x3mr5224760qtm.284.1631799898086; Thu, 16 Sep 2021 06:44:58 -0700 (PDT) Received: from rekahsoft-work (cpe0008a20f982f-cm64777d666260.cpe.net.cable.rogers.com. [99.255.210.233]) by smtp.gmail.com with ESMTPSA id l7sm2363151qki.99.2021.09.16.06.44.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Sep 2021 06:44:57 -0700 (PDT) References: <8735qk9v2x.fsf@rekahsoft.ca> <875yv5sr0z.fsf@unanue.mx> User-agent: mu4e 1.6.5; emacs 27.2 From: "Collin J. Doering" To: Adolfo De =?utf-8?Q?Un=C3=A1nue?= Subject: Re: [bug#50374] (no subject) Date: Thu, 16 Sep 2021 09:38:31 -0400 In-reply-to: <875yv5sr0z.fsf@unanue.mx> Message-ID: <871r5ohbxj.fsf@rekahsoft.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::82b; envelope-from=collin@rekahsoft.ca; helo=mail-qt1-x82b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Adolfo, I am not a guix expert either and am relatively new to the project. I actually asked about this topic on guix IRC, where folks there suggested splitting it into another package. I see very little diff [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.0 SLIGHTLY_BAD_SUBJECT Subject contains something slightly spammy 0.0 T_SPF_TEMPERROR SPF: test of record failed (temperror) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record X-Debbugs-Envelope-To: submit Cc: 50374@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Hi Adolfo, I am not a guix expert either and am relatively new to the project. I actually asked about this topic on guix IRC, where folks there suggested splitting it into another package. I see very little difference between including the org-roam-extensions as a separate package output, or as a standalone package. I feel that having it as an additional output is more "pure", but found that many packages already use a standalone package for extensions, and I found that doing it in this way made both packages themselves easier to define. You can see this for yourself with a query like this `guix package -s '.*-extensions$' | recsel -CP name`. Hope this helps, and kind regards! On 12 Sep 2021 at 11:19, Adolfo De Un=C3=A1nue wrote: > Hi > > I am the author of the patch https://issues.guix.gnu.org/50333 (my first > patch, so I am a newbie on this). > > Could you help me to understand why your proposal is a better solution? > I want to learn how to approach to this matters in the future. > > My rationale is that the extensions folder *is* part of org-roam, that's > why I *added* them to the original package. > > Also, Do we need to do something in order to get this patch (or mine) > approved? > (again, just asking because this workflow is new for me) > > Thanks in advance for your time --=20 Collin J. Doering http://rekahsoft.ca http://blog.rekahsoft.ca http://git.rekahsoft.ca