From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 28 06:34:59 2021 Received: (at 50077) by debbugs.gnu.org; 28 Aug 2021 10:34:59 +0000 Received: from localhost ([127.0.0.1]:53452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJvfr-0002qc-6R for submit@debbugs.gnu.org; Sat, 28 Aug 2021 06:34:59 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:44582 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJvfk-0002qI-Tp for 50077@debbugs.gnu.org; Sat, 28 Aug 2021 06:34:53 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1630146878; bh=InNYTCiS7BH/2UNCbDq4yHrqFvBU+9qpga/u1aNA0nw=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=hRo2DtDGN868yhAS5eWU3Z1Ew+IkwKEjbRVDsZw7cr4RVHfC+9vzmtzIug6Xhi1T/ oWXUVfu03WjGi/mma8Q61LbCjkYkhTbs+F93DYnFa2lcyMyoq+rL+Oh9Wt7qgn7BbW nn+T91FgNh2I+FRMneqlCbEqa320PqNvSjcI0g54= To: Andrew Tropin Subject: Re: [PATCH 1/3] gnu: notmuch: Add separate 'emacs' output. In-Reply-To: <87o89owoi0.fsf@trop.in> References: <87o89owoi0.fsf@trop.in> Date: Sat, 28 Aug 2021 12:34:16 +0200 Message-ID: <87r1edvown.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: [ Debbugs wasn’t Cc’d in the previous message ] On Mon, Aug 23 2021, Andrew Tropin wrote: > On 2021-08-16 16:12, Xinglu Chen wrote: > >> * gnu/packages/mail.scm (notmuch)[outputs]: Add ‘emacs’ output >> [arguments]<#:modules>: Add (guix build emacs-utils). >> <#:phases>{configure}: Use [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps X-Debbugs-Envelope-To: 50077 Cc: 50077@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: [ Debbugs wasn’t Cc’d in the previous message ] On Mon, Aug 23 2021, Andrew Tropin wrote: > On 2021-08-16 16:12, Xinglu Chen wrote: > >> * gnu/packages/mail.scm (notmuch)[outputs]: Add ‘emacs’ output >> [arguments]<#:modules>: Add (guix build emacs-utils). >> <#:phases>{configure}: Use [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [ Debbugs wasn=E2=80=99t Cc=E2=80=99d in the previous message ] On Mon, Aug 23 2021, Andrew Tropin wrote: > On 2021-08-16 16:12, Xinglu Chen wrote: > >> * gnu/packages/mail.scm (notmuch)[outputs]: Add =E2=80=98emacs=E2=80=99 = output >> [arguments]<#:modules>: Add (guix build emacs-utils). >> <#:phases>{configure}: Use the =E2=80=98emacs=E2=80=99 output. >> {make-autoloads}: Modify the default =E2=80=98make-autoloads=E2=80=99 ph= ase to use the =E2=80=98emacs=E2=80=99 >> output. >> --- >> gnu/packages/mail.scm | 16 +++++++++++++--- >> 1 file changed, 13 insertions(+), 3 deletions(-) >> >> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm >> index ccf44b7cf3..bbc616f6f5 100644 >> --- a/gnu/packages/mail.scm >> +++ b/gnu/packages/mail.scm >> @@ -1337,7 +1337,8 @@ invoking @command{notifymuch} from the post-new ho= ok.") >> (arguments >> `(#:modules ((guix build gnu-build-system) >> ((guix build emacs-build-system) #:prefix emacs:) >> - (guix build utils)) >> + (guix build utils) >> + (guix build emacs-utils)) >> #:imported-modules (,@%gnu-build-system-modules >> (guix build emacs-build-system) >> (guix build emacs-utils)) >> @@ -1355,7 +1356,8 @@ invoking @command{notifymuch} from the post-new ho= ok.") >> (setenv "CONFIG_SHELL" (which "sh")) >>=20=20 >> (let* ((out (assoc-ref outputs "out")) >> - (elisp (emacs:elpa-directory out))) >> + (emacs (assoc-ref outputs "emacs")) >> + (elisp (emacs:elpa-directory emacs))) >> (invoke "./configure" >> (string-append "--prefix=3D" out) >> (string-append "--emacslispdir=3D" elis= p) >> @@ -1373,7 +1375,14 @@ invoking @command{notifymuch} from the post-new h= ook.") >> (substitute* (find-files "test" "\\.sh$") >> (("/bin/sh") (which "sh"))))) >> (add-after 'install 'make-autoloads >> - (assoc-ref emacs:%standard-phases 'make-autoloads))= ))) >> + (lambda* (#:key outputs inputs #:allow-other-keys) >> + (let* ((emacs (string-append (assoc-ref inputs "e= macs") "/bin/emacs")) >> + (out (assoc-ref outputs "emacs")) >> + (elpa-name-ver ((@@ (guix build emacs-buil= d-system) >> + store-directory->elpa-= name-version) out)) >> + (elpa-name (package-name->name+version elp= a-name-ver)) >> + (el-dir (emacs:elpa-directory out))) >> + (emacs-generate-autoloads elpa-name el-dir)))))= )) >> (native-inputs >> `(("bash-completion" ,bash-completion) >> ("emacs" ,emacs-no-x) ; -minimal lacks libxml, needed for som= e tests >> @@ -1394,6 +1403,7 @@ invoking @command{notifymuch} from the post-new ho= ok.") >> ("talloc" ,talloc) >> ("xapian" ,xapian) >> ("zlib" ,zlib))) >> + (outputs '("out" "emacs")) >> (home-page "https://notmuchmail.org/") >> (synopsis "Thread-based email index, search, and tagging") >> (description > > The separate output is ok, but I think making a separate emacs-notmuch > package looks more consistent. We can inherit it from notmuch package > to be sure that the packages are built from the same source code. Why would it be more consistent to make a separate package? Making a separate package is usually used for packaging a slightly different version of the =E2=80=9Cregular=E2=80=9D package, e.g., =E2=80=98emacs-next= -pgtk=E2=80=99 adds native compilation and pure GTK support for Emacs., =E2=80=98emacs-no-x=E2=80=99 r= emoves X suport for =E2=80=98emacs=E2=80=99. =E2=80=98emacs-notmuch=E2=80=99 isn=E2= =80=99t really a different version of =E2=80=98notmuch=E2=80=99, it=E2=80=99s just =E2=80=98notmuch=E2=80=99 but = with all the non-Elisp stuff removed. This is usually what using different outputs tries to achieve, e.g., separate documentation from the main package, or in this case, separate Elisp stuff from the main package. The =E2=80=98notmuch=E2=80=99 package in Nixpkgs also uses multiple outputs= [1], which I think makes sense. > > Thank you for working on this, the changes are good and useful!) You are welcome! :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmEqESgVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5kZcP/RTgDyBP+weLceLnv5Xo6z4wvR1y mpqjSSoz7xEKazB7JGNkjKx+1Xcz15AcC1VOAyGUPJdBUGTbHtp1jSIMcmwCY5Xb dNUlv+aGXZzQdKzMw2lTRxe4JPKq6fbIZN9aIhezCAX8oojDI8LIuRK4H6onZzkt NijrdN09oYkfEsHTDXdoDu/EZNV25MH3MAW4lVQKnpwZIDqj6m3A46Z/2jvMFeoH HaXQUD6ZJc4zN1n1tklds09hYyHeR+0ijBG33HmZ8KQloaOx+9J2k9AO326i3R2Y Evjqt1DL3RoaCMqwSXIsxKBZmJj84YJZm2MxmZz8wGWdxf5AzpFzdmWl4svaPS2T nCRrjf3M0PvW+eNUagLAnF186p3alC9incQqq/o9aOeri7YggHkoxQL/drHFlEik 93589LuGBa+cyaXIjV4t9hD7O47/sZyudT5kwIsDnyo+QZMTeMH/Mo9fPN7YhORm 0Am3niBcEMc0lZ6zNWQyupU4UdtLrgOcltJYYOH29wA5DrSb5WlM9rQZTu6O4PkD HLlsa75O4e9OiENSllJClA/lM3dSmPp+VCWH08I5i1yduDaJ28EbF45Dwxh1Bgxx P4LgB6XhBdGcsi2AFnF+worHqIv9qshfwBzLU10Qcxy3rvFTC+HDZ41JZtIlYPhK 2EdnAyHscS2FFONS =kd3P -----END PGP SIGNATURE----- --=-=-=--