From debbugs-submit-bounces@debbugs.gnu.org Fri May 21 09:37:20 2021 Received: (at 47979) by debbugs.gnu.org; 21 May 2021 13:37:20 +0000 Received: from localhost ([127.0.0.1]:36070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk5L5-0001t0-FI for submit@debbugs.gnu.org; Fri, 21 May 2021 09:37:19 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:56413) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk5L3-0001so-Vv for 47979@debbugs.gnu.org; Fri, 21 May 2021 09:37:18 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B41415C00D7; Fri, 21 May 2021 09:37:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 21 May 2021 09:37:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=/BBDIU1GogR5BIWL8KYGK5Ks arMizOQq4sjoQX99CT4=; b=AJcGdRuIiUHafuVR2lhPuiY2dz0WmswH/ua7e3lk rqYOC0C46BCBU/2JAWv4E5aCTFXMoVbobOHlVIZ7zco/QbkEQIdWyMVA8skl0AeU wIlT8IX2quoKhfjHlrMv3PZ9E58IGIVADJ8lLA3w3cB0gQqowtsKyDS9Ci4mrGyK kj0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/BBDIU 1GogR5BIWL8KYGK5KsarMizOQq4sjoQX99CT4=; b=GQgLRi4kYn7lTY3QsmZlmw YvO4c6rrL03csXMTo4yvKyUgdqp1RUzlGFL4JCHZjcnj7OkNY90gL6/icnf7ZWpg TU1yn7tzNDw4S4697lxtKycJhoPVhWGg+OO4Lrp/ozQGyzPvmwGrtwNzCYxIvnDR xSnFBvc3cc28W+UjU9MQYQiL1ys0r0dM6C66ZRhr/bPgK49y4qEGrzetHL9Fd5yV CU7f9xd2ZmMuvjqQsoBJsYP8cpNPnAAd1IzWxcKioOYC2fRrAkEmDNLC5TB/4le4 cwyhN6DvYMRIThHp5LZjDhDid3fVhqmnalC4NGz3ATTsVTJ58MIJX18RcmtqUpAQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejfedgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev gfenucfkphepuddttddruddurdduieelrdduudeknecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 21 May 2021 09:37:12 -0400 (EDT) Date: Fri, 21 May 2021 09:37:10 -0400 From: Leo Famulari To: Mathieu Othacehe Subject: Re: bug#47979: [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems. Message-ID: References: <87lf88qm47.fsf_-_@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lf88qm47.fsf_-_@gnu.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47979 Cc: 47979@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Thanks for the review. On Fri, May 21, 2021 at 02:58:48PM +0200, Mathieu Othacehe wrote: > > +(define (run-system-administration-cbt-page) > > + "Run a page to select various system adminstration services." > > + (let ((items (filter (lambda (service) > > + (eq? 'administration > > + (system-service-type service))) > > + %system-services))) > > + (run-checkbox-tree-page > > + #:title (G_ "Miscellaneous services") > > + #:info-text (G_ "Select miscellaneous services to run on your system.") > > + #:items items > > + #:selection (map system-service-recommended? items) > > + #:item->text (compose G_ system-service-name) > > + #:checkbox-tree-height 5 > > + #:exit-button-callback-procedure > > + (lambda () > > + (raise > > + (condition > > + (&installer-step-abort))))))) > > Indentation is off here, > > > + ;; Miscellaneous system administration services. > > + (system-service > > + (name (G_ "Network time service, to set the clock automatically")) > > + (type 'administration) > > + (recommended? #t) > > + (snippet '((service ntp-service-type)))) > > + > > here, > > > + (system-service > > + (name (G_ "GPM mouse daemon, to use the mouse in the console")) > > + (type 'administration) > > + (snippet '((service gpm-service-type)))) > > and here. I don't see the problems. I copied from existing pieces of similar code and I don't really have a sense of what's right and wrong for indenting this kind of thing. > Those patches are breaking the installer tests because they > introduce a new dialog. You need to add something like: > > --8<---------------cut here---------------start------------->8--- > ((checkbox-list (title "Miscellaneous services") (text _) > (items ,services)) > (filter choose-misc-service? services)) > --8<---------------cut here---------------end--------------->8--- > > in the (gnu installer tests) module, to fix this error: Okay, I'll work on that.