From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 22 14:28:44 2021 Received: (at 46699) by debbugs.gnu.org; 22 Feb 2021 19:28:45 +0000 Received: from localhost ([127.0.0.1]:57582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEGsu-0006Is-Mj for submit@debbugs.gnu.org; Mon, 22 Feb 2021 14:28:44 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:16194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEGss-0006Ih-Lx for 46699@debbugs.gnu.org; Mon, 22 Feb 2021 14:28:43 -0500 Received: from nijino.local (217-149-164-20.nat.highway.telekom.at [217.149.164.20]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4Dksft3jvxz3wNk; Mon, 22 Feb 2021 20:28:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1614022119; bh=T0iXqYkGTqoZ2YIBnJBPBKUNOWh7OP6Frk5dIIwFnks=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=aOk3eWzLfISC16ymGIv4r/J3IsyY7t7a4+RyWiQzVo3y5Yr0HW49UoWSP3ZnJMRjl rlF4SbS8Q3tx5lYrYWA1JcoESktVntSbmBu5ZlxyYRfempo5/Bk0dlvgyuR26Q+4bx E7cT6bzptiAjYHFTCt8nxGd6QUCkrdOJRpUGgteU= Message-ID: <78b3b851db5f4b2057ef8216697138744822fb2b.camel@student.tugraz.at> Subject: Re: [PATCH] gnu: mumble: Update to 1.3.4. From: Leo Prikler To: jgart , 46699@debbugs.gnu.org Date: Mon, 22 Feb 2021 20:28:37 +0100 In-Reply-To: <2cc84bcd0e2e150ceab659ad818bbb57@dismail.de> References: <88fad40b7a501a43517bce0d85509fb271a2026f.camel@student.tugraz.at> <039c316d735faa0a21cdacd1a28296cf@dismail.de> <2cc84bcd0e2e150ceab659ad818bbb57@dismail.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46699 Cc: rg@raghavgururajan.name, LibreMiami X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi jgart, Am Montag, den 22.02.2021, 19:09 +0000 schrieb jgart: > Hi Leo, > > > IIRC, the correct tag would be Co-authored-by. > > I attached the updated patch with your suggestions. > > > These lines appear to be noise, some of them definitely are. > > Raghav thinks these might have been introduced by indent.el > > How would you suggest to remove them? You can select the lines you actually wish to commit through `git commit -p` or use any other tool to do the trick (e.g. Magit or gitg). indent.el is a bit of a hammer. If you don't actively edit code, that has wrong indentation, it's wiser to just indent your portions with Emacs. > > Are perl and ruby really required? If so, what for? > > They are for the 'patch-shebangs phase. And why do you care about those shebangs? Are any of those programs patched by that phase run at any point during build? Regards, Leo