From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 10 09:27:31 2021 Received: (at 45692) by debbugs.gnu.org; 10 Feb 2021 14:27:31 +0000 Received: from localhost ([127.0.0.1]:55816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9qSi-0003Tm-LV for submit@debbugs.gnu.org; Wed, 10 Feb 2021 09:27:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9qSg-0003TV-Ln for 45692@debbugs.gnu.org; Wed, 10 Feb 2021 09:27:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44294) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9qSa-0008I9-Px; Wed, 10 Feb 2021 09:27:16 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43094 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l9qSU-0008I0-9a; Wed, 10 Feb 2021 09:27:11 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: raid5atemyhomework Subject: Re: bug#45692: [PATCH 0/4] Even Better ZFS Support on Guix References: <6wemXB-PfHUqbuVr5-XRf0-tY4cKGGtKiUqrZPrIZYXoBw17L3xRuZrGOJQfTo5PKfFNCM8KyRTllidoc7asPE2x98BTiJSPVR7OSjxCuw8=@protonmail.com> Date: Wed, 10 Feb 2021 15:27:08 +0100 In-Reply-To: (raid5atemyhomework@protonmail.com's message of "Fri, 08 Jan 2021 15:02:21 +0000") Message-ID: <87eeho6ls3.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45692 Cc: "45692@debbugs.gnu.org" <45692@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) raid5atemyhomework skribis: >>From d0e095136cd471f083d92416f12ca22b47301f31 Mon Sep 17 00:00:00 2001 > From: raid5atemyhomework > Date: Wed, 6 Jan 2021 09:24:20 +0800 > Subject: [PATCH 4/4] gnu: Add service to install ZFS. > > * gnu/services/file-systems.scm: New file. > (zfs-service-type): New variable. > (): New type. > (%zfs-zvol-dependency): New variable. > * gnu/local.mk: Add gnu/services/file-systems.scm. > * gnu/services/base.scm (dependency->shepherd-service-name): Export. > * doc/guix.texi (ZFS file system): New subsection. A bit of nitpicking on the documentation bits=E2=80=A6 > +@node ZFS file system > +@subsection ZFS file system Please follow the same typographical conventions as in the rest of the manual. In particular, capitalize section titles and leave two spaces after end-of-sentence periods. Here I recommend s/ZFS file system/ZFS/ in all the text. > +The ZFS file system has a license incompatible with the Linux kernel, > +and thus cannot be distributed with the kernel. However, as a user > +you have the right to do whatever you want on your own hardware, > +including download the ZFS source code, compile it, link it to your > +own private copy of Linux, and run it. You can even use the Guix build > +system to automate this. How about: ZFS is free software; unfortunately its license is incompatible with the GNU General Public License (GPL), the license of the Linux kernel, which means they cannot be distributed together. However, as a user, you can choose to build ZFS and use it together with Linux; you can even rely on Guix to automate this task. See @uref{https://www.fsf.org/licensing/zfs-and-linux, this analysis by the Free Software Foundation} for more information. ? > +As a large and complex kernel module, ZFS on Linux has to be compiled ^ I think it=E2=80=99s a proper noun and is spelled =E2=80=9CZFS-on-Linux=E2= =80=9D. > +with a specific version of the kernel. Often even the latest ZFS > +package available cannot be compiled with the latest Linux kernel ^ s/Linux/Linux-libre/ Thanks, Ludo=E2=80=99.