From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 08:18:06 2020 Received: (at 44768) by debbugs.gnu.org; 25 Nov 2020 13:18:06 +0000 Received: from localhost ([127.0.0.1]:34694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khugQ-0003nU-Aq for submit@debbugs.gnu.org; Wed, 25 Nov 2020 08:18:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khugO-0003mw-HR for 44768@debbugs.gnu.org; Wed, 25 Nov 2020 08:18:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43917) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khugF-00062q-An; Wed, 25 Nov 2020 08:17:56 -0500 Received: from [2a01:e0a:19b:d9a0:1c2b:7570:3d66:bb06] (port=54342 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1khugE-0006Xe-S6; Wed, 25 Nov 2020 08:17:55 -0500 From: Mathieu Othacehe To: Vinicius Monego Subject: Re: [bug#44768] [PATCH v2] gnu: Add gnash. References: <20201120200551.19145-1-monego@posteo.net> <20201124230446.20948-1-monego@posteo.net> Date: Wed, 25 Nov 2020 14:17:53 +0100 In-Reply-To: <20201124230446.20948-1-monego@posteo.net> (Vinicius Monego's message of "Tue, 24 Nov 2020 20:04:46 -0300") Message-ID: <87y2iplgn2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44768 Cc: 44768@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Vinicius, > +of v8 and v9. It is possible to configure Gnash to use several differemt Small typo here: "different". > + // Clean up allocated data. > +-#if GIFLIB_MAJOR==5 && GIFLIB_MINOR==1 > ++#if GIFLIB_MAJOR==5 && GIFLIB_MINOR!=0 It would be nice to add a small comment with the patch to explain what it does and who is the author. Could you also rebase your "lightspark" patch on top of the gnash v2? Thanks, Mathieu