From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 24 06:46:59 2021 Received: (at 44492) by debbugs.gnu.org; 24 Feb 2021 11:46:59 +0000 Received: from localhost ([127.0.0.1]:33754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEsd8-0005hA-QX for submit@debbugs.gnu.org; Wed, 24 Feb 2021 06:46:59 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:42297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEsd6-0005go-EQ for 44492@debbugs.gnu.org; Wed, 24 Feb 2021 06:46:57 -0500 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 75A9F240008; Wed, 24 Feb 2021 11:46:49 +0000 (UTC) From: Nicolas Goaziou To: Leo Prikler Subject: Re: [bug#44492] [PATCH 01/52] gnu: Add rust-ruma-identifiers-validation-0.1. References: <87tuu2p37n.fsf@cbaines.net> <20210224111135.28883-1-leo.prikler@student.tugraz.at> Date: Wed, 24 Feb 2021 12:46:47 +0100 In-Reply-To: <20210224111135.28883-1-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Wed, 24 Feb 2021 12:10:44 +0100") Message-ID: <87sg5lhemw.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44492 Cc: 44492@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Leo Prikler writes: > * gnu/packages/crates-io.scm (rust-ruma-identifiers-validation-0.1): New > variable. Thank you! I have a few general comments about the patch set. Nitpicks: some synopses end with a full stop, and most descriptions are not full sentences. If you introduce a new version of an existing package, the old package should inherit from the new one. More generally, I still think intermediate packages should use #:skip-build #t. Building them brings very little information, if any: - A crate failing to build, for various reasons, is still correct as an input to another crate - Even if all intermediate crates have "#:skip-build #t", building the top-level crate locates accurately any missing Cargo input in the dependency graph. Not using #:skip-build, OTOH, costs a lot of resources and time for the CI, for users and developers. Of course, this last remark is not specific to your patch set. I wish we can converge towards common Rust packaging guidelines. Regards, -- Nicolas Goaziou