From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 16:45:27 2020 Received: (at 44353) by debbugs.gnu.org; 15 Nov 2020 21:45:27 +0000 Received: from localhost ([127.0.0.1]:54416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kePpv-0006mF-3m for submit@debbugs.gnu.org; Sun, 15 Nov 2020 16:45:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kePpr-0006m0-QV for 44353@debbugs.gnu.org; Sun, 15 Nov 2020 16:45:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48726) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kePpm-0005Tj-Fn; Sun, 15 Nov 2020 16:45:18 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45300 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kePpl-0007p8-Kt; Sun, 15 Nov 2020 16:45:17 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: [PATCH version-1.2.0 v2] guix: system: Add a new '--non-volatile' option for disk-image. References: <87h7q0cdns.fsf@gnu.org> <20201112070917.11794-1-maxim.cournoyer@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 25 Brumaire an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 15 Nov 2020 22:45:15 +0100 In-Reply-To: <20201112070917.11794-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Thu, 12 Nov 2020 02:09:17 -0500") Message-ID: <878sb25m6s.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Mathieu Othacehe , Jesse Gibbons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Maxim, Maxim Cournoyer skribis: > * guix/scripts/system.scm (%options)[volatile-root?]: New boolean option. > (%default-options): Set its default value to #f. > (show-help): Add help doc. > * guix/scripts/system.scm (perform-action): Propagate option... > (system-derivation-for-action): ...here. Use it to set the volatile-root? > field of the image object passed to SYSTEM-IMAGE. > * doc/guix.texi (Invoking guix system): Document it. Due notably to the =E2=80=9Cstring freeze=E2=80=9D, I think we shouldn=E2= =80=99t apply it to =E2=80=98version-1.2.0=E2=80=99. Some comments: > +@code{disk-image}. By default, the root file system of a disk image is > +mounted volatile; the @option{--non-volatile} option can be used to make That=E2=80=99s not generally the case, though in (gnu system image), only t= wo image types have it set to false. Before the new image API though, =E2=80=98disk-image=E2=80=99 did not produ= ce a volatile root, IIRC. I=E2=80=99m tempted to think that we should set (volatile-root? #f) on image types where it makes sense, which is maybe all of them except ISO. (Then we need to make sure =E2=80=98guix system vm=E2=80=99 st= ill gets a volatile root.) WDYT, Mathieu? So apart from the sentence above, the patch LGTM for =E2=80=98master=E2=80= =99! Thanks, Ludo=E2=80=99.