From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 19 11:14:58 2020 Received: (at 44032) by debbugs.gnu.org; 19 Oct 2020 15:14:58 +0000 Received: from localhost ([127.0.0.1]:42041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUWsE-0002Mr-0m for submit@debbugs.gnu.org; Mon, 19 Oct 2020 11:14:58 -0400 Received: from lepiller.eu ([89.234.186.109]:47712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUWsB-0002Me-SM for 44032@debbugs.gnu.org; Mon, 19 Oct 2020 11:14:56 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 9351f725; Mon, 19 Oct 2020 15:14:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date :in-reply-to:references:mime-version:content-type :content-transfer-encoding:subject:to:cc:from:message-id; s= dkim; bh=RMZIDBVAV6cfpUU1aS8wvLqtoRz1vp+A8v3B35SWncw=; b=N6mQoAh E3BxNSJSk2Cxrv1hJVobmk2JiCxyN2dfL8jcrLaP+selT65Jm6blRQc/QrPwlHeu vwBY7n6z8+86dQlhuuEx66+ul7oZQqutJ6OPG2O/zDPji6PK1a3BJt6eL64hHmv/ t0TyBZ4uq5hXKtrd42EZ+82GyiXLyDe+ydCvGM+co5f4qoUG+ndFEWIpHwW9+Jhu /cXq5r5ewUx0zVU5HUJx+KtWJCob5EHOYAf53OgUAT4Xzwxa6/44SFpl4PH3v1dE wB7zks1VXRsrncyiHQhdE1bHHvbloQGge2Cr9rmSqqnlB+0/MXmfb21HLS931eKJ tXB5bvBnXCFzXUg== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 3eedd85a (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 19 Oct 2020 15:14:50 +0000 (UTC) Date: Mon, 19 Oct 2020 11:14:32 -0400 User-Agent: K-9 Mail for Android In-Reply-To: References: <20201016171436.5f642654@tachikoma> <87y2k2fikr.fsf@gmail.com> <26294C8B-1271-4ED9-8B1C-9A6DDF7E9AEA@lepiller.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [bug#44032] [PATCH] gnu: ocaml: Update to 4.11.1 To: zimoun From: Julien Lepiller Message-ID: <0736C245-79D4-4A6F-B79E-0D51A45F67DC@lepiller.eu> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 44032 Cc: 44032@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le 19 octobre 2020 10:24:23 GMT-04:00, zimoun a =C3=A9crit : >On Mon, 19 Oct 2020 at 16:11, Julien Lepiller >wrote: > >> >> +(define-public ocaml4=2E09-csexp >> >> + (package >> >> + (inherit ocaml-csexp) >> >> + (name "ocaml4=2E09-csexp") >> >> + (arguments >> >> + `(#:ocaml ,ocaml-4=2E09 >> >> + #:findlib ,ocaml4=2E09-findlib >> >> + ,@(substitute-keyword-arguments (package-arguments >> >ocaml-csexp) >> >> + ((#:dune _) (package-with-ocaml4=2E09 >dune-bootstrap))))) >> >> + (propagated-inputs >> >> + `(("ocaml-result" ,(package-with-ocaml4=2E09 >ocaml-result)))))) >> > >> >You do not use the one you define below=2E Why? Other said, do you >> >really need 'ocaml4=2E09=2Eresult' defined below? >> >> Actually, the properties ensure that I actually use the one below :) > >I am not sure=2E You are recreating a package based on 'ocaml-result' >and not using the package 'ocaml4=2E09-result'=2E Or I miss something >about the symbols=2E package-with-ocaml4=2E09 first reads the properties field of its arguments= , and if it has an ocaml4=2E09-variant,it uses it=2E Otherwise it creates a= new package that uses ocaml 4=2E09, ocaml4=2E09-findlib and ocaml4=2E09-du= ne=2E If you remove the property in ocaml-result, you'll see that building (pack= age-with-ocaml4=2E09 result) ends up in a loop: it wants ocaml4=2E09-dune, = but is itself a dependency of ocaml4=2E09-dune=2E > > >> >> +(define-public ocaml4=2E09-result >> >> + (package >> >> + (inherit ocaml-result) >> >> + (arguments >> >> + `(#:test-target "=2E" >> >> + #:dune ,(package-with-ocaml4=2E09 dune-bootstrap) >> >> + #:ocaml ,ocaml-4=2E09 >> >> + #:findlib ,ocaml4=2E09-findlib)))) >> > >> >Since the name is not changed after inheritance, this package is >> >ambiguous=2E And possibly do not compile=2E >> >> Ah right, thanks! > >Moreover, my point is: you are using > > once: > (properties `((ocaml4=2E09-variant =2E ,(delay ocaml4=2E09-result)))) >and once: > `(("ocaml-result" ,(package-with-ocaml4=2E09 ocaml-result)))))) > >and it seems easier to only use one form=2E Other said, maybe you do >not need the new 'ocaml4=2E09-result' and '(package-with-ocaml4=2E09 >ocaml-result)' is enough=2E OK, I'll use the variant I define everywhere if it makes things easier to = understand later=2E > > >> >> - `(#:phases >> >> + `(#:tests? #f; no tests >> > >> >Why? Because the tests are run during the build? If yes, does it >make >> >sense to move the comment there? >> >> No, the comment might have come from a previous version or just >copied by mistake=2E There is really no test in this package (unless >there's something weird going on with oasis scripts)=2E > >Maybe reword the comment: "no test provided by the package"or >something like that=2E > > >All the best, >simon