From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 14 08:44:50 2020 Received: (at 41785) by debbugs.gnu.org; 14 Jun 2020 12:44:50 +0000 Received: from localhost ([127.0.0.1]:43097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkS0H-00033g-Kz for submit@debbugs.gnu.org; Sun, 14 Jun 2020 08:44:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkS0F-00033S-Sy for 41785@debbugs.gnu.org; Sun, 14 Jun 2020 08:44:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44264) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkS0A-0003bS-1j; Sun, 14 Jun 2020 08:44:42 -0400 Received: from [2a01:e0a:fa:a50:d869:cbcf:2456:40cc] (port=38880 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jkS09-0001BR-Gz; Sun, 14 Jun 2020 08:44:41 -0400 From: Mathieu Othacehe To: Jan Nieuwenhuizen Subject: Re: [bug#41785] [PATCH v4] services: Add 'hurd-in-vm service-type'. References: <20200610085441.890-1-janneke@gnu.org> <87eeql9xvt.fsf@gnu.org> <87wo4d2rm5.fsf@gnu.org> <873670l3z9.fsf@gnu.org> <87eeqknf4d.fsf@gnu.org> <878sgpg856.fsf_-_@gnu.org> Date: Sun, 14 Jun 2020 14:44:38 +0200 In-Reply-To: <878sgpg856.fsf_-_@gnu.org> (Jan Nieuwenhuizen's message of "Sun, 14 Jun 2020 14:10:45 +0200") Message-ID: <87eeqhkea1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41785 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 41785@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey janneke! > (define (hurd-vm-disk-image config) > "Return a disk-image for the Hurd according to CONFIG." > (with-parameters ((%current-target-system "i586-pc-gnu")) > (let ((os (hurd-vm-configuration-os config)) > (disk-size (hurd-vm-configuration-disk-size config))) > (system-image > (image > (inherit hurd-disk-image) > (size disk-size) > (operating-system os)))))) Nice! I'm not sure why we still need the "with-parameters" call because, it's done first thing in "system-image". I'd like to understand this before proceeding, do you have a branch where I could test it? > - ;; FIXME: %current-target-system may not be bound > - (let ((target (%current-target-system))) > + (let-system (system target) > (with-extensions (list shepherd) > (computed-file (string-append (basename (scheme-file-name file) ".scm") > ".go") > > produces a working hurd-vm service! Good catch! Thanks, Mathieu