From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 12 10:43:06 2020 Received: (at 41785) by debbugs.gnu.org; 12 Jun 2020 14:43:06 +0000 Received: from localhost ([127.0.0.1]:40411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjktd-0005DJ-RP for submit@debbugs.gnu.org; Fri, 12 Jun 2020 10:43:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjktc-0005Cp-Hm for 41785@debbugs.gnu.org; Fri, 12 Jun 2020 10:43:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36987) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjktX-0008Mq-60; Fri, 12 Jun 2020 10:42:59 -0400 Received: from [2a01:e0a:fa:a50:94c:bf7f:8c59:d38d] (port=33224 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jjktW-00073N-Mx; Fri, 12 Jun 2020 10:42:58 -0400 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#41785] [PATCH] DRAFT services: Add 'hurd-in-vm service-type'. References: <20200610085441.890-1-janneke@gnu.org> <87eeql9xvt.fsf@gnu.org> Date: Fri, 12 Jun 2020 16:42:55 +0200 In-Reply-To: <87eeql9xvt.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 11 Jun 2020 21:59:50 +0200") Message-ID: <87a718l500.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41785 Cc: 41785@debbugs.gnu.org, "Jan \(janneke\) Nieuwenhuizen" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Ludo & janneke, > Mathieu, can we make =E2=80=98find-image=E2=80=99 non-monadic? It really= shouldn=E2=80=99t be > because it doesn=E2=80=99t interact with the store. It can take an optio= nal > =E2=80=98system=E2=80=99 parameter if we want. Yes, you're right, passing 'target' to 'find-image' should be enough to make it non-monadic. > So, assuming =E2=80=98find-image=E2=80=99 is non-monadic, the code above = becomes > something like: > > (system-image > (image (inherit base-image) > (size image-size) > (operating-system > (with-parameters ((%current-target-system "i586-pc-gnu")) > os)))) I would prefer 'target' to be part of the image itself, as I proposed here: https://lists.gnu.org/archive/html/guix-devel/2020-05/msg00417.html. There's no way for now, that the image is built without cross-compiling for "i586-pc-gnu", so I think it could be part of the "image" record itself. WDYT? >> +(define hurd-in-vm-service-type >> + (service-type >> + (name 'hurd-in-vm) >> + (extensions (list (service-extension shepherd-root-service-type >> + hurd-in-vm-shepherd-service))) >> + (default-value (hurd-in-vm-configuration)) >> + (description >> + "Provide a Virtual Machine running the GNU Hurd."))) > > Being pedantic: s|the GNU Hurd|GNU/Hurd|. :-) > > Otherwise looks great to me, thank you! Looks really nice to me too :) Thanks, Mathieu