From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 02 08:23:03 2020 Received: (at 41643-done) by debbugs.gnu.org; 2 Jun 2020 12:23:03 +0000 Received: from localhost ([127.0.0.1]:38128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jg5wd-0002rv-A4 for submit@debbugs.gnu.org; Tue, 02 Jun 2020 08:23:03 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:45918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jg5wb-0002r3-JI for 41643-done@debbugs.gnu.org; Tue, 02 Jun 2020 08:23:02 -0400 Received: from localhost (80-110-127-207.cgn.dynamic.surfer.at [80.110.127.207]) by dd26836.kasserver.com (Postfix) with ESMTPSA id D477C3364C22; Tue, 2 Jun 2020 14:22:59 +0200 (CEST) Date: Tue, 2 Jun 2020 14:22:59 +0200 From: Danny Milosavljevic To: Mathieu Othacehe Subject: Re: [bug#41643] [PATCH] build-system: linux-module: Allow passing #:make-flags argument. Message-ID: <20200602142259.48258e27@scratchpost.org> In-Reply-To: <87zh9lx2gj.fsf@gnu.org> References: <20200601125910.12840-1-dannym@scratchpost.org> <87zh9lx2gj.fsf@gnu.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/=HK5yFgOO1dmcpzaK.ql=he"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41643-done Cc: 41643-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/=HK5yFgOO1dmcpzaK.ql=he Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable It only works as the last argument on "apply". Using quasiquote for this w= ould be a little over-the-top. Also, almost all the other build system, even the ones using quasiquote, al= so pass them at the end of the argument list. Just scons-build-system doesn't= at one single place of multiple, and meson-build-system doesn't with configure-flags. I'm not opposed to doing it like you suggest, but let's do it for all the build systems in an extra patch. Pushed to guix master as commit f51fd97ec54a98668d63c52d8a6bd75d8dc3292e. --Sig_/=HK5yFgOO1dmcpzaK.ql=he Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl7WRKMACgkQ5xo1VCww uqVYdwf/VPMyeTjEo1u6ReUlDW4HU92wAaHtd3e/TP/KEeraK9pKbq+9KaZt/Emm VD2bEL/HwGyvQtTppBMIo5r8pagztAA48HbaKkkjuTVPE+JKurbO6VvftOM304Pz re4OpgsmJY5/+/E4HAnU6IHwEH0TtIy1m5RwMHD8XdZQ+mhFDemtpLZbCHMaW1wd BrKFn5LzQs3JhmiqYnsjaSot7KSg/kFnx5iMlLkIE8gvZCERkG9SQuXE0ac9boqV Ov1a9oXBaMQI0HunZXpR8ssOhT8D7XaGyV60T4kUX2MRiwq7u8FaRNmTDnE+PGKk VmS8odoLQA8M1WdbGj8iv43Aj+gQ2w== =KKWD -----END PGP SIGNATURE----- --Sig_/=HK5yFgOO1dmcpzaK.ql=he--