From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 08 15:43:32 2020 Received: (at 41552) by debbugs.gnu.org; 8 Jul 2020 19:43:32 +0000 Received: from localhost ([127.0.0.1]:39132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jtFye-0000Qb-DY for submit@debbugs.gnu.org; Wed, 08 Jul 2020 15:43:32 -0400 Received: from mout01.posteo.de ([185.67.36.141]:36868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jtFyd-0000QM-1n for 41552@debbugs.gnu.org; Wed, 08 Jul 2020 15:43:31 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id BE1F1160062 for <41552@debbugs.gnu.org>; Wed, 8 Jul 2020 21:43:24 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4B28qX5wTKz6tmM; Wed, 8 Jul 2020 21:43:19 +0200 (CEST) Message-ID: Subject: Re: [bug#41552] [PATCH] gnu: Add remid-lv2. From: Alexandros Theodotou To: Marius Bakke , 41552@debbugs.gnu.org Date: Wed, 08 Jul 2020 20:43:15 +0100 In-Reply-To: <87lfl93beq.fsf@gnu.org> References: <94c136949f58964383c2fabe6a28aa80bc3c79ea.camel@zrythm.org> <87lfl93beq.fsf@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-E0E8Gyo1vqSXZk94MXg5" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41552 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-E0E8Gyo1vqSXZk94MXg5 Content-Type: multipart/mixed; boundary="=-YK1MLXlXkaRgZzGht7oZ" --=-YK1MLXlXkaRgZzGht7oZ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Thanks for the feedback.=20 I fixed the patch although I'm not sure what to do with the description/summary - I don't know what those are either, I just know that it's a cool audio plugin. Feel free to edit it. Thanks, Alex On Sat, 2020-05-30 at 13:33 +0200, Marius Bakke wrote: > Alexandros Theodotou writes: >=20 > > Hi, > >=20 > > This patch adds the reMID LV2 plugin. >=20 > Thanks! >=20 > [...] >=20 > > +(define-public remid-lv2 > > + (package > > + (name "remid-lv2") > > + (version "0.3") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (string-append "https://github.com/ssj71/" > > + "reMID.lv2/archive/v" > > + version ".tar.gz")) >=20 > The GitHub /archive/ URLs are not stable: they might fall out of > GitHubs > cache and be regenerated, with different time stamps. So we should > use > git-fetch here instead. >=20 > This is different from "/releases/", which are > uploaded. Unfortunately > GitHubs UI makes it difficult to tell the difference short of looking > at > the URL. >=20 > > + (file-name (string-append name "-" version ".tar.gz")) > > + (sha256 > > + (base32 > > + "1kffpv90a967wwpsa0jb1jp5qnhf85m4ap8nfw8wih71rcrgg4h3" > > )))) > > + (build-system cmake-build-system) > > + (arguments > > + `(#:tests? #f)) ; no tests included > > + (inputs > > + `(("glib" ,glib) > > + ("alsa-lib" ,alsa-lib) > > + ("jack" ,jack-1) > > + ("lv2" ,lv2))) >=20 > Nit: we usually sort inputs. Helpful when there are dozens. >=20 > > + (native-inputs > > + `(("pkg-config" ,pkg-config))) > > + (home-page "https://github.com/ssj71/reMID.lv2") > > + (synopsis > > + "MIDI-controlled implementation of the SID 6581 chip used in > > the > > +Commodore 64") > > + (description > > + "The 6581 SID chip is the sound chip used in the Commodore > > 64 computer. > > +reMID is a MIDI implementation of the 6581 SID chip using the > > reSID library > > +to provide a virtual SID-based synthesizer, controllable in real- > > time via > > +MIDI. It includes support for scripted instruments that allow > > complex sonic > > +control of the chip.") >=20 > Why yes, I know some of these words :-) would it make sense to define > "SID" here with @acronym? >=20 > > + (license license:gpl2))) >=20 > This is actually GPL2+, because none of the source files say "version > 2 > only" (and some actually say explicitly GPL2-or-later). >=20 > Can you send an updated patch? --=-YK1MLXlXkaRgZzGht7oZ Content-Disposition: attachment; filename="0001-gnu-Add-remid-lv2.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-gnu-Add-remid-lv2.patch"; charset="UTF-8" RnJvbSA3Y2M1MzZkZmVlZWE3MzVhZmI4ZTE1ZjgzYzVlZWY4YWFjMDIwYzRmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4YW5kcm9zIFRoZW9kb3RvdSA8YWxleEB6cnl0aG0ub3Jn PgpEYXRlOiBXZWQsIDggSnVsIDIwMjAgMjA6Mzk6MzggKzAxMDAKU3ViamVjdDogW1BBVENIXSBn bnU6IEFkZCByZW1pZC1sdjIuCgoqIGdudS9wYWNrYWdlcy9tdXNpYy5zY20gKHJlbWlkLWx2Mik6 IE5ldyB2YXJpYWJsZS4KLS0tCiBnbnUvcGFja2FnZXMvbXVzaWMuc2NtIHwgMzYgKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMzYgaW5zZXJ0aW9u cygrKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9tdXNpYy5zY20gYi9nbnUvcGFja2FnZXMv bXVzaWMuc2NtCmluZGV4IGQwZjViZWUzYTAuLjYwNDIwMTVkZGEgMTAwNjQ0Ci0tLSBhL2dudS9w YWNrYWdlcy9tdXNpYy5zY20KKysrIGIvZ251L3BhY2thZ2VzL211c2ljLnNjbQpAQCAtNTQxOSw2 ICs1NDE5LDQyIEBAIGF1dG9tYXRpb24gdGhhdCBjb21lcyBhcyBhbiBMVjIgcGx1Z2luIGJ1bmRs ZSB3aXRoIGEgY3VzdG9tIFVJLiIpCiAgICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly9naXQuenJ5dGht Lm9yZy9jZ2l0L1pMRk8vIikKICAgICAobGljZW5zZSBsaWNlbnNlOmFncGwzKykpKQogCisoZGVm aW5lLXB1YmxpYyByZW1pZC1sdjIKKyAgKHBhY2thZ2UKKyAgICAobmFtZSAicmVtaWQtbHYyIikK KyAgICAodmVyc2lvbiAiMC4zIikKKyAgICAoc291cmNlCisgICAgICAob3JpZ2luCisgICAgICAg IChtZXRob2QgZ2l0LWZldGNoKQorICAgICAgICAodXJpIChnaXQtcmVmZXJlbmNlCisgICAgICAg ICAgICAgICAodXJsICJodHRwczovL2dpdGh1Yi5jb20vc3NqNzEvcmVNSUQubHYyLmdpdCIpCisg ICAgICAgICAgICAgICAoY29tbWl0IChzdHJpbmctYXBwZW5kICJ2IiB2ZXJzaW9uKSkpKQorICAg ICAgICAoZmlsZS1uYW1lIChnaXQtZmlsZS1uYW1lIG5hbWUgdmVyc2lvbikpCisgICAgICAgIChz aGEyNTYKKyAgICAgICAgICAoYmFzZTMyCisgICAgICAgICAgICAiMDYya3JpbmlpZHNyaHp3cmY4 OWtmeG05d2IwY21ncmwwN2FzbmxtZ2lsOHZjbDdnbDl5NSIpKSkpCisgICAgKGJ1aWxkLXN5c3Rl bSBjbWFrZS1idWlsZC1zeXN0ZW0pCisgICAgKGFyZ3VtZW50cworICAgICBgKCM6dGVzdHM/ICNm KSkgICAgICAgICAgICAgICAgICAgICAgOyBubyB0ZXN0cyBpbmNsdWRlZAorICAgIChpbnB1dHMK KyAgICAgYCgoImFsc2EtbGliIiAsYWxzYS1saWIpCisgICAgICAgKCJnbGliIiAsZ2xpYikKKyAg ICAgICAoImphY2siICxqYWNrLTEpCisgICAgICAgKCJsdjIiICxsdjIpKSkKKyAgICAobmF0aXZl LWlucHV0cworICAgICBgKCgicGtnLWNvbmZpZyIgLHBrZy1jb25maWcpKSkKKyAgICAoaG9tZS1w YWdlICJodHRwczovL2dpdGh1Yi5jb20vc3NqNzEvcmVNSUQubHYyIikKKyAgICAoc3lub3BzaXMK KyAgICAgICJNSURJLWNvbnRyb2xsZWQgaW1wbGVtZW50YXRpb24gb2YgdGhlIFNJRCA2NTgxIGNo aXAgdXNlZCBpbiB0aGUKK0NvbW1vZG9yZSA2NCIpCisgICAgKGRlc2NyaXB0aW9uCisgICAgICAi VGhlIDY1ODEgU0lEIGNoaXAgaXMgdGhlIHNvdW5kIGNoaXAgdXNlZCBpbiB0aGUgQ29tbW9kb3Jl IDY0IGNvbXB1dGVyLgorcmVNSUQgaXMgYSBNSURJIGltcGxlbWVudGF0aW9uIG9mIHRoZSA2NTgx IFNJRCBjaGlwIHVzaW5nIHRoZSByZVNJRCBsaWJyYXJ5Cit0byBwcm92aWRlIGEgdmlydHVhbCBT SUQtYmFzZWQgc3ludGhlc2l6ZXIsIGNvbnRyb2xsYWJsZSBpbiByZWFsLXRpbWUgdmlhCitNSURJ LiAgSXQgaW5jbHVkZXMgc3VwcG9ydCBmb3Igc2NyaXB0ZWQgaW5zdHJ1bWVudHMgdGhhdCBhbGxv dyBjb21wbGV4IHNvbmljCitjb250cm9sIG9mIHRoZSBjaGlwLiIpCisgICAgKGxpY2Vuc2UgbGlj ZW5zZTpncGwyKykpKQorCiAoZGVmaW5lLXB1YmxpYyB2bDEtZW11bGF0b3IKICAgKHBhY2thZ2UK ICAgICAobmFtZSAidmwxLWVtdWxhdG9yIikKLS0gCjIuMjcuMAoK --=-YK1MLXlXkaRgZzGht7oZ-- --=-E0E8Gyo1vqSXZk94MXg5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEESBMjhK0999huJUuDAi6uQjE9cPMFAl8GIdMACgkQAi6uQjE9 cPPZtQf9HoNWh4JNOdR7rXCoVedyNkzFcBGfHFxlb0AAQAT8kDilbEYcnpXDp+V0 vyRqDZM0H9cP2Rp8P252g51IGCnusfd3EbwNsxqYeq60pGXiqt+Ns5lLFEexb8nG K8QhmiAr7WTWagNmvXy9PPwer98NQYb0yBLab2NyBxr8Ruv7b7vqPQl2FE1MGtQZ n6Z3eQHZQ2W7xAXuOROEXLvnfrTJzz4oiTCqcdd9EFVtzls1FC4USMaHl3W1JoFw 88D9LfhVhdtEqmM64G1CTzRzXYz5X8uTJDhuw9Y4f4W5bbxXxfvnhuJPiVEoOKiE njocIV72t98NeW32dQLzPlOx7d2YaQ== =VlQZ -----END PGP SIGNATURE----- --=-E0E8Gyo1vqSXZk94MXg5--