From debbugs-submit-bounces@debbugs.gnu.org Sun May 24 16:03:01 2020 Received: (at 41431-done) by debbugs.gnu.org; 24 May 2020 20:03:01 +0000 Received: from localhost ([127.0.0.1]:38870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcwpl-0001Gd-N3 for submit@debbugs.gnu.org; Sun, 24 May 2020 16:03:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcwpk-0001GR-UP for 41431-done@debbugs.gnu.org; Sun, 24 May 2020 16:02:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36920) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcwpf-000505-EU; Sun, 24 May 2020 16:02:51 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=54746 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jcwpe-0003E3-3B; Sun, 24 May 2020 16:02:50 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Ryan Prior Subject: Re: [bug#41431] [PATCH] gnu: Add protonvpn-cli. References: <20200521032943.26115-1-rprior@protonmail.com> <87o8qe68hh.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 6 Prairial an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 24 May 2020 22:02:48 +0200 In-Reply-To: (Ryan Prior's message of "Sat, 23 May 2020 19:11:18 +0000") Message-ID: <87zh9x2j9z.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41431-done Cc: 41431-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Ryan Prior skribis: > =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original = Message =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 > On Saturday, May 23, 2020 2:17 PM, Ludovic Court=C3=A8s wr= ote: > >> there are definitely tests > > What makes you so sure? `grep -r '\Wtest' .` suggests that the only refer= ence to testing in the whole repo is in protonvpn_cli/utils.py (wait_for_ne= twork) which tests for a network connection at runtime. I don't think they = are shipping any tests; setup.py can test to make sure you can actually ins= tall your dependencies, but that's not a meaningful upstream test, it's a d= efault behavior. Oh my bad. I was fooled by the fact that =E2=80=9Csomething=E2=80=9D seeme= d to be happening when enabling tests. >> > - (license license:gpl3))) >> >> This is =E2=80=98gpl3+=E2=80=99 AFAICS since nothing says =E2=80=9Cversi= on 3 only.=E2=80=9D > > Nothing says "or any later version" either=E2=80=94I had been under the i= mpression that the "plus" was opt-in, but reading GPLv3 again it appears to= be opt-out. I don't know, that's not my area of expertise. I've updated th= e patch to gpl3+ with your recommendation in any case. Right, there=E2=80=99s this paragraph in the license: Each version is given a distinguishing version number. If the Program specifies that a certain numbered version of the GNU General Public License "or any later version" applies to it, you have the option of following the terms and conditions either of that numbered version or of any later version published by the Free Software Foundation. If the Program does not specify a version number of the GNU General Public License, you may choose any version ever published by the Free Software Foundation. In Guix we encode it by adding =E2=80=9C+=E2=80=9D as in =E2=80=9Cor any la= ter version=E2=80=9D. > From: Ryan Prior > Date: Wed, 20 May 2020 22:28:11 -0500 > Subject: [PATCH] gnu: Add protonvpn-cli. > > * gnu/packages/vpn.scm (protonvpn-cli): New variable. Applied, thanks! Ludo=E2=80=99.