From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 01:05:18 2020 Received: (at 40545-done) by debbugs.gnu.org; 2 May 2020 05:05:18 +0000 Received: from localhost ([127.0.0.1]:51095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUkL0-0004f0-Jd for submit@debbugs.gnu.org; Sat, 02 May 2020 01:05:18 -0400 Received: from rezeros.cc ([45.76.207.221]:43936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUkKy-0004em-Nt for 40545-done@debbugs.gnu.org; Sat, 02 May 2020 01:05:17 -0400 Received: from localhost ( [117.173.226.225]) by rezeros.cc (OpenSMTPD) with ESMTPSA id 7b68f74b (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 2 May 2020 05:05:07 +0000 (UTC) Received: from gift (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id c8e699ce; Sat, 2 May 2020 05:04:26 +0000 (UTC) From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) To: Pierre Langlois Subject: Re: [bug#40545] [PATCH] services: dnsmasq: Support the --address flag. References: <87wo6np6hh.fsf@gmx.com> <87zhb3per7.fsf@gmx.com> Date: Sat, 02 May 2020 13:04:26 +0800 In-Reply-To: <87zhb3per7.fsf@gmx.com> (Pierre Langlois's message of "Wed, 22 Apr 2020 20:16:44 +0200") Message-ID: <87bln76i79.fsf@member.fsf.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40545-done Cc: 40545-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pierre Langlois writes: > Hi all, > > Pierre Langlois writes: > >> Hello Guix! >> >> Here's a patch that allows passing the --address flag multiple times to >> dnsmasq. WDYT? Hello Pierre, this patch looks good to me, and I pushed it to master now, thank you! > > Any comment on this patch? Let me know if I should attempt at adding > some service tests for dnsmasq, that might be useful. Yes, I think adding a system test for dnsmasq is welcomed too :-)