From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 23 17:59:14 2020 Received: (at 40510-done) by debbugs.gnu.org; 23 Apr 2020 21:59:14 +0000 Received: from localhost ([127.0.0.1]:55942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRjsI-0001pH-8O for submit@debbugs.gnu.org; Thu, 23 Apr 2020 17:59:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRjsG-0001p4-9i for 40510-done@debbugs.gnu.org; Thu, 23 Apr 2020 17:59:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57220) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRjs9-0006Fu-Ka; Thu, 23 Apr 2020 17:59:05 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42470 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jRjs7-0005Gp-6j; Thu, 23 Apr 2020 17:59:04 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Alexandros Theodotou Subject: Re: [bug#40510] [PATCH] gnu: Add wolf-shaper. References: <8bac4beb758b4ab138718cd0f9211da1b69e6d63.camel@zrythm.org> Date: Thu, 23 Apr 2020 23:59:01 +0200 In-Reply-To: <8bac4beb758b4ab138718cd0f9211da1b69e6d63.camel@zrythm.org> (Alexandros Theodotou's message of "Wed, 08 Apr 2020 17:31:46 +0100") Message-ID: <87imhplv8a.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40510-done Cc: 40510-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Alexandros, Alexandros Theodotou skribis: > From ff5050712a95e5dc84325ecceac50f84cd71ee14 Mon Sep 17 00:00:00 2001 > From: Alexandros Theodotou > Date: Wed, 8 Apr 2020 17:30:45 +0100 > Subject: [PATCH 2/2] gnu: Add wolf-spectrum. > > * gnu/packages/music.scm (wolf-spectrum): New variable. [...] > + (synopsis "2D spectrogram plugin") > + (description "Wolf Spectrum is a real-time 2D spectrogram plugin. > +It is provided as an LV2 plugin and as a standalone Jack application.") > + (home-page "https://pdesaulniers.github.io/wolf-shaper/") > + (license license:gpl3))) [...] > From 80dbd4b8eea3beea8eb312acdb56374f486bb9b7 Mon Sep 17 00:00:00 2001 > From: Alexandros Theodotou > Date: Wed, 8 Apr 2020 17:21:19 +0100 > Subject: [PATCH 1/2] gnu: Add wolf-shaper. > > * gnu/packages/music.scm (wolf-shaper): New variable. [...] > + (synopsis "Waveshaper plugin") > + (description "Wolf Shaper is a waveshaper plugin with a graph editor. > +It is provided as an LV2 plugin and as a standalone Jack application.") > + (home-page "https://pdesaulniers.github.io/wolf-shaper/") > + (license license:gpl3))) Applied! Two comments though: 1. I believe the license is really =E2=80=98gpl3+=E2=80=99 because I don= =E2=80=99t see anything saying =E2=80=9Cversion 3 only=E2=80=9D. However, the situat= ion is a bit confused because source files apparently still contain the ISC license header, perhaps an omission since the projects were apparently recently relicensed. 2. The synopses could be improved: plugin for what? What application domain? The descriptions could also be expounded a bit, and this would make =E2=80=98guix search=E2=80=99 happier. :-) Could you follow up on these two things? Thanks, Ludo=E2=80=99.