Hi Nicolas, Thanks again! Nicolas Goaziou writes: > Hello, > > John Soo writes: > >> dhall-mode provides language support for the dhall configuration >> language. > > Thank you. > >> +(define-public emacs-dhall-mode >> + (package >> + (name "emacs-dhall-mode") >> + (version "0.1.0") > > This version is not accurate. The ".el" file mentions 0.1.3, but I think > we should use Github versioning, i.e., there is no versioning at all, so > we should do the commit + revision dance again, and use "0.1.3" as the > base of the version string. Done. >> + (source >> + (origin >> + (method git-fetch) >> + (uri >> + (git-reference >> + (url "https://github.com/psibi/dhall-mode") >> + (commit "ef4d33debe224c6ba37e51a29b9dc8b74f20f1c2"))) > > This should go in a dedicated variable. Did you mean the commit? If so that is also done. >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 >> + "1232y2k4l3bsz90pgis78zxmrw7jv09dfaip21yc1w4vpxfyr384")))) > > Nitpick: I usually put `base32' on the same line as the string. Ok, I like that better. Done. >> + (inputs > > Nitpick: Emacs build system uses `propagated-inputs', although this is > the same. Oh! I think that's a bug, then. If the input is not propagated, there will be an error when the user uses the package, right? Fixed. >> + `(("emacs-reformatter" ,emacs-reformatter))) >> + (build-system emacs-build-system) > > Nitpick: `build-system' is usually above No problem. Done. >> + (home-page "https://github.com/psibi/dhall-mode") >> + (synopsis "Major mode for working with Dhall configuration language") >> + (description >> + "Emacs Major mode for working with Dhall configuration >> language.") > > The description must be a full sentence. Fixed and added some more detail. >> + (license license:gpl2+))) > > The license looks wrong. I see GPL3+ in this package. Ah, fixed, sorry. > Could you send an updated patch? Sure. Attached. Thanks again, John