From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 25 18:41:15 2020 Received: (at 40227-done) by debbugs.gnu.org; 25 Mar 2020 22:41:16 +0000 Received: from localhost ([127.0.0.1]:57970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHEi3-0002aw-Ia for submit@debbugs.gnu.org; Wed, 25 Mar 2020 18:41:15 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:40925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHEi1-0002ag-3z for 40227-done@debbugs.gnu.org; Wed, 25 Mar 2020 18:41:14 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id CE5825C0190; Wed, 25 Mar 2020 18:41:07 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 25 Mar 2020 18:41:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=JtnC3Bhpn8yGKroABHlpOvevrR SYg4lCHtxGnBYlSP0=; b=vWim/vIhuQtxF6bT8F/55G8ya3hD2qfRwb9qpzqyk8 gcbUoPNKxEIta+bMEuSCAcvE2U+7IVyrOLjEJT2TjGWiclNHUcPjBCoHFGO7HXQN mllS/zgru7mcwHez1Es3MtV3vFLNhRhHA/xi8SjANJ/IVX/VeHdwIRyAa32T+AMw vCnGya8PJMzRapfdeTm2Wm4Q7L6TrGpobP0M59G3wuy7kmxAvnxzTJPzv7fJIu0O jcYBegCaES1Z6/g7JvoS18XMHYs8baEtsG9/Odm8amDrr1UXYw+lPk40+nnMOi8g t/NnCkwTsP+oEUlhjMieUuq1XJwpj80bFm/LxD6ZuaGA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=JtnC3B hpn8yGKroABHlpOvevrRSYg4lCHtxGnBYlSP0=; b=fm/VfH9ko+ZrRLM2Bxv5OE oBpkFPsZi1Fds0MJYVp8WBrHofckKw9+QSPT8LUTQYYh1v10w/piqYI7Z7QMWc6k pma5mWo3wty+JsWgCM2vph9FyDjbbMJNMxOtWVMOCO0MEdhH11zu8KmXv++FoYFz J0ujIXDQqTBSO2cqB9TDiemSwfZwiUlhvqRe0DuYvn19vPgKlA5ffgm2u8Tcl6lO HFHQnhKWhBE5O4gDgK+QuhiRSRX/Q5Eup383Ukr0iC5OfuLF6ClcwUTDPlWQam4O FRNPdP02roo/lyEElobVPdzixM+ILHYdFbiqxYHaliagoXFa3jPJMHdJSJb7pYMA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudehgedgudeflecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehgtd erredtredtnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcuoehmsggrkhhkvgesfhgr shhtmhgrihhlrdgtohhmqeenucfkphepkeegrddvtddvrdeikedrjeehnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgsrghkkhgvsehfrghs thhmrghilhdrtghomh X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 2E0A730673EB; Wed, 25 Mar 2020 18:41:07 -0400 (EDT) From: Marius Bakke To: Leo Famulari Subject: Re: [bug#40227] [PATCH] gnu: icu4c: Fix CVE-2020-10531. In-Reply-To: <20200325215427.GA29579@jasmine.lan> References: <87v9msyyii.fsf@devup.no> <20200325215427.GA29579@jasmine.lan> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Wed, 25 Mar 2020 23:41:05 +0100 Message-ID: <87sghwys5a.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40227-done Cc: 40227-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Wed, Mar 25, 2020 at 09:23:33PM +0100, Marius Bakke wrote: >> I'm not sure if the new test case as well as this git commit header is >> necessary. IMO it mostly adds noise to the patch. I.e. the whole file >> could be shortened to 6 lines + your comments at the top. >>=20 >> But no strong opinion, there is an argument to be made for preserving >> upstream commits in their entirety too (I think). >>=20 >> So, LGTM either way. Thank you! > > I commented out the changes to the test suite and pushed as > 7d57a190f6896c04b5dad66bf4360bc48a4052ff. What I meant was that they could be omitted entirely to shorten the patch (less lines to comb through for reviewers), but no worries! The important thing is that we get the security fix, thanks for watching out for those as always. :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl573gEACgkQoqBt8qM6 VPpXOwgAj2bxdvLOQx97jTNhT6yxPORYcpCHGX6XOW3FRuYWiCT2cCgMJ76IGTjI JsbhdkHD04WAVKoUYcUOXVIS3q3xP+OdfOqrm/NNlyKVI7CoW2/+QMPfITecOt7w VeQjd98Z5d+6Q7a3Z0veY4KFGx+KCEcGEAvrQSzOC3d0ex7lyKllU1hrZN5Row4z PNJ8WwqpbCEF+zUddxTvQa63wYMR70aTpvV6+CbEW9WZuuxNmwLHNEgyf5exZgxa r0JQ3eQ+aWYHq7tRtJY18CI3eTYmzBG7sAGi9HaM4z459FJaefcXXSGvDJQ8vpdf 6mLnLBfTZlqcHXel1Oz/5IoEr8JbTQ== =aRlZ -----END PGP SIGNATURE----- --=-=-=--