From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 24 10:05:38 2020 Received: (at submit) by debbugs.gnu.org; 24 Mar 2020 14:05:38 +0000 Received: from localhost ([127.0.0.1]:55390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGkBU-0004su-Ad for submit@debbugs.gnu.org; Tue, 24 Mar 2020 10:05:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:52126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGkBQ-0004sa-9u for submit@debbugs.gnu.org; Tue, 24 Mar 2020 10:05:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54578) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGkBO-0006Cu-Hq for guix-patches@gnu.org; Tue, 24 Mar 2020 10:05:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGkBK-0001tN-Pr for guix-patches@gnu.org; Tue, 24 Mar 2020 10:05:30 -0400 Received: from araneo.si ([2001:15c0:2110:3400::2]:37666) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGkBK-0001jr-9o for guix-patches@gnu.org; Tue, 24 Mar 2020 10:05:26 -0400 Received: from araneo.si (localhost.lan [127.0.0.1]) by araneo.si (OpenSMTPD) with ESMTP id 47f14c66 for ; Tue, 24 Mar 2020 14:05:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=20180623; bh=WGs2ZnSHTbhaNPh1Mzjoc a3jrHQ=; b=snBQlDKLroPCNGVp58EC7GqcmB9Nd+ULTwAmWmoNa/wN495hx2gFg rBj4MWIQG51SDxWSd/Fi4+axDHChC040OZRQTu3Xv5urSm0LLxRrsC9hCFqSaTVy SK7NeT+HagKA7c3jocDW9wi/vYe7PYqEyxu1wt6K4OLl3I/wZArvwlJ9Wqq+BaCo vEX/EtIy9e0xnop8iASRs6o0J7p285db8EIxNF44MxempaHPcpuDGX3H0gXkIlbJ VmxBF3HjISx9ayGrLoaMNMf8A2fL45AXsBStjOkl2whk1bw5PdVmeSfHidcs+NkC j3juSISSPWaQek0W4o35Q6OwjuOUZCx9g== Received: by araneo.si (OpenSMTPD) with ESMTPSA id 3c4be8ef (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Tue, 24 Mar 2020 14:05:20 +0000 (UTC) From: Timotej Lazar To: guix-patches@gnu.org Subject: [PATCH 0/2] Enable udev support in SDL2 and bump version Date: Tue, 24 Mar 2020 15:05:19 +0100 Message-ID: <87tv2dc0gw.fsf@araneo.si> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:15c0:2110:3400::2 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi, these patches update sdl2 to the latest release and enable udev support. Without udev I experienced freezes every few seconds in certain games (for instance hedgewars and supertux) as SDL searched through /dev/input for joysticks. Since libudev is dlopened, I add it to rpath in make-flags. During build this overrides LDFLAGS from the base package=E2=80=99s configure-flags, whi= ch add mesa to rpath. AFAICT this is OK as sdl2 already includes mesa by linking libgbm. (Perhaps we could move LDFLAGS to make-flags in the base package, and make the override explicit in the derived package? Or have sdl2 find and modify the LDFLAGS entry from the base configure-flags, but that seems more trouble than it=E2=80=99s worth.) I was able to rebuild all dependent packages with no (new) failures. I ran several games and everything appears OK, but I don=E2=80=99t have a joy= stick or gamepad to try. There have been some issues in the past with SDL not finding (correct) libraries=C2=B9, so it would be good to test this on a foreign Guix install. As for the version bump, the changelog=C2=B2 doesn=E2=80=99t mention any si= gnificant changes except for hidapi support, which is disabled by default. Thanks! Timotej =C2=B9 https://lists.gnu.org/archive/html/guix-devel/2015-03/msg00585.html =C2=B2 https://hg.libsdl.org/SDL/file/355a4f94a782/WhatsNew.txt Timotej Lazar (2): gnu: sdl2: Use udev to discover input devices. gnu: sdl2: Update to 2.0.12. gnu/local.mk | 1 - gnu/packages/patches/sdl2-mesa-compat.patch | 21 ---------------- gnu/packages/sdl.scm | 27 ++++++++++++--------- 3 files changed, 16 insertions(+), 33 deletions(-) delete mode 100644 gnu/packages/patches/sdl2-mesa-compat.patch --=20 2.25.1