From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 15 16:18:46 2020 Received: (at 39258) by debbugs.gnu.org; 15 Jun 2020 20:18:46 +0000 Received: from localhost ([127.0.0.1]:47560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkvZ8-0000NP-Az for submit@debbugs.gnu.org; Mon, 15 Jun 2020 16:18:46 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:47076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkvZ4-0000ND-Ke for 39258@debbugs.gnu.org; Mon, 15 Jun 2020 16:18:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XTjt+hL6kTgRtgDdRGuFat1EXlW6tKcxy5xWcfA8ysE=; b=f5Odcm9OWeOjxnPoMgE8ILZXW /47MNizWrCMuL3jqkHOi+ZUU2vRoj+Dcq+0Ps8Sz/n8tEl2WHBtVzhPN1MI+s8UlUAiWK6Qo6Dfn1 009N+KfykymAAebw3vjVoQh6nzAJi5cmnBUwdonF6Y6A+yvXkN23O5I+xfuAIFwXbk68U=; Received: from [192.168.2.1] (helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jkvYz-001RD6-1b; Tue, 16 Jun 2020 01:48:37 +0530 From: Arun Isaac To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#39258] [PATCH 2/4] ui: Use string matching with literal search strings. In-Reply-To: <87ftayzrqi.fsf@gnu.org> References: <20200601000030.7443-1-arunisaac@systemreboot.net> <20200601000030.7443-3-arunisaac@systemreboot.net> <87y2owmyf3.fsf@gnu.org> <87ftayzrqi.fsf@gnu.org> Date: Tue, 16 Jun 2020 01:48:31 +0530 Message-ID: <87a714nkvc.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39258 Cc: 39258@debbugs.gnu.org, zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >> So, shall I push the remaining patches (patches 1, 3, 4) after applying >> the change you suggested for patch 1 (use of if versus cond)? > > Yes, definitely! Done! >>>> * guix/scripts/package.scm (process-query): Make search query a regexp= only if >>>> it is not a literal search string. >>>> * guix/ui.scm (relevance): Use string matching with literal search str= ings and >>>> regexp matching with regexp search strings. >>> >>> How does this affect performance? > > (To be clear, I=E2=80=99m referring specifically to this patch.) Oh, I misunderstood. Here are the results specifically comparing patch 2 against the latest master (that includes the patches 1, 3 and 4 I just pushed). All readings are on a warm cache. |----------------------------------+--------+-------| | query | before | after | |----------------------------------+--------+-------| | guix search strategy game | 2.1 | 1.7 | | guix search strategy game caesar | 1.8 | 1.5 | |----------------------------------+--------+-------| --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAl7n15cACgkQLiXui2GA K7NgJgf/YrTf2gVKPTV6D930QUmTCTHK7+62b4y5WuOU5UxZWcgizs6iZD3AoVq8 E39md5kiA7qECfA+YFfBIEA9LgRLdlRYyKm4+WWdDIdbEaFiYAyiVw3hA5seu4/n 7wPgK7tQTU0vv5yi7ovG2aIezkkw/9TOATEJRerKIlzK/TsThpBBCftnxiIHJ9z9 2WD5wfxh7UHGBbRMQ5mkPIfmx1UVLoRBAdeFU+vCZ/CWOwh6uU8VwFYWEV9tmYM/ 0hVqS8LowgmzytBPn+G5sbI6+hffMAvHJXkJoesazrQLxnQWYW3ew1Y/ogYbeOBa LqkYT9uXy3+EqfqoPETsYwCus/DWfg== =92VK -----END PGP SIGNATURE----- --=-=-=--