[PATCH 0/2] Add redsea, minor changes to liquid-dsp

  • Done
  • quality assurance status badge
Details
2 participants
  • Evan Straw
  • Ludovic Courtès
Owner
unassigned
Submitted by
Evan Straw
Severity
normal
E
E
Evan Straw wrote on 16 Jan 2020 08:18
(address . guix-patches@gnu.org)
87wo9r98ds.fsf@virtualplaza.i-did-not-set--mail-host-address--so-tickle-me
From c7b8d253b5959f7e8b61bd1730249df26f071a29 Mon Sep 17 00:00:00 2001
From: Evan Straw <evan.straw99@gmail.com>
Date: Wed, 15 Jan 2020 23:13:44 -0800
Subject: [PATCH 0/2] Add redsea, minor changes to liquid-dsp

Hi all,
This is a new patch series for the same packages submitted in my earlier bug
(38842). Some things changed since the last patch series and so I decided to
submit a different, modified patch series that includes only the changes that
are relevant now to avoid confusion when applying the patches.

Evan Straw (2):
gnu: liquid-dsp: Remove unused module imports.
gnu: Add redsea.

gnu/packages/ham-radio.scm | 51 +++++++++++++++++++++++++++++++++++++-
gnu/packages/sdr.scm | 3 +--
2 files changed, 51 insertions(+), 3 deletions(-)

--
2.20.1
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE6f/SZXb4DLdwy+VR9TDDtKKp8G0FAl4gDk8ACgkQ9TDDtKKp
8G14ig//fOwmi+RS2TQnYHRI7fZLnN4byb6wolP6Z2PuEB94ZtZ0m5mW4mbxx3rn
YphKKHgL3Fn/8HGD1/M0m+J4aECw7vyht34iQfYZbLzRrbFUOuplnmctaJglvS4H
RNaCSx2xZPoJabZbEhyMm1uxKy4HpUw0gonQkJqE3Co1x8A4NJXPrFXdJiqgT2Ba
RERhKJ4mRSsOSXcR2bTLSyER0gj/tckncF87+16O/LzGP312IAbJF0XaIhZhkW1/
ngqY0WXXGETHtVQeeTuqi6U/to0mRyELXt9o9aKAgqyNVaMsQT3fSFTS8VPMhS/p
R2RI0K5F3FBWQQTo4wSzMf7Jkp2wHTAP2pYu1TJ0zSi+Cu2d9KRrStETe2MMxQrc
/80+RhTOc2h9hanyQEB2ZJhinewZzjZyZ7DwyeldN7wsPH8wf/SDICGjnCCk9oP8
Oxe/mm645zFNPnLyr4wdHHmT/urpOye+COo29ZPoyDg/f2cPcFa9ywDicERV1WU/
OcdCeQlsdWgEcXZ6bHoYpWH7wq9K5nBhXOEuxo7HVtGUHo1X5JzcTzdQPnqnYdal
fsL0wUnKkI5xWojhkqN7/mohEHcwcGoKsiD8ybDS4Et70qa57xxIR1HK/TQ9aZ06
62PcNs5kFGPcCbgr93ytS0liq8qn05lJTPQqPt2LNjDbkSufziU=
=BH+0
-----END PGP SIGNATURE-----

E
E
Evan Straw wrote on 16 Jan 2020 08:37
[PATCH 1/2] gnu: liquid-dsp: Remove unused module imports.
(address . 39150@debbugs.gnu.org)
87lfq76edm.fsf@gmail.com
Made some slight modifications to this package; specifically,
(guix utils) was included although it was not used.

-- Evan
From dc527071eb098130a87f6c9259c0faad5fe88efb Mon Sep 17 00:00:00 2001
From: Evan Straw <evan.straw99@gmail.com>
Date: Wed, 15 Jan 2020 23:06:34 -0800
Subject: [PATCH 1/2] gnu: liquid-dsp: Remove unused module imports.

* gnu/packages/sdr.scm (liquid-dsp): Remove unused module imports.
---
gnu/packages/sdr.scm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Toggle diff (25 lines)
diff --git a/gnu/packages/sdr.scm b/gnu/packages/sdr.scm
index f6c9050503..563a9b3887 100644
--- a/gnu/packages/sdr.scm
+++ b/gnu/packages/sdr.scm
@@ -1,5 +1,6 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2019 Christopher Howard <christopher@librehacker.com>
+;;; Copyright © 2019, 2020 Evan Straw <evan.straw99@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -19,11 +20,9 @@
(define-module (gnu packages sdr)
#:use-module ((guix licenses) #:prefix license:)
#:use-module (guix packages)
- #:use-module (guix utils)
#:use-module (guix download)
#:use-module (guix git-download)
#:use-module (guix build-system gnu)
- #:use-module (gnu packages)
#:use-module (gnu packages algebra)
#:use-module (gnu packages autotools))
--
2.20.1
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE6f/SZXb4DLdwy+VR9TDDtKKp8G0FAl4gErUACgkQ9TDDtKKp
8G2VdRAAznwGOMGVo/YpJEoeMWz8HoWWrPST3VTX6ekx6xYOj+ZaNZGDvtfMTLl/
g2ExgTTP213oltc/rm5hE7Ap6+fM6eGcIgXD9tuMMA1q6KntmDfk6h841gFwWRQh
C/GTGQr2sUQKzqVbU+rbYdL2DWTUYzFQOWRA0kPeNwsB2BEC6pVv9PZYHeChi1HU
GQtIWcShL5CIvSY/YhwkGTzJmeMneCTA53HmQ82CsR4fz+zdX8GKimYoxMIoEpOR
k9P+fSrjRr4wOvUnqQugC8DiDeCGT5WCZkAZu6lCzldgRcP/vt2CcgBLz2cTIg5e
Fney5WOqDWh+opcczWVuelXBOpIAZ8VrOaNwCoWs2LDPrOTxfyXlufTNCSf2aTZ4
krRts5R4T6mwkVlL/2afEm6aIFcx2TEjsqIQ74RTcv/pVKCEBjf4XmsFsOcPT183
FMyADPqtbwRXSshi4iF5b+Oni4nOinBE0DpptObjIycLFH5o9LBozFe//wP3CE++
A5fsbw2qVut/QM3WF+n83AhEvt2cFjmWD1Dal469a/B8uWowax/7jOySdyjUnZcG
rV/Pwn0SKZattnIIgjpK/YfmI1M08uUKgfVQgwGklH8x9O+xI/ajTX/1inFJwi0V
/rbLYTKu2v/+RQpJwRjrurbJWe/g6c80+q89QODudOinDPQTtG8=
=8U+w
-----END PGP SIGNATURE-----

E
E
Evan Straw wrote on 16 Jan 2020 08:38
[PATCH 2/2] gnu: Add redsea.
(address . 39150@debbugs.gnu.org)
87h80v6ebr.fsf@gmail.com
Finally, here is the patch for Redsea, which now uses the liquid-dsp
definition in sdr.scm.

-- Evan
From c7b8d253b5959f7e8b61bd1730249df26f071a29 Mon Sep 17 00:00:00 2001
From: Evan Straw <evan.straw99@gmail.com>
Date: Wed, 15 Jan 2020 23:12:53 -0800
Subject: [PATCH 2/2] gnu: Add redsea.

* gnu/packages/ham-radio.scm (redsea): New variable.
---
gnu/packages/ham-radio.scm | 51 +++++++++++++++++++++++++++++++++++++-
1 file changed, 50 insertions(+), 1 deletion(-)

Toggle diff (81 lines)
diff --git a/gnu/packages/ham-radio.scm b/gnu/packages/ham-radio.scm
index 6b3f68cd7d..376191af54 100644
--- a/gnu/packages/ham-radio.scm
+++ b/gnu/packages/ham-radio.scm
@@ -1,6 +1,6 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2017, 2018, 2019 Arun Isaac <arunisaac@systemreboot.net>
-;;; Copyright © 2019 Evan Straw <evan.straw99@gmail.com>
+;;; Copyright © 2019, 2020 Evan Straw <evan.straw99@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -22,6 +22,8 @@
#:use-module (guix packages)
#:use-module (guix download)
#:use-module (guix git-download)
+ #:use-module (gnu packages autotools)
+ #:use-module (gnu packages base)
#:use-module (gnu packages gtk)
#:use-module (gnu packages image)
#:use-module (gnu packages libusb)
@@ -29,6 +31,7 @@
#:use-module (gnu packages pulseaudio)
#:use-module (gnu packages python)
#:use-module (gnu packages python-xyz)
+ #:use-module (gnu packages sdr)
#:use-module (gnu packages xml)
#:use-module (guix build-system cmake)
#:use-module (guix build-system gnu)
@@ -127,3 +130,49 @@ satellites, the POES NOAA weather satellite series. These transmissions are
on a frequency of 137 MHz. They can be received using an inexpensive antenna
and a dedicated receiver.")
(license license:gpl2+)))
+
+(define-public redsea
+ (package
+ (name "redsea")
+ (version "0.18")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/windytan/redsea")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1y96g0ra2krjb2kypm8s5gdfia45yci4f36klsvyzg8d53v5cwhn"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ ;; The configure.ac file does not explicitly link against libiconv
+ ;; except on Mac OS, causing the build to fail. This phase comments
+ ;; out the original AC_SUBST macro (located inside a conditional) and
+ ;; adds an explicit use of it underneath, so that libiconv is always
+ ;; linked against.
+ (add-after 'unpack 'patch-libiconv
+ (lambda _
+ (substitute* "configure.ac"
+ (("^ +AC_SUBST")
+ "# AC_SUBST")
+ (("esac")
+ "esac\nAC_SUBST([ICONV], [\"-liconv\"])"))
+ #t)))))
+ (inputs
+ `(("libiconv" ,libiconv)
+ ("libsndfile" ,libsndfile)
+ ("liquid-dsp" ,liquid-dsp)))
+ (native-inputs
+ `(("autoconf" ,autoconf)
+ ("automake" ,automake)))
+ (home-page "https://github.com/windytan/redsea")
+ (synopsis "Lightweight RDS to JSON decoder")
+ (description "redsea is a lightweight command-line @dfn{FM Radio Data
+System} (FM-RDS) decoder. Redsea can be used with any RTL-SDR USB radio stick
+with the rtl_fm tool, or any other @dfn{software-defined radio} (SDR) via
+csdr, for example. It can also decode raw ASCII bitstream, the hex format
+used by RDS Spy, and audio files containing @dfn{multiplex} signals (MPX).")
+ (license license:expat)))
--
2.20.1
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE6f/SZXb4DLdwy+VR9TDDtKKp8G0FAl4gEvgACgkQ9TDDtKKp
8G2yHg//SAcCvzLEQSQuVlnx+efqxLjXnzVi7s1hTVdvzMeMq8ISMI3h9KOP2W6A
S2IMLDZxir8Qm6x3e9EE8jCwRJtQU3L6A8sa+50AY3UFFDiYSaE10zrJ9SUQGKhN
gosA8NUrEf0KcF1GcqGA4Ff4cnNsHK1K09rq+f1DTCbbz46n93BXgr5r36TyKBBB
y6kDcW9d34W5657c9uKomU2peHIfYXRKawGZYzEzSgnvYhB6cl2T84LZDYTWpuLD
HO0iu1LAgJnj8I2/LBnJQBTNcn1/QmshIUlqMFEShx+eBebGoGRtsbdx7OihcW7i
19WFs6NF5SN8RPpa6KVG1GB5S8yeLM+u+f8YF6xMYy1pQJhzFJb/Y3vO3kzAzVUT
bae2s/lydoS0uoSZMPfrQmq2M9blJM042xzcd435x00Uj7PdkIFB5vgG+HovtKl7
gR3BMwW+dNMw/Y7Dl+GqVOnHD3kpvicrcqXtrd/gXPXOA9hYQbk5CvUMad2uEgK+
mc0EZnGWr0WGgjaduWKVcLPsrG0TSH5xFBh7urrEdNO/6kERdum1mKNvEHCmZIYQ
J6xr/xxUxIBNbreQ9Ar1jvp6NxWI8T4b3FZPsflSQYr3t6nPZQccnBw+KvqwOR54
cwf2xQbBerbmP992SeTSiMHU9GRgco7e12x9FH7G3GNAZKECKyk=
=uufm
-----END PGP SIGNATURE-----

L
L
Ludovic Courtès wrote on 5 Feb 2020 00:07
Re: [bug#39150] [PATCH 0/2] Add redsea, minor changes to liquid-dsp
(name . Evan Straw)(address . evan.straw99@gmail.com)(address . 39150-done@debbugs.gnu.org)
87v9omt0ij.fsf@gnu.org
Hi Evan,

Evan Straw <evan.straw99@gmail.com> skribis:

Toggle quote (9 lines)
> This is a new patch series for the same packages submitted in my earlier bug
> (38842). Some things changed since the last patch series and so I decided to
> submit a different, modified patch series that includes only the changes that
> are relevant now to avoid confusion when applying the patches.
>
> Evan Straw (2):
> gnu: liquid-dsp: Remove unused module imports.
> gnu: Add redsea.

Applied both patches, thank you!

Ludo’.
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 39150@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 39150
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch