From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 20 16:44:02 2020 Received: (at 38884) by debbugs.gnu.org; 20 Sep 2020 20:44:02 +0000 Received: from localhost ([127.0.0.1]:52781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kK6Bm-0005VV-Fi for submit@debbugs.gnu.org; Sun, 20 Sep 2020 16:44:02 -0400 Received: from sender4-of-o56.zoho.com ([136.143.188.56]:21621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kK6Bj-0005Ux-8j for 38884@debbugs.gnu.org; Sun, 20 Sep 2020 16:44:00 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1600634636; cv=none; d=zohomail.com; s=zohoarc; b=ZwC100er3q7Fq1GkrMtJP60RID7IC3rlAAqd0v7qh6cDMO6NPEwjDwwGDhpgrIUDB/cRgfHXlk0OF11hNbIAIdt0gB+D8XaTwiHZi3Y4OkG3Yf9GJBY7ZfunZMZOiI+F1DZ4HYMaakOI3+oS/VW5jH50DZ4SEA1H/+w5FHEgHxs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600634636; h=Content-Type:Date:From:MIME-Version:Message-ID:Subject:To; bh=Dszoyh36ubaWTcxsiO8CYr0b3SCmhuxI6PJCFNZMogo=; b=BLETcrSFFQkT0mu0mByX6VQNf0Ae9L193C3CqqTCn3kmhFiQYUFA6srQxWJhQvtKzMGVePyjnRpFFdtc6rXZLRK8qkC5PFXpVDwr5/PDNPhggRA2xrMGfOZFe50aTcg9fs/hlzm7sy3yejOrBYxQRlZhsJrqPO5cJ7Mchcz9Bk4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=issues.guix.gnu.org@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1600634636; s=zoho; d=elephly.net; i=issues.guix.gnu.org@elephly.net; h=MIME-Version:Content-Type:From:To:Date:Message-ID:Subject; bh=Dszoyh36ubaWTcxsiO8CYr0b3SCmhuxI6PJCFNZMogo=; b=bAV6TK5lhnTbC/aWMTe74AAZPbvLxP57+HoVUmSVWCzWd3vQQCZ0321gfOJPu3yo SiYmCZfiHVLJupoYQLk4PJ/Ot56e5neY6AN880BzMQfDoDKqBlnMMdNy1GGzXGKm9RL 4GM2e5nHE/kj6SpZVbKEwVu+9dqkd6ZsLemD5OE4= Received: from localhost (185.220.102.245 [185.220.102.245]) by mx.zohomail.com with SMTPS id 160063463470679.71665733139844; Sun, 20 Sep 2020 13:43:54 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 From: Brice Waegeneire via web To: 38884@debbugs.gnu.org Date: Sun, 20 Sep 2020 22:43:48 +0200 Message-ID: <7f8ff855af90.4ca1a3edb126540@guile.gnu.org> Subject: guix system roll-back doesn't roll setuid-programs back X-ZohoMailClient: External X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello Guix, "setuid-programs-service" extend the activation script which isn't loaded when rolling-back. A difference between "reconfigure" and "switch-generation" (of which "roll-back" is just an useful alias) is that the former load the activation script (guix scripts system reconfigure switch-system-p [...] Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [136.143.188.56 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [136.143.188.56 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 1.3 AC_FROM_MANY_DOTS Multiple periods in From user name X-Debbugs-Envelope-To: 38884 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Hello Guix, "setuid-programs-service" extend the activation script which isn't loaded when rolling-back. A difference between "reconfigure" and "switch-generation" (of which "roll-back" is just an useful alias) is that the former load the activation script (guix scripts system reconfigure switch-system-program) after switching the profile's symlinks and before installing the bootloader while the latter install the bootloader (guix scripts system switch-to-system-generation) then switch the symlinks (guix profiles switch-to-generation). Fixing that could be done by loading the activation script after switching profiles, as "reconfigure" does. I guess that loading the activation script again, on a already running running system, can have side effect but it shouldn't be an issue as it's already done by "reconfigure". Cheers, - Brice