From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 22 12:11:13 2019 Received: (at 37857) by debbugs.gnu.org; 22 Oct 2019 16:11:13 +0000 Received: from localhost ([127.0.0.1]:60357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMwka-0007OZ-RQ for submit@debbugs.gnu.org; Tue, 22 Oct 2019 12:11:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMwkZ-0007OL-Cz for 37857@debbugs.gnu.org; Tue, 22 Oct 2019 12:11:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59616) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iMwkR-0002as-Mg; Tue, 22 Oct 2019 12:11:05 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=39576 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iMwkP-0002Qb-V8; Tue, 22 Oct 2019 12:11:03 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Julien Lepiller Subject: Re: [bug#37857] [PATCH] guix: svn: Allow dropping externals References: <20191021215538.60675430@sybil.lepiller.eu> Date: Tue, 22 Oct 2019 18:10:59 +0200 In-Reply-To: <20191021215538.60675430@sybil.lepiller.eu> (Julien Lepiller's message of "Mon, 21 Oct 2019 21:55:38 +0200") Message-ID: <87d0eozros.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37857 Cc: 37857@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Julien, Julien Lepiller skribis: >>From 0ac412a3c912b2fe7ebd05d178120db50d47184e Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Mon, 21 Oct 2019 21:48:31 +0200 > Subject: [PATCH] guix: svn: Allow dropping externals. > > * guix/build/svn.scm (svn-fetch): Allow to ignore externals. > * guix/svn-download.scm (svn-reference, svn-multi-reference): Add > fetch-externals? field. Nice. For consistency with git-download.scm & co., what about calling the parameter and the field =E2=80=98recursive?=E2=80=99 rather than =E2=80=98f= etch-externals?=E2=80=99? > (define-record-type* > svn-reference make-svn-reference > svn-reference? > - (url svn-reference-url) ; string > - (revision svn-reference-revision) ; number > - (user-name svn-reference-user-name (default #f)) > - (password svn-reference-password (default #f))) > + (url svn-reference-url) ; string > + (revision svn-reference-revision) ; number > + (fetch-externals? svn-reference-fetch-externals? (default #t)) Do you know of packages that rely on externals? It=E2=80=99d be great to eventually default to #f, but for that we=E2=80=99= d need to check every package that uses =E2=80=98svn-fetch=E2=80=99 (notably all the = TeX Live packages.) Thanks, Ludo=E2=80=99.