From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 22 18:08:53 2019 Received: (at 37855-done) by debbugs.gnu.org; 22 Oct 2019 22:08:53 +0000 Received: from localhost ([127.0.0.1]:60586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iN2Kj-0007eq-9M for submit@debbugs.gnu.org; Tue, 22 Oct 2019 18:08:53 -0400 Received: from mira.cbaines.net ([212.71.252.8]:58002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iN2Kh-0007eh-Dq for 37855-done@debbugs.gnu.org; Tue, 22 Oct 2019 18:08:52 -0400 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 86BB1172E4; Tue, 22 Oct 2019 23:08:50 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id a2b49ca6; Tue, 22 Oct 2019 22:08:50 +0000 (UTC) References: <20191021174223.28196-1-mail@cbaines.net> <87zhhsycua.fsf@gnu.org> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#37855] [PATCH] gnu: guix-data-service: Enable build time tests. In-reply-to: <87zhhsycua.fsf@gnu.org> Date: Tue, 22 Oct 2019 23:08:48 +0100 Message-ID: <874l00qvpr.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 37855-done Cc: 37855-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi, > > Christopher Baines skribis: > >> Previously the tests were not run, as PostgreSQL wasn't running at build >> time. Now there's a new target, check-with-tmp-database that uses epheme= ralpg >> to run the tests without relying on an externally managed PostgreSQL ser= vice. >> >> * gnu/packages/web.scm (guix-data-service)[arguments]: Remove #:tests? #= f, and >> set #:test-target to "check-with-tmp-database". >> [native-inputs]: Add ephemeralpg. > > Nice, LGTM! Great, I've pushed this now as 353f5f7aa7ea575f9f04d3a0b277bbb8012b942d. > I wonder: can=E2=80=99t you just have =E2=80=9Cmake check=E2=80=9D do thi= s, or do you want to > have =E2=80=9Cmake check=E2=80=9D talk to a real database instead? It's mostly a new target as I already had "make check" just run the tests, but yeah, it might be more useful for "make check" to setup an empty database, then run the tests. I'm not quite sure yet. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl2vffBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xfs4w//RfJPmZncbmcSqct9h1uLUzeQ0u/0ciewYU23DPslnxQo0a9XOZ2jO7i9 toqZPoPsMSMvZXyhljg4lawyp0yav9VdN7JTrbrVPFCqaJvTJFHfqVuHQfhjtmzq ltyvpPPS56zB/NLbfP4acPCRX6iLUEogZoc/N27IPOll9TDfoJh6Y14MVBgTG001 YUJUHE4c6/E75nKwJyDby3vhQef0o+X1JiJZOD1UJXGVl23U5ZGkb3GZJml4RvdU j8eZ0iADfwzaxZfEAmMTA6hWHDaGD2ZfCmyNRkWWvenrJpXSN6BTbMswxxa6DSX4 d/CwMBTNtyC7PqVO3s4mkGB4nBY1P1Vi34hn2ubcft2nXze5rxrJOgfejGznreCD //Az6KwaSA64FoCdPjFZycxo5fAVpo+k9U5x6CHDtNWpSBKPh07OLvuHkhGbZSOM IJSf9rsJEChgdGV9YgLPvwukgS2FY325hjJ4vjrpuXbqHU6JuS0XHv3zUEpbdhL9 RtBHZy47pmbACLethVm1GgPDVX82BVMRT6+9lpCd1zSQpBBkBdzGL16WDc5KWISI uuaoyFlqiliZV5ohxawp+hWBs1BDMDrSroyCkdl17D0cFfVZdN25HxHO+WMmt55P B+XAw/iB7LBNbHGF1ihs+jeQIPKoZRAFXGGNC5koY9HxjNQH7tY= =ecW1 -----END PGP SIGNATURE----- --=-=-=--