From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 22 12:17:14 2019 Received: (at 37855) by debbugs.gnu.org; 22 Oct 2019 16:17:14 +0000 Received: from localhost ([127.0.0.1]:60376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMwqP-0007ZJ-SP for submit@debbugs.gnu.org; Tue, 22 Oct 2019 12:17:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMwqL-0007Z1-KG for 37855@debbugs.gnu.org; Tue, 22 Oct 2019 12:17:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iMwqG-0005IB-B1; Tue, 22 Oct 2019 12:17:04 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=39596 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iMwqF-0003RY-I3; Tue, 22 Oct 2019 12:17:03 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Christopher Baines Subject: Re: [bug#37855] [PATCH] gnu: guix-data-service: Enable build time tests. References: <20191021174223.28196-1-mail@cbaines.net> Date: Tue, 22 Oct 2019 18:17:01 +0200 In-Reply-To: <20191021174223.28196-1-mail@cbaines.net> (Christopher Baines's message of "Mon, 21 Oct 2019 18:42:23 +0100") Message-ID: <87zhhsycua.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37855 Cc: 37855@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Christopher Baines skribis: > Previously the tests were not run, as PostgreSQL wasn't running at build > time. Now there's a new target, check-with-tmp-database that uses ephemer= alpg > to run the tests without relying on an externally managed PostgreSQL serv= ice. > > * gnu/packages/web.scm (guix-data-service)[arguments]: Remove #:tests? #f= , and > set #:test-target to "check-with-tmp-database". > [native-inputs]: Add ephemeralpg. Nice, LGTM! I wonder: can=E2=80=99t you just have =E2=80=9Cmake check=E2=80=9D do this,= or do you want to have =E2=80=9Cmake check=E2=80=9D talk to a real database instead? (For the Guix test suite, =E2=80=98test-env=E2=80=99 spawns a daemon with a= temporary store for test purposes; I wonder if the situation is comparable here.) Thanks, Ludo=E2=80=99.