From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 07 15:21:35 2019 Received: (at submit) by debbugs.gnu.org; 7 Aug 2019 19:21:35 +0000 Received: from localhost ([127.0.0.1]:39415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvRV8-00013J-Ow for submit@debbugs.gnu.org; Wed, 07 Aug 2019 15:21:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:33301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvRV7-000139-Py for submit@debbugs.gnu.org; Wed, 07 Aug 2019 15:21:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49045) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvRV5-00037u-Ph for guix-patches@gnu.org; Wed, 07 Aug 2019 15:21:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvRV4-0005uu-Qs for guix-patches@gnu.org; Wed, 07 Aug 2019 15:21:31 -0400 Received: from dustycloud.org ([2600:3c02::f03c:91ff:feae:cb51]:52024) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hvRV4-0005ts-MD for guix-patches@gnu.org; Wed, 07 Aug 2019 15:21:30 -0400 Received: from twig (localhost [127.0.0.1]) by dustycloud.org (Postfix) with ESMTPS id 861F92661E; Wed, 7 Aug 2019 15:21:27 -0400 (EDT) References: <87imr9402l.fsf@sdf.lonestar.org> User-agent: mu4e 1.2.0; emacs 26.2 From: Christopher Lemmer Webber To: guix-patches@gnu.org Subject: Re: [bug#36955] [PATCH] machine: Add 'build-locally?' field for managed hosts. In-reply-to: <87imr9402l.fsf@sdf.lonestar.org> Date: Wed, 07 Aug 2019 15:20:59 -0400 Message-ID: <8736icpysk.fsf@dustycloud.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c02::f03c:91ff:feae:cb51 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: 36955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Looks good, though I assume this is a dependency for another patch that's coming? Jakob L. Kreuze writes: > * gnu/machine/ssh.scm (machine-ssh-configuration-build-locally?): New > variable. > (managed-host-remote-eval): Pass 'build-locally?' to 'remote-eval'. > --- > gnu/machine/ssh.scm | 26 ++++++++++++++++---------- > 1 file changed, 16 insertions(+), 10 deletions(-) > > diff --git a/gnu/machine/ssh.scm b/gnu/machine/ssh.scm > index ae312597dd..1f16d9a5ea 100644 > --- a/gnu/machine/ssh.scm > +++ b/gnu/machine/ssh.scm > @@ -47,6 +47,7 @@ > machine-ssh-configuration > > machine-ssh-configuration-host-name > + machine-ssh-configuration-build-locally? > machine-ssh-configuration-port > machine-ssh-configuration-user > machine-ssh-configuration-session)) > @@ -69,15 +70,17 @@ > make-machine-ssh-configuration > machine-ssh-configuration? > this-machine-ssh-configuration > - (host-name machine-ssh-configuration-host-name) ; string > - (port machine-ssh-configuration-port ; integer > - (default 22)) > - (user machine-ssh-configuration-user ; string > - (default "root")) > - (identity machine-ssh-configuration-identity ; path to a private key > - (default #f)) > - (session machine-ssh-configuration-session ; session > - (default #f))) > + (host-name machine-ssh-configuration-host-name) ; string > + (build-locally? machine-ssh-configuration-build-locally? > + (default #t)) > + (port machine-ssh-configuration-port ; integer > + (default 22)) > + (user machine-ssh-configuration-user ; string > + (default "root")) > + (identity machine-ssh-configuration-identity ; path to a private key > + (default #f)) > + (session machine-ssh-configuration-session ; session > + (default #f))) > > (define (machine-ssh-session machine) > "Return the SSH session that was given in MACHINE's configuration, or create > @@ -103,7 +106,10 @@ one from the configuration's parameters if one was not provided." > "Internal implementation of 'machine-remote-eval' for MACHINE instances with > an environment type of 'managed-host." > (maybe-raise-unsupported-configuration-error machine) > - (remote-eval exp (machine-ssh-session machine))) > + (remote-eval exp (machine-ssh-session machine) > + #:build-locally? > + (machine-ssh-configuration-build-locally? > + (machine-configuration machine)))) > > > ;;;