Virtual Machine Manager (virt-manager)

Done

Details

8 participants

Brice Waegeneire
Chris Marusich
Efraim Flashner
Christopher Baines
Tobias Geerinckx-Rice
Raghav Gururajan
Miguel Arruga Vivas
Raghav Gururajan

Owner: unassigned

Submitted by: Raghav Gururajan

Severity: important

Raghav Gururajan wrote on 13 Jul 2019 07:06

Recipients:(address . bug-guix@gnu.org)

Message-ID:255adc32694ef0c22fb789b1eea66a243cffb649.camel@disroot.org

Hello Guix!

Unable to create any VMs by installing from any ISO file.

The virt-manager gives out the following error:

Unable to complete install: 'Unable to read from
'/sys/fs/cgroup/unified/machine/cgroup.controllers': No such file or
directory'

Traceback (most recent call last):
  File "/gnu/store/r2l62bg0ayh22pkgs0jm9ig8q8n7daql-virt-manager-
2.1.0/share/virt-manager/virtManager/asyncjob.py", line 75, in
cb_wrapper
    callback(asyncjob, *args, **kwargs)
  File "/gnu/store/r2l62bg0ayh22pkgs0jm9ig8q8n7daql-virt-manager-
2.1.0/share/virt-manager/virtManager/create.py", line 2122, in
_do_async_install
    guest.installer_instance.start_install(guest, meter=meter)
  File "/gnu/store/r2l62bg0ayh22pkgs0jm9ig8q8n7daql-virt-manager-
2.1.0/share/virt-manager/virtinst/installer.py", line 415, in
start_install
    doboot, transient)
  File "/gnu/store/r2l62bg0ayh22pkgs0jm9ig8q8n7daql-virt-manager-
2.1.0/share/virt-manager/virtinst/installer.py", line 358, in
_create_guest
    domain = self.conn.createXML(install_xml or final_xml, 0)
  File "/gnu/store/kcdnna2613in9xfm9gxjqvkisdns911v-python-libvirt-
5.5.0/lib/python3.7/site-packages/libvirt.py", line 3840, in createXML
    if ret is None:raise libvirtError('virDomainCreateXML() failed',
conn=self)
libvirt.libvirtError: Unable to read from
'/sys/fs/cgroup/unified/machine/cgroup.controllers': No such file or
directory

Regards,
RG.

Raghav Gururajan wrote on 13 Jul 2019 07:17

severity 36634 important

Recipients:(address . control@debbugs.gnu.org)

Message-ID:fc593336b3edab01805d76d8dcfd70fdf99f91d6.camel@disroot.org

severity 36634 important

Efraim Flashner wrote on 14 Jul 2019 14:42

Re: bug#36634: Virtual Machine Manager (virt-manager)

Recipients:(name . Raghav Gururajan)(address . rvgn@disroot.org)(address . 36634@debbugs.gnu.org)

Message-ID:20190714124254.GC22158@macbook41

On Sat, Jul 13, 2019 at 01:06:55AM -0400, Raghav Gururajan wrote:

Toggle quote (38 lines)> Hello Guix!
> 
> Unable to create any VMs by installing from any ISO file.
> 
> The virt-manager gives out the following error:
> 
> Unable to complete install: 'Unable to read from
> '/sys/fs/cgroup/unified/machine/cgroup.controllers': No such file or
> directory'
> 
> Traceback (most recent call last):
>   File "/gnu/store/r2l62bg0ayh22pkgs0jm9ig8q8n7daql-virt-manager-
> 2.1.0/share/virt-manager/virtManager/asyncjob.py", line 75, in
> cb_wrapper
>     callback(asyncjob, *args, **kwargs)
>   File "/gnu/store/r2l62bg0ayh22pkgs0jm9ig8q8n7daql-virt-manager-
> 2.1.0/share/virt-manager/virtManager/create.py", line 2122, in
> _do_async_install
>     guest.installer_instance.start_install(guest, meter=meter)
>   File "/gnu/store/r2l62bg0ayh22pkgs0jm9ig8q8n7daql-virt-manager-
> 2.1.0/share/virt-manager/virtinst/installer.py", line 415, in
> start_install
>     doboot, transient)
>   File "/gnu/store/r2l62bg0ayh22pkgs0jm9ig8q8n7daql-virt-manager-
> 2.1.0/share/virt-manager/virtinst/installer.py", line 358, in
> _create_guest
>     domain = self.conn.createXML(install_xml or final_xml, 0)
>   File "/gnu/store/kcdnna2613in9xfm9gxjqvkisdns911v-python-libvirt-
> 5.5.0/lib/python3.7/site-packages/libvirt.py", line 3840, in createXML
>     if ret is None:raise libvirtError('virDomainCreateXML() failed',
> conn=self)
> libvirt.libvirtError: Unable to read from
> '/sys/fs/cgroup/unified/machine/cgroup.controllers': No such file or
> directory
> 
> Regards,
> RG.
> 

Checking my machine:
$ ls /sys/fs/cgroup/unified/
cgroup.controllers  cgroup.max.depth  cgroup.max.descendants  cgroup.procs  cgroup.stat  cgroup.subtree_control  cgroup.threads

-- 
Efraim Flashner   <efraim@flashner.co.il>   ????? ?????
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Raghav Gururajan wrote on 14 Jul 2019 23:21

Recipients:(name . Efraim Flashner)(address . efraim@flashner.co.il)(address . 36634@debbugs.gnu.org)

Message-ID:561b80a4c646b459685298aba7f55348b090069e.camel@disroot.org

Toggle quote (5 lines)

> Checking my machine:

> $ ls /sys/fs/cgroup/unified/

> cgroup.controllers cgroup.max.depth cgroup.max.descendants cgroup.

> procs cgroup.stat cgroup.subtree_control cgroup.threads

I get the same output for `ls /sys/fs/cgroup/unified/`. But as shown in
the error, the virt-manager is searching the directory
"/sys/fs/cgroup/unified/machine" (not "/sys/fs/cgroup/unified/"), which
does not exist. o.O

Regards,
RG.

Christopher Baines wrote on 21 Jul 2019 19:23

Recipients:(address . bug-guix@gnu.org)

Message-ID:87sgqze1yq.fsf@cbaines.net

Raghav Gururajan <rvgn@disroot.org> writes:

Toggle quote (4 lines)

> libvirt.libvirtError: Unable to read from

> '/sys/fs/cgroup/unified/machine/cgroup.controllers': No such file or

> directory

So, I've experienced this too. Even though this is a cgroup thing, I'm

pretty sure this isn't an issue with Linux.

I've tried reverting the changes in [1], and that seems to solve the

issue. Unfortunately, I don't have any insight in to what's different

between the problematic 5.5.0 release, and the working 5.4.0 release.

1: 458fe419232844d2021608d20dcd8f6e095eb2b4

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=458fe419232844d2021608d20dcd8f6e095eb2b4

Raghav Gururajan wrote on 21 Jul 2019 23:42

Recipients:(address . 36634@debbugs.gnu.org)

Message-ID:00999c57af938c7946871d8c12c9aabeb28e12af.camel@disroot.org

Toggle quote (4 lines)

> So, I've experienced this too. Even though this is a cgroup thing,

> I'm

> pretty sure this isn't an issue with Linux.

I see.

Toggle quote (4 lines)

> I've tried reverting the changes in [1], and that seems to solve the

> issue. Unfortunately, I don't have any insight in to what's different

> between the problematic 5.5.0 release, and the working 5.4.0 release.

So, by reverting changes, do you mean you patched and made a new

commit?

Thank you!

Regards,

RG.

Raghav Gururajan wrote on 25 Jul 2019 11:46

ATTENTION REQUIRED

Recipients:(address . 36634@debbugs.gnu.org)

Message-ID:2427363bc3661f61734c5d908e5fcb0f57ab9ebc.camel@disroot.org

Hello Guix!

I posted the bug on libvirt mail list few days ago (https://www.redhat.

com/archives/libvir-list/2019-July/msg01309.html). It appears the bug

has now been fixed (https://github.com/libvirt/libvirt/commit/759bf903a

6c24a8efa25c7cf4b099d952eda9bd3).

Could anyone please update the libvirt package/service to this latest

build?

Thank you!

Regards,

RG.

Tobias Geerinckx-Rice wrote on 25 Jul 2019 21:36

Recipients:(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)(address . 36634@debbugs.gnu.org)

Message-ID:1564083383.28412.1@submission.tobias.gr

Raghav,

On Thu, Jul 25, 2019 at 11:46 AM, Raghav Gururajan

<raghavgururajan@disroot.org> wrote:

Toggle quote (12 lines)> Hello Guix!
> 
> I posted the bug on libvirt mail list few days ago 
> (https://www.redhat.
> com/archives/libvir-list/2019-July/msg01309.html). It appears the bug
> has now been fixed 
> (https://github.com/libvirt/libvirt/commit/759bf903a
> 6c24a8efa25c7cf4b099d952eda9bd3).
> 
> Could anyone please update the libvirt package/service to this latest
> build?

I will do so swiftly since I updated libvirt to the 'broken' version

(although I never had any troubles like yours). Thank you for

reporting this upstream.

A personal note: I find this new wave of 'ATTENTION REQUIRED' messages

quite the opposite of motivating and pleasant. I'm honestly not sure

what result you expect from them. I fear it may backfire.

You are very welcome to contribute patches yourself! I don't mean

'patches or GTFO', I mean 'please dive in, the water's great'. The

reviewers don't bite. You don't need to be a programmmer; I'm not.

You've been part of our discussions for a while, you obviously care

about Guix and Free software, and particularly about certain Gnome and

'desktop-demographic' packages that are clearly under-maintained or

even missing because we're missing people like you. Learning to create

and maintain them yourself is hardly more work than trying to herd

volunteers like this -- and a hell of a lot more fun.

Kind regards,

T G-R

Tobias Geerinckx-Rice wrote on 25 Jul 2019 22:01

Recipients:(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)(address . 36634-done@debbugs.gnu.org)

Message-ID:878sslj33p.fsf@nckx

Tobias Geerinckx-Rice ???

Toggle quote (9 lines)

>> Could anyone please update the libvirt package/service to this

>> latest

>> build?

> I will do so swiftly since I updated libvirt to the 'broken'

> version

> (although I never had any troubles like yours). Thank you for

> reporting this upstream.

I have applied ‘your’ patch in

41097b2dee9367974c6dd16ac1ba2ee945457237.

I'm closing this bug for now. However, could you update and

confirm that this actually solves the problem?

Kind regards,

T G-R

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXToKigAKCRANsP+IT1Vt

eQT+AQDmK8iNSDoQqPTtqf8FTgN4fnfgGP5uf6K+AzYwpQBjDwD/ZcrCB3lteMft

PXy1fY0NQJ+0V9rhN1KK4loarhkcAgQ=

=cX5V

-----END PGP SIGNATURE-----

Closed

Raghav Gururajan wrote on 26 Jul 2019 05:47

Re: bug#36634

Recipients:(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)(address . 36634@debbugs.gnu.org)

Message-ID:024c3fdf57fa1cc35602868f71c55ebafd288293.camel@disroot.org

Toggle quote (4 lines)

> I will do so swiftly since I updated libvirt to the 'broken' version

> (although I never had any troubles like yours). Thank you for

> reporting this upstream.

About that, it appears I misunderstood the patch. That recent build was

not to fix the bug I reported. Anyway, I have been told by one of the

libvirt maintainers (pavel) that they are working on a fix for the bug

I reported.

So once I come to know about the new patch, I will update you and this

mail list. :)

Toggle quote (6 lines)

> A personal note: I find this new wave of 'ATTENTION REQUIRED'

> messages

> quite the opposite of motivating and pleasant. I'm honestly not

> sure

> what result you expect from them. I fear it may backfire.

Yeah, sorry about that. It was not intentional. I thought that sending
replies directly to `#bug@debbugs.gnu.org` will not use the subject
line, so just went with something top of my head. I will defer to do
this, moving forward. :)

Regards,
RG.

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEamFiplxUWgy2NgJiorDiYAVcMdsFAl06d7kACgkQorDiYAVc

Mdulfwf/Vg8YY8rZtATFZtzXIM1EGaRwpb8fHvfJmwL5ZVHQuM/J973tGubt/yKr

e8fzAVxM3Ef4iOzGplPF9TWiRUehoeV2UZ9AGQa3AsyWD3YbuRCnIn9y6i3yv03Z

WI4x2xmKdba/OfC3nlLxn0BixL1oKyqkg5fUUYhDCUD7+SzLKMiZNALbBFRV0MtS

npO4Js0fM1tN9w8gv0POJQlwMBvPT0Rq72EWffIYWE3CBZQrtgLyjl99AHMqAd6K

gdtkbZLDk864+bq71iLWsZfSU9lwRdc6FgBHhwiaYyNKpHX5eXGbaK9IR60uEciD

JQY+/6cdcloowAc6c9V5Nb7F8YQlHg==

=vWfp

-----END PGP SIGNATURE-----

Raghav Gururajan wrote on 26 Jul 2019 05:51

Recipients:(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)(address . 36634-done@debbugs.gnu.org)

Message-ID:4c27f6501096faf71c51295761413936b11aad73.camel@disroot.org

Toggle quote (6 lines)

> I have applied ‘your’ patch in

> 41097b2dee9367974c6dd16ac1ba2ee945457237.

> I'm closing this bug for now. However, could you update and

> confirm that this actually solves the problem?

Oh Shoot! I just saw your previous reply and replied to it. Sorry for

the delay. Anyway that patch fixes something, so good.

You do not have to close the bug. I will update this mail list once I

receive the correct patch. :)

Regards,

RG.

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEamFiplxUWgy2NgJiorDiYAVcMdsFAl06eNUACgkQorDiYAVc

MdvVNQf/cJg27tfIK/PXB912EgDvLZaUIAdSAWJkhrte33dClEh3d/xYpaR3OtYW

BoRgW26paVVJ3yGEteAjR0s/m6WvS0UumxrMU7ZOhT72k4dQnqRFvAiDE5CUCq/T

lkYSNC9yW1xq8w3cUr6/rja3hGNJ00H9eOzwhyDXtnQOCBrmXSihtKVufv2TtZON

yJZ0MDzIwDsOKVR7Owero0ALU8KqXSyZPwj2LEcY82quSiV5I3HOJBrus404oyji

67ZBMlJDolfs07ZR9lUcbHmKaiLFLNB3JKnGLEqEZRoqwGDUG1i+vm2YG13jjVHV

ORNCStIkDXu4/n+bzZgAM6Pi3QtS7A==

=TM3B

-----END PGP SIGNATURE-----

Closed

Christopher Baines wrote on 8 Sep 2019 20:14

Re: bug#36634: Virtual Machine Manager (virt-manager)

Recipients:(address . 36634@debbugs.gnu.org)

Message-ID:87lfuyodt7.fsf@cbaines.net

As version 5.7.0 has been released, I tried updating to that. There
seems to be some issue with the configuration for the socket file, but
even avoiding that, it doesn't seem to resolve the issue with the
cgroups.

For now, I've switched more permanently back to 5.4.0.

Chris Marusich wrote on 23 Sep 2019 06:14

Recipients:(name . Christopher Baines)(address . mail@cbaines.net)

Message-ID:87wodzir88.fsf@gmail.com

Christopher Baines <mail@cbaines.net> writes:

Toggle quote (16 lines)> Raghav Gururajan <rvgn@disroot.org> writes:
>
>> libvirt.libvirtError: Unable to read from
>> '/sys/fs/cgroup/unified/machine/cgroup.controllers': No such file or
>> directory
>
> So, I've experienced this too. Even though this is a cgroup thing, I'm
> pretty sure this isn't an issue with Linux.
>
> I've tried reverting the changes in [1], and that seems to solve the
> issue. Unfortunately, I don't have any insight in to what's different
> between the problematic 5.5.0 release, and the working 5.4.0 release.
>
> 1: 458fe419232844d2021608d20dcd8f6e095eb2b4
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=458fe419232844d2021608d20dcd8f6e095eb2b4

This bug is consistently reproducible. I've found an upstream bug

report that is very similar to what we're seeing here, so I've left a

comment telling the libvirt maintainers that Guix is also seeing a

In the meantime, should we revert to version 5.4.0 in Guix? I'm not

sure if there are any security vulnerabilities between 5.4.0 and the

most recent release, but this bug is currently preventing me from

creating any VMs at all in Guix using virt-manager, which is pretty bad.

Chris

Tobias Geerinckx-Rice wrote on 23 Sep 2019 06:30

Recipients:

Message-ID:87y2yf1vop.fsf@nckx

Chrisen,

Chris Marusich ???

Toggle quote (9 lines)

> In the meantime, should we revert to version 5.4.0 in Guix? I'm

> not

> sure if there are any security vulnerabilities between 5.4.0 and

> the

> most recent release, but this bug is currently preventing me

> from

> creating any VMs at all in Guix using virt-manager, which is

> pretty bad.

Yes! (which is why I originally updated this package):

v5.5.0 (2019-07-02)

Security

api: Prevent access to several APIs over read-only

connections

Certain APIs give root-equivalent access to the host,

and as

such should be limited to privileged

users. CVE-2019-10161,

CVE-2019-10166, CVE-2019-10167, CVE-2019-10168.

� https://libvirt.org/news.html

It might be easy to backport. I didn't try, and I no longer use

libvirt myself.

What's weird (maybe; I haven't kept up with the thread) is that I

used libvirt 5.5.0 (and yes, it was 5.5.0) for a while without

problems. I don't remember whether I created any *new* VMs,

though.

Kind regards,

T G-R

Chris Marusich wrote on 5 Oct 2019 07:41

Recipients:(name . Christopher Baines)(address . mail@cbaines.net)

Message-ID:87lftzd9zx.fsf@gmail.com

Chris Marusich <cmmarusich@gmail.com> writes:

Toggle quote (7 lines)

> This bug is consistently reproducible. I've found an upstream bug

> report that is very similar to what we're seeing here, so I've left a

> comment telling the libvirt maintainers that Guix is also seeing a

> similar issue:

> https://bugzilla.redhat.com/show_bug.cgi?id=1751120

Upstream has made a patch, which supposedly fixes the issue on Fedora
systems.  However, I applied it to a local checkout of Guix and tested
it, but it didn't fix the issue for me.  Perhaps that upstream bug and
this bug are slightly different?  Anyway, I've updated the upstream bug
report with information that hopefully will be useful to them.  We'll
see how it goes.

-- 
Chris

Chris Marusich wrote on 10 Oct 2019 10:55

Recipients:(name . Christopher Baines)(address . mail@cbaines.net)

Message-ID:87ftk1htdi.fsf@gmail.com

Chris Marusich <cmmarusich@gmail.com> writes:

Toggle quote (3 lines)

> I've updated the upstream bug report with information that hopefully

> will be useful to them. We'll see how it goes.

The original upstream bug report has been closed, but it seems likely it

was for a different issue, since it didn't fix the issue in Guix. At

upstream's recommendation, I've opened a new bug report specifically for

this problem here:

https://bugzilla.redhat.com/show_bug.cgi?id=1760233

I've given them detailed instructions, and a pre-made Guix VM that

demonstrates the bug, which will hopefully help them investigate. Stay

tuned!

Chris

Miguel Arruga Vivas wrote on 21 Oct 2019 16:46

Recipients:

Message-ID:20191021164629.5a0ae2e0@gmail.com

Hi,

This bug can be easier to fix than we thought. :-D

As a workaround, you only have to execute:

$ sudo mkdir /sys/fs/cgroup/unified/{machine,system,user}

The folders should be created at libvirtd start, probably manually with

some extra cgroup magic that I don't understand yet, but this works

well and new machines can be created. I'll take a look this week into

the libvirtd service if nobody takes it first, as this is quite trivial.

Best regards,

Miguel

Miguel Arruga Vivas wrote on 27 Oct 2019 10:37

Recipients:

Message-ID:20191027103719.47a9f1ea@gmail.com

Hello again,

The two patches attached create the cgroup directory needed and remove

the warning for the ip binary missing. Still the following errors

are emitted to the log.

--------------------8<-------------------

error : virConnectGetCPUModelNames:1109 : this function is not supported by the connection driver: virConnectGetCPUModelNames

error : virConnectGetAllDomainStats:11705 : this function is not supported by the connection driver: virConnectGetAllDomainStats

error : virCgroupSetValueRaw:473 : Unable to write to '/sys/fs/cgroup/unified/machine/qemu-1-Guix.libvirt-qemu/tasks': No such file or directory

error : virCgroupRemoveRecursively:2383 : Unable to remove /sys/fs/cgroup/unified/machine/qemu-1-Guix.libvirt-qemu/ (16)

-------------------->8-------------------

The last two may indicate there may be lurking another bug in the

cgroups configuration, but at least the machines can be created and

started/stopped seamlessly. What do you think?

Happy hacking!

Miguel

From a5dd055ea0fc20420cca6df2d38302596d397c49 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miguel=20=C3=81ngel=20Arruga=20Vivas?=
 <rosen644835@gmail.com>
Date: Sun, 27 Oct 2019 03:56:17 +0100
Subject: [PATCH 1/2] services: libvirtd: Create required control groups.

* gnu/services/virtualization.scm (libvirt-shepherd-service)
[libvirtd-activation]: New shepherd service.
[libvirtd]: Add a requirement of the new service.
---
 gnu/services/virtualization.scm | 11 +++++++++++
 1 file changed, 11 insertions(+)

Toggle diff (26 lines)diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualization.scm
index bc8ac9b40a..2f26945efd 100644
--- a/gnu/services/virtualization.scm
+++ b/gnu/services/virtualization.scm
@@ -428,8 +428,19 @@ potential infinite waits blocking libvirt."))
   (let* ((config-file (libvirt-conf-file config))
          (libvirt (libvirt-configuration-libvirt config)))
     (list (shepherd-service
+           ;; See https://libvirt.org/cgroups.html#currentLayoutGeneric
+           (documentation "Create the cgroup hierarchy required by libvirt.")
+           (provision '(libvirtd-activation))
+           (requirement '(file-system-/sys/fs/cgroup))
+           (one-shot? #t)
+           (start #~(lambda args
+                      (let ((path "/sys/fs/cgroup/unified/machine"))
+                        (or (access? path F_OK) (mkdir path)))))
+           (stop #~(lambda args #t)))
+          (shepherd-service
            (documentation "Run the libvirt daemon.")
            (provision '(libvirtd))
+           (requirement '(libvirtd-activation))
            (start #~(make-forkexec-constructor
                      (list (string-append #$libvirt "/sbin/libvirtd")
                            "-f" #$config-file)
-- 
2.23.0

From 24f7c06a47562f410ceb982a3b2a0d44980de392 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miguel=20=C3=81ngel=20Arruga=20Vivas?=
 <rosen644835@gmail.com>
Date: Sun, 27 Oct 2019 03:59:23 +0100
Subject: [PATCH 2/2] services: libvirtd: Provide ip binary at runtime.

* gnu/services/virtualization.scm (libvirt-shepherd-service): Add sbin to
the PATH variable, as ip binary is installed there.
---
 gnu/services/virtualization.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Toggle diff (20 lines)diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualization.scm
index 2f26945efd..488cd63041 100644
--- a/gnu/services/virtualization.scm
+++ b/gnu/services/virtualization.scm
@@ -444,9 +444,11 @@ potential infinite waits blocking libvirt."))
            (start #~(make-forkexec-constructor
                      (list (string-append #$libvirt "/sbin/libvirtd")
                            "-f" #$config-file)
+                     ;; For finding qemu and ip binaries.
                      #:environment-variables
-                     ;; For finding qemu binaries.
-                     '("PATH=/run/current-system/profile/bin")))
+                     (list (string-append
+                            "PATH=/run/current-system/profile/bin:"
+                            "/run/current-system/profile/sbin"))))
            (stop #~(make-kill-destructor))))))
 
 (define libvirt-service-type
-- 
2.23.0

Chris Marusich wrote on 7 Nov 2019 09:44

Recipients:(name . Miguel Arruga Vivas)(address . rosen644835@gmail.com)

Message-ID:87a798xeho.fsf@gmail.com

Hi Miguel,

Miguel Arruga Vivas <rosen644835@gmail.com> writes:

Toggle quote (17 lines)> Hello again,
>
> The two patches attached create the cgroup directory needed and remove
> the warning for the ip binary missing.  Still the following errors
> are emitted to the log. 
>
> --------------------8<-------------------
> error : virConnectGetCPUModelNames:1109 : this function is not supported by the connection driver: virConnectGetCPUModelNames
> error : virConnectGetAllDomainStats:11705 : this function is not supported by the connection driver: virConnectGetAllDomainStats
> error : virCgroupSetValueRaw:473 : Unable to write to '/sys/fs/cgroup/unified/machine/qemu-1-Guix.libvirt-qemu/tasks': No such file or directory
> error : virCgroupRemoveRecursively:2383 : Unable to remove /sys/fs/cgroup/unified/machine/qemu-1-Guix.libvirt-qemu/ (16) 
> -------------------->8-------------------
>
> The last two may indicate there may be lurking another bug in the
> cgroups configuration, but at least the machines can be created and
> started/stopped seamlessly.  What do you think?

With the patch you submitted upstream (not the patches you attached to

your previous email here), I can confirm the issue is fixed for me, and

that I do NOT observe the errors you mentioned above.

I see the patch was incorporated into Guix master in commit

aa1f0896fb15a0bdcc5474839c8afdbb2520d603. That is good, and I think

this issue can be resolved. If nobody follows up in a few days' time,

let's close the bug report.

Regarding your other patch in this thread to find the "ip" program at

run-time, could you open a new bug report or patch (via

guix-patches@gnu.org) for that? It seems unrelated to the issue at

hand.

Thank you for your help,

Chris

Miguel Arruga Vivas wrote on 8 Nov 2019 01:53

Recipients:(name . Chris Marusich)(address . cmmarusich@gmail.com)

Message-ID:20191108015105.354ef1c4@gmail.com

Hi Chris,

Chris Marusich <cmmarusich@gmail.com> writes:

Toggle quote (4 lines)

> With the patch you submitted upstream (not the patches you attached to

> your previous email here), I can confirm the issue is fixed for me,

> and that I do NOT observe the errors you mentioned above.

Sorry, I did not send the email here.

Toggle quote (5 lines)

> I see the patch was incorporated into Guix master in commit

> aa1f0896fb15a0bdcc5474839c8afdbb2520d603. That is good, and I think

> this issue can be resolved. If nobody follows up in a few days' time,

> let's close the bug report.

I created 38032 on guix-patches and Ludo’ applied them.

Toggle quote (4 lines)

> Regarding your other patch in this thread to find the "ip" program at

> run-time, could you open a new bug report or patch (via

> guix-patches@gnu.org) for that?

It was included in that patchset and it was unrelated, yes. On

master it's commit 2dfb9ba406.

Toggle quote (2 lines)

> It seems unrelated to the issue at hand.

I've been using the patches now on master this week and I have a really

annoying problem: the mouse is drawn on top of the vm screen. This

one is unrelated too, so I should open a new bug, maybe to

virt-manager...

Toggle quote (2 lines)

> Thank you for your help,

Thank you too, as you reported upstream and provided a great test
environment, which will help them to test my solution or find better
ones. :)

Happy hacking!
Miguel

Brice Waegeneire wrote on 19 Mar 2020 11:06

(no subject)

Recipients:(address . 36634@debbugs.gnu.org)

Message-ID:76c4a36a5e46a15e32ecdc95d8189182@waegenei.re

Hello,

Toggle quote (8 lines)

> Chris Marusich <cmmarusich@gmail.com> writes:

>> I see the patch was incorporated into Guix master in commit

>> aa1f0896fb15a0bdcc5474839c8afdbb2520d603. That is good, and I think

>> this issue can be resolved. If nobody follows up in a few days' time,

>> let's close the bug report.

> I created 38032 on guix-patches and Ludo’ applied them.

Looks like this issue can be closed.

I can't reproduce the bug. Upstream fixed it in libvirt 5.10, so

we'll be able to remove Miguel's patch when we upgrade libvrit.

Brice.

Brice Waegeneire wrote on 23 Mar 2020 08:39

Close 36634

Recipients:(address . control@debbugs.gnu.org)

Message-ID:ed0ad8524ef90f196218b6e6d5a19f41@waegenei.re

# Bug author answer on IRC: 
http://logs.guix.gnu.org/guix/2020-03-23.log#083658
close 36634

Your comment

This issue is archived.

To comment on this conversation send an email to 36634@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 36634

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date