From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 01 07:29:26 2019 Received: (at 36011-done) by debbugs.gnu.org; 1 Jun 2019 11:29:26 +0000 Received: from localhost ([127.0.0.1]:37291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hX2CU-0007Vk-1Y for submit@debbugs.gnu.org; Sat, 01 Jun 2019 07:29:26 -0400 Received: from sonic310-57.consmr.mail.ir2.yahoo.com ([77.238.177.30]:41614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hX2CR-0007VT-VK for 36011-done@debbugs.gnu.org; Sat, 01 Jun 2019 07:29:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1559388556; bh=cqX6xtY+/ScGck0wLQTTtj6qhJe8VTelmV+cQNuwcLg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From:Subject; b=FjTonqARXj7l62SdyEW3lD+PgBzL2HTm2HFpVevJpzgpKxz9YRgcuVxEaFYErTPb4vm41nDjLadv06TfrYV5W5+qQZUMZV5T10iU5m+4XrCH9tNX786E9qQYhiuxV/9DsNZphx88izEuHw3mS/mqt1w9xyNuG3+pIxJLDNkpGEbGM3ySlztKzeKH2ThbejHnSBoHieK/kuLy+LVA8KloauQob4zOtBwjSPEFGQjRfo/JG05uYxN8d2gxh503lrhLI6g+2OQI2H2+qS2tEbxNAJcqS3CyQtEB4JQyRbXmVTwjOSnm74Kn+AMbYpYpkOupP7DOzaOsyYbYMiE9tHHxSg== X-YMail-OSG: pM.g0n0VM1mjO5We4rwPbymPCjMITQdadE8Qiw9.GAvtSAy8Wvh0ZPhlhZIzWvG CxEohQLznehisPNCxpNDpvo7Spi1cbHk4F2QQYje7O9x_BsAJLPpfpikMD5IFA_oYzEbKvrAXwGR 3ieERAZhmzeSHNNvtzPsMPCKAhepdmXXZMP6gSfkACsZSnJ4hzsax9tgZpRHDI2heAaA7USMYjN5 8NRBdIHn_syVwCofFGaKgjlG8mZKtutF6Kf6IGfBXlZBqs6ergXdhePcNcnjeOfa1artOvY9zrf3 nVpSiYXgwgl_PvoBkCmnlVi5JxP_EYa1FOtVjPeFy_xqdHaqqQRtIMAoPolmJGJnAS2v2TOisy7p 8stbNIEExhg2REDMIpCgNngyXWGGc5zsjGW9cEp765UFZLMkTPvc92zjuFVbGVTugQnUv50gWWl4 oCwI71v20gH5nIE4xLNCsW1.IcALR43_m.f8HnBMTr34jsHcpv5GD_uqQrwpQXbi1dIB.AeWbYFG Y8qEXUHrR4oy.jQtOFtawHPKeXHu_RAWBcBSdNL8iQN1XMm2LyIIl4Gbi8__HZ.rjv7ihMDjYSSC H16RksGcFr1xLwLrVffnHffeTxJfpMWUJ5u91wHw6KmpOY.uT2VBfCHKqUXqnd08DARZW3exKK1p drX3zjJboI68G2VQ6IIX1Tyy.bFIakttFXoSl8VvPD34sbtaNobZrVbYEoGDPrsK2JuQ9bhM95ky .crrgby6Zitbu6HsrMRmC2DXeKbWLh2S6L.0vshDIkkxUC1dyHxnq9mQ1BhiyfzosZcXJ1N2gzRK XgzVpj.89HNefxMtH0Kk51p3DyGqnTHcCJoqG8gxCfiMhLufv1.7Smukj89_jdcaLPTEb5bAl_DC OH3ctmjoOu3fdGN6mpViHc16bteCT29uBfWZzWy2PyS7p908hUgGhx9Inz.fS6RILnFmys.pKPb5 .b2Dk2Bdp55fVO2yQ.1Nbxw8nHQOdTecSyow3_7SWfXUhW4LOkesY8ZkYxhexGOV3wMcJpn3rhMm n32tcqCvaBO7wyzVwi1Ivp6adMX4Clp_DJOkJ0Z4oxTfZSJoNed_WBIZ3Cly6jlS.ZlrHPmJP8xj WBF1EXByfzMauF7mPgfQ7fK33OGPOSQI5x7Gem4YRm_XwirfN4hc1YvnKRUpB8Qtun7Sj3A1djm_ 0hLjCaliiPkBbrp_32VNLsq.IpvwZGmBkwMJZPsw5C6icDAPq8OlW4nW8I3aWrfnPxf2DavuEhB7 tIJdgIN1theCHxucu1pVyxxIQ4g-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Sat, 1 Jun 2019 11:29:16 +0000 Date: Sat, 1 Jun 2019 11:28:13 +0000 (UTC) From: Dumitrascu Vasile To: Kei Kebreau Message-ID: <1787374743.13222284.1559388493279@mail.yahoo.com> In-Reply-To: <874l5a2ebj.fsf@posteo.net> References: <20190530184933.14227-1-va511e@yahoo.com> <874l5a2ebj.fsf@posteo.net> Subject: Re: [bug#36011] [PATCH 1/2] gnu: gnucash: Update to 3.5. MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_13222283_1715462178.1559388493276" X-Mailer: WebService/1.1.13634 YMailNorrin Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Firefox/60.0 Content-Length: 3395 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36011-done Cc: 36011-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Dumitrascu Vasile Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ------=_Part_13222283_1715462178.1559388493276 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =20 =C2=A0 Hi Kei Thank you for the corrections and the merge, =C2=A0 Vasile =20 On Saturday, June 1, 2019, 5:07:51 AM GMT+2, Kei Kebreau wrote: =20 =20 Hi Vasile, The patch looks good overall, but the way the commit log is written is a bit off. It's mostly good though, so I've committed the patch myself with the changes mentioned below. Vasile Dumitrascu writes: > * gnu/packages/gnucash.scm (gnucash): Update to 3.5. > [source]: Remove uneeded patch. > * gnu/local.mk: Remove delete patch. The value modified within gnu/local.mk should be specified. In this case, the line would look line this: "* gnu/local.mk (dist_patch_DATA): Remove patch." Also, mention that you actually deleted the obsolete patch: "* gnu/packages/patches/gnucash-fix-test-transaction-failure.patch: Delete = file." Thanks for contributing! =20 ------=_Part_13222283_1715462178.1559388493276 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

  Hi Kei

Thank you for the corrections and the merge,

  Vasile


=20
=20
On Saturday, June 1, 2019, 5:07:51 AM GMT+2, Kei Kebrea= u <kkebreau@posteo.net> wrote:


Hi Vasile,

The patch looks good overall, but the way the commit log is writ= ten is a
bit off. It's mostly good though, so I've commit= ted the patch myself
with the changes mentioned below.

Vasile Dumitrascu <va511e@yaho= o.com> writes:

> * gnu/packa= ges/gnucash.scm (gnucash): Update to 3.5.
> [source]: = Remove uneeded patch.
> * gnu/local.mk: Remove delete = patch.


The value modified within= gnu/local.mk should be specified. In this
case, the line= would look line this:
"* gnu/local.mk (dist_patch_DATA):= Remove patch."

Also, mention that you= actually deleted the obsolete patch:
"* gnu/packages/pat= ches/gnucash-fix-test-transaction-failure.patch: Delete file."

Thanks for contributing!

<= /div>
------=_Part_13222283_1715462178.1559388493276--