From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 29 17:13:49 2018 Received: (at 32524) by debbugs.gnu.org; 29 Aug 2018 21:13:49 +0000 Received: from localhost ([127.0.0.1]:37534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fv7me-0005Oi-G9 for submit@debbugs.gnu.org; Wed, 29 Aug 2018 17:13:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fv7mc-0005OS-8n for 32524@debbugs.gnu.org; Wed, 29 Aug 2018 17:13:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fv7mV-0000we-GT for 32524@debbugs.gnu.org; Wed, 29 Aug 2018 17:13:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fv7mV-0000wR-8F; Wed, 29 Aug 2018 17:13:39 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=44520 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fv7mU-0007nb-Vh; Wed, 29 Aug 2018 17:13:39 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Timothy Sample Subject: Re: bug#32524: guix system build bare-bones.scm fails with ahci shpchp References: <87a7pb3zqi.fsf@fastmail.com> <871sam6zyt.fsf@ngyro.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 12 Fructidor an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 29 Aug 2018 23:13:37 +0200 In-Reply-To: <871sam6zyt.fsf@ngyro.com> (Timothy Sample's message of "Sat, 25 Aug 2018 14:52:26 -0400") Message-ID: <8736uw7u66.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32524 Cc: Eric Brown , 32524@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hi, Timothy Sample skribis: > Eric Brown writes: > >> I am attempting to guix system reconfigure a GuixSD 0.15 (updated) >> Macintosh laptop where reconfigure recommends and requires: >> >> (initrd-modules (append (list "ahci" "shpchp") >> %base-initrd-modules)) >> >> However, the config file that I used at guix system init works >> originally with this additional bit of lisp, but a reconfigure gives the >> error below. >> >> In an attempt to narrow down, inserting this into bare-bones.scm gives a >> similar error. Thanks to samplet for help and confirmation on #guixsd. > > Just to make things clear, the bare-bones config below works with > Linux-Libre 4.17, but not with 4.18. We no longer build the =E2=80=9Dshp= chp=E2=80=9D > module. See commit 3004f1c69b258837b0e49a567787c97479ce6e71, which > includes the following: > > -CONFIG_HOTPLUG_PCI_SHPC=3Dm > +# CONFIG_HOTPLUG_PCI_SHPC is not set > > I don=E2=80=99t know anything about this module or this change, so I don= =E2=80=99t know > if we should change the config file or not. I will leave that to > someone more knowledgeable. I don=E2=80=99t know the rationale of this change, but I understand the pro= blem: it=E2=80=99s design issue with the module recommendation mechanism. Basica= lly it looks at modules needed on the current kernel for, say, your root file system, and then it recommends adding those. The problem occurs when you=E2=80=99re running on 4.17 and reconfiguring to= wards 4.18: on your system =E2=80=98shpchp=E2=80=99 is necessary, so =E2=80=98gui= x system=E2=80=99 recommends it, but on the target system it=E2=80=99s not. In that case =E2=80=98--ski= p-checks=E2=80=99 is needed. What we could do is determine that =E2=80=98shpchp.ko=E2=80=99 is not provi= ded by the target kernel, though that doesn=E2=80=99t tell us whether it=E2=80=99s nee= ded. Doing that also has the disadvantage that we must build/download the target kernel before we can emit the warning, as has been discussed before. Thoughts? Ludo=E2=80=99.