From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 21 17:28:06 2018 Received: (at 30894) by debbugs.gnu.org; 21 Mar 2018 21:28:06 +0000 Received: from localhost ([127.0.0.1]:46340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eylHB-0004Da-KI for submit@debbugs.gnu.org; Wed, 21 Mar 2018 17:28:05 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eylH8-0004DG-Hb for 30894@debbugs.gnu.org; Wed, 21 Mar 2018 17:28:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1521667672; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID; l=2841; bh=XkwlPHEDwPlea/GMgV7BpsEEJwPw0ZYq93qpYJrdcME=; b=YqUUlNw8xGcaWopRZzszrcEPpeK+zuioZ1iK6z1hEr+UwGMnisSV+Diih34dRP+6 Gmptvy15eQ0R1zuGrIxygZ+30eQ84iB14CDneOJwlp3NbvRKQOH26lYwJAKIqb+f5Od 5ieiGuLgVxzmz6/QNj0P4UYFUtAtkEHivEagFpR0= Received: from localhost (port-92-200-42-42.dynamic.qsc.de [92.200.42.42]) by mx.zohomail.com with SMTPS id 1521667672301432.38300232694235; Wed, 21 Mar 2018 14:27:52 -0700 (PDT) References: <071fa29f-107d-2097-586c-ce2f1eb91c23@swecha.net> User-agent: mu4e 1.0; emacs 25.3.1 From: Ricardo Wurmus To: Sahithi Yarlagadda Subject: Re: Submission of patch for Add r-abc In-reply-to: <071fa29f-107d-2097-586c-ce2f1eb91c23@swecha.net> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Wed, 21 Mar 2018 22:27:49 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID: <87tvt9azl6.fsf@elephly.net> X-ZohoMailClient: External X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30894 Cc: 30894@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi Sahithi, > I am submitting a patch for r-abc. Please review. Thank you for the patch! What follows is a short review that includes things I could change myself before applying the patch, but for the sake of learning I explicitly point out in this message. I hope you don=E2=80=99t mind that I= =E2=80=99m focusing on what may seem like minor details. > From 4b3b3eee4995616059d8a27489affc43cee26ea4 Mon Sep 17 00:00:00 2001 > From: Sahithi Yarlagadda > Date: Wed, 21 Mar 2018 16:30:18 +0530 > Subject: [PATCH] gnu: Add r-abc. > > * gnu/packages/cran.scm (r-abc): New variable. Nitpick: please don=E2=80=99t indent this line. The asterisk should be the first character in this line. > + > +(define-public r-abc > + (package > + (name "r-abc") > + (version "2.1") > + (source > + (origin > + (method url-fetch) > + (uri (cran-uri "abc" version)) > + (sha256 > + (base32 > + "0ngzaaz2y2s03fhngvwipmy4kq38xrmyddaz6a6l858rxvadrlhb")))) > + (build-system r-build-system) > + (propagated-inputs > + `(("r-abc-data" ,r-abc-data) > + ("r-locfit" ,r-locfit) > + ("r-mass" ,r-mass) > + ("r-nnet" ,r-nnet) > + ("r-quantreg" ,r-quantreg))) > + (home-page > + "http://cran.r-project.org/web/packages/abc") Please pull this onto the previous line and use =E2=80=9Chttps=E2=80=9D. > + (synopsis > + "Tools for approximate bayesian computation (ABC)") Please combine this line with the previous line. > + (description > + "Implements several ABC algorithms for performing parameter estima= tion, > +model selection, and goodness-of-fit. Cross-validation tools are also > +available for measuring the accuracy of ABC estimates, and to calculate = the > +misclassification probabilities of different models.") Please use full sentences. For CRAN packages the official description usually provides only a sentence fragment in place of the first sentence. Please also use =E2=80=9C@dfn{Approximate Bayesian Computation} (ABC)=E2=80=9D the first time =E2=80=9CABC=E2=80=9D is mentioned. All thoughout the indentation is a bit off (that=E2=80=99s expected as the importer is very simple and doesn=E2=80=99t know about the expected indentation). If you=E2=80=99re using Emacs you can easily adjust it with = M-C-q (also known as =E2=80=9Cindent-sexp=E2=80=9D); otherwise please use =E2=80=9Cetc/indent-code.el=E2=80=9D. Have you built this package with Guix? Finally, please rebase this patch so that it can be applied independently from the other patch you=E2=80=99ve sent, which cannot curren= tly be applied due to problems in building the defined package. Rebasing this patch ensures that it can be merged even if the other patch is stuck. Thanks! -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net