From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 20 04:47:26 2018 Received: (at 30806) by debbugs.gnu.org; 20 Dec 2018 09:47:26 +0000 Received: from localhost ([127.0.0.1]:55469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZuvO-0000CP-Ca for submit@debbugs.gnu.org; Thu, 20 Dec 2018 04:47:26 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:52709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZuvM-0000CG-L9 for 30806@debbugs.gnu.org; Thu, 20 Dec 2018 04:47:25 -0500 X-Originating-IP: 86.246.35.59 Received: from mimimi (lfbn-1-799-59.w86-246.abo.wanadoo.fr [86.246.35.59]) (Authenticated sender: mail@ambrevar.xyz) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id A0688240004; Thu, 20 Dec 2018 09:47:20 +0000 (UTC) References: <875zvqjjnl.fsf@gmail.com> <875zvpm6d3.fsf@cbaines.net> <87bm5g4k8r.fsf@gmail.com> User-agent: mu4e 1.0; emacs 26.1 From: Pierre Neidhardt To: Chris Marusich Subject: Re: Packaging Terraform, a Golang package In-reply-to: <87bm5g4k8r.fsf@gmail.com> Date: Thu, 20 Dec 2018 10:47:18 +0100 Message-ID: <87woo4zg0p.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30806 Cc: guix-devel@gnu.org, 30806@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > 1) Is it bad that our package definition isn't running "go generate" or > "go fmt"? Do you know if "go install" does this for us somehow? I > don't think "stringer" or "mockgen" are present in the build "go generate" is used to generate code, it's like a preprocessor. Most Go programs don't use it, but if they do, then it's needed. "go fmt" should not be part of the build process in my opinion. A code formatter fits better into a Git hook or something. > 2) After I ran "make" ad-hoc, I couldn't find a built "terraform" > executable anywhere. Where is it? Am missing something obvious, or > could it be that the official documentation incomplete and I need to ask > upstream for advice? I haven't looked into it, but it should be either in ~/go/bin or in the pac= kage source folder, something like ~/go/src/.../terraform/. > 3) The official instructions seem to arbitrarily choose to run the build > in parallel, using 4 threads, which means this package won't play nice > with build arguments like --cores. I suppose I might need to work with > upstream to fix that. I think Go decides this on its own. Off the top of my head, there is an environment variable to control the number of CPU threads used globally, GO_xxx_CORES or something like that. =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlwbZSYACgkQm9z0l6S7 zH+4+wgAqodcAcZ28ZHf8W9KaeUXwsffaoqr19e1Gixwc8enb2X61YyG/TZYUp/j ICfXe7xzjm8n4uKmSjYa8Te17bVR+tfEEDEq8wJoBBlCFS60kIXSFfGPw4qFPmm4 +0q4BB/CKmh75nmL6K2UYPwOViHHuSezd5mXk1CYbvA00KqFNw/+hz7DcNhK4XsB LkSxYSux5CwGaZdWYi8lRStBChkeIW52N4BurAj5CpGzG9KxJ70plF00bhq4paKM t8db2G+YR0cvE3STdf4GbZ+TYVBgat9BfnY7iOBh7Ju7nyjdJ+rvcaOj2LBLHccz 7IyAvZizAscQCJ2w6oWyksKSs2YUfQ== =ddux -----END PGP SIGNATURE----- --=-=-=--