From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 09 17:59:29 2018 Received: (at 30710-done) by debbugs.gnu.org; 9 Mar 2018 22:59:30 +0000 Received: from localhost ([127.0.0.1]:52926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euQz3-0006EF-MG for submit@debbugs.gnu.org; Fri, 09 Mar 2018 17:59:29 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:33994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euQz2-0006E7-Eu for 30710-done@debbugs.gnu.org; Fri, 09 Mar 2018 17:59:28 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id C6093FFCA; Fri, 9 Mar 2018 23:59:27 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZLwKyOvOMkEU; Fri, 9 Mar 2018 23:59:26 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 7B25A9D1B; Fri, 9 Mar 2018 23:59:26 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: =?utf-8?Q?Bj=C3=B6rn_H=C3=B6fling?= Subject: Re: bug#30710: guix graph gives duplicate nodes References: <86fb9895-768a-bea0-154c-070861c0bb1d@crazy-compilers.com> <87d10i8mpb.fsf@gnu.org> <87efkvsylg.fsf@gnu.org> <20180309110917.79b14a36@alma-ubu> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 19 =?utf-8?Q?Vent=C3=B4se?= an 226 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 09 Mar 2018 23:59:26 +0100 In-Reply-To: <20180309110917.79b14a36@alma-ubu> (=?utf-8?Q?=22Bj=C3=B6rn?= =?utf-8?Q?_H=C3=B6fling=22's?= message of "Fri, 9 Mar 2018 11:09:17 +0100") Message-ID: <87d10cyhwx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 30710-done Cc: 30710-done@debbugs.gnu.org, Hartmut Goebel X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Bj=C3=B6rn H=C3=B6fling skribis: > If you look into gnu/packages/autotools.scm, you see that > autoconf-wrapper is not a package, but a package-factory: > > (define* (autoconf-wrapper #:optional (autoconf autoconf)) > > Now the package definitions of "automake" and "libtool" each use the > same fragment of code in their native-inputs, but a different "package" > in the eq?-sense, although they basically want the same thing: > > `(("autoconf" ,(autoconf-wrapper)) > > As ludo stated above: "Most of the time, there=E2=80=99s exactly one pack= age > object for each derivation; if not, that=E2=80=99s usually a bug." > > This looks to me like a bug. > > Correction: > > (define autoconf-wrapper-default (autoconf-wrapper)) > > And then use this singular package as native-inputs to libtool and automa= ke. > > Furthermore, when I search: > > find . -name "*.scm" -exec grep -H "autoconf-wrapper" "{}" ";" | less > > I find about 10 packages that use the fabrik, but all in the default way. > > So instead of: > > #:export (autoconf-wrapper)) > > > We could just=20 > > (define-public autoconf-wrapper-default (autoconf-wrapper)) > > and use that. > > Or, if noone is using this fabrik, just drop that and make a normal packa= ge out of it. > > WDYT? Reopen this one? Good catch! I implemented what you suggest above in commit 464f5447396fcec9b43f7eab71d5d42b522a157f. Thank you! Ludo=E2=80=99.