From debbugs-submit-bounces@debbugs.gnu.org Wed May 10 15:32:01 2017 Received: (at 26830) by debbugs.gnu.org; 10 May 2017 19:32:01 +0000 Received: from localhost ([127.0.0.1]:37106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8XL7-0003mM-EM for submit@debbugs.gnu.org; Wed, 10 May 2017 15:32:01 -0400 Received: from mail.lassieur.org ([83.152.10.219]:58656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8XL5-0003lq-HL for 26830@debbugs.gnu.org; Wed, 10 May 2017 15:31:59 -0400 Received: from rodion (88.191.118.83 [88.191.118.83]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 10492aac (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Wed, 10 May 2017 19:31:58 +0000 (UTC) References: <87d1bjtlpd.fsf@lassieur.org> <86vapa6nyi.fsf@gmail.com> User-agent: mu4e 0.9.18; emacs 25.2.1 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur To: Mathieu Othacehe Subject: Re: bug#26830: Allow services to implement a 'reload' action In-reply-to: <86vapa6nyi.fsf@gmail.com> Date: Wed, 10 May 2017 21:31:58 +0200 Message-ID: <87vap8h5jl.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26830 Cc: 26830@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Mathieu Othacehe writes: >> Services do not have to implement 'reload' and if, say, foo-daemon >> doesn't implement it, 'herd reload foo-daemon' will return 1 and display >> a message saying that foo-deamon does not have an action 'reload'. >> That's the reason of the #f default value. >> >> WDYT? > > Your whole serie LGTM for me ! Hi Mathieu, thanks for reviewing :) > I have just one small concern, there is a already a "reload" action on > shepherd root service. > > For instance you can call "herd reload root conf.scm". > > Maybe it will be unclear for users how reload action differs on root > service where it takes an argument and guix services where it does not. They don't differ: 'root' is just another service, as 'nginx' is. Our 'reload' action can handle many arguments as well. The only tiny difference is that the 'root' service is implemented by Shepherd, not by Guix. > You could maybe mention that in the documentation and/or in the code ? Sure, I updated the documentation. I had forgotten the "Shepherd Services" part and I think it helps understanding. But I didn't talk about the 'root' service because it is a Shepherd thing and is already described in the Shepherd manual. WDYT?