From debbugs-submit-bounces@debbugs.gnu.org Tue May 09 11:36:54 2017 Received: (at 26830) by debbugs.gnu.org; 9 May 2017 15:36:54 +0000 Received: from localhost ([127.0.0.1]:34333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d87C2-0004tN-BA for submit@debbugs.gnu.org; Tue, 09 May 2017 11:36:54 -0400 Received: from mail-wr0-f179.google.com ([209.85.128.179]:34047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d87C0-0004tA-TV for 26830@debbugs.gnu.org; Tue, 09 May 2017 11:36:53 -0400 Received: by mail-wr0-f179.google.com with SMTP id l9so4219816wre.1 for <26830@debbugs.gnu.org>; Tue, 09 May 2017 08:36:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=+FqjVdSDiQg5DSEy5xHQx2VXOlyOVxOV3qKl7i4GO28=; b=qJ2x/Hmn0tO7HPk4Bf5ISnFnG6xn5fwTLPHEjFTRyNGwl50km5iDXplUyzUY950a6W dU7fLm0VwA4gRAirocgsJEHNHUHUHrgeMuKt3t8fbkCrY0NrDEwaWPZG57TSCkEbA+6H rjFkLW/LhtYM1xE0+QctX6FTM3a9Y7svwaQnJ/bxWiNaRTD5pa6WDz6T9e5ClCVpz1MS KcjyRahk9Ref0hWRKX0hhZa4cBcPb5zYpPlm/abAiu22OSlzesQqqWLJr8nUP+zxjObZ I0nBRpGZx8dHsUu8ySpiuUQYBRu6OIX+gymPNtFmebLOLI7bXSmdi/w3lOIYN4p8QnHm Shgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=+FqjVdSDiQg5DSEy5xHQx2VXOlyOVxOV3qKl7i4GO28=; b=SNk2r0UPpr0SNPj4nID6mj99VLgMVkvhRs0EWoPqNqIKG4FgK17fQWQHek4lalTwUR ywSfulC8/FBV1BGzOYAmxPX2L32XWlXFhFasZCoCxIaEKQEd4Euesi8rO/gXH/EsCuNn DZ3L8RhzxoqnHPt0SNj8RaC1hrc19mdo4z2X33GL7ASvH8xM8GteqBvu/ATKXyrTIgIP 0rVWWdYvDbSkmndGva1LKy7m1VR/WnFydNLkqQEKY+1HQrG+Y9RMqPqOnjYnVUcuwLbY mCdq54BaHcVnMa2g4hXnXktDLuA1G2qU5A9xVXrYA8lOCetuNHoMep95wdQ+UeZw+bAa qIlQ== X-Gm-Message-State: AODbwcB2YG8kXxtORsq2PQL1RjBxrCgm5gRdQPd3spYdeSOAZeU3Abp8 wnMJtEutLXQo+A== X-Received: by 10.28.238.20 with SMTP id m20mr549330wmh.121.1494344207128; Tue, 09 May 2017 08:36:47 -0700 (PDT) Received: from zbook ([46.218.109.88]) by smtp.gmail.com with ESMTPSA id v52sm255703wrc.53.2017.05.09.08.36.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 May 2017 08:36:46 -0700 (PDT) References: <87d1bjtlpd.fsf@lassieur.org> User-agent: mu4e 0.9.18; emacs 25.2.1 From: Mathieu Othacehe To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: bug#26830: Allow services to implement a 'reload' action In-reply-to: <87d1bjtlpd.fsf@lassieur.org> Date: Tue, 09 May 2017 17:37:25 +0200 Message-ID: <86vapa6nyi.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26830 Cc: 26830@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi Clément, > Services do not have to implement 'reload' and if, say, foo-daemon > doesn't implement it, 'herd reload foo-daemon' will return 1 and display > a message saying that foo-deamon does not have an action 'reload'. > That's the reason of the #f default value. > > WDYT? Your whole serie LGTM for me ! I have just one small concern, there is a already a "reload" action on shepherd root service. For instance you can call "herd reload root conf.scm". Maybe it will be unclear for users how reload action differs on root service where it takes an argument and guix services where it does not. You could maybe mention that in the documentation and/or in the code ? Thanks, Mathieu