From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 20 08:39:59 2020 Received: (at 26489) by debbugs.gnu.org; 20 Dec 2020 13:39:59 +0000 Received: from localhost ([127.0.0.1]:43878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqywJ-0004LH-8i for submit@debbugs.gnu.org; Sun, 20 Dec 2020 08:39:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqywH-0004L4-30 for 26489@debbugs.gnu.org; Sun, 20 Dec 2020 08:39:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46418) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqywB-0003B1-MV; Sun, 20 Dec 2020 08:39:51 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=34150 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kqywB-0001z5-6w; Sun, 20 Dec 2020 08:39:51 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: zimoun Subject: Re: bug#26489: [PATCH] substitute: Ignore bad responses. References: <20170414002755.32672-1-me@tobias.gr> <87lgr3gvqf.fsf@gnu.org> <87o9vc3eij.fsf@gnu.org> <861rfmvpdn.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 30 Frimaire an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 20 Dec 2020 14:39:48 +0100 In-Reply-To: <861rfmvpdn.fsf@gmail.com> (zimoun's message of "Fri, 18 Dec 2020 21:19:16 +0100") Message-ID: <87o8io8ul7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26489 Cc: 26489@debbugs.gnu.org, Tobias Geerinckx-Rice X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, zimoun skribis: > On Mon, 01 May 2017 at 15:14, ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >>> I think throwing an unhandled exception is definitely the wrong thing to >>> do here =E2=80=94 this kills even =E2=80=98guix --keep-going --fallback= =E2=80=99. I'm less sure >>> about the right place to do it >> >> Oh right, if that kills --fallback, that=E2=80=99s a problem. >> >> Back to your initial patch, what about moving =E2=80=98bad-response=E2= =80=99 handling to >> the call site of =E2=80=98http-multiple-get=E2=80=99 instead of having i= t in >> =E2=80=98http-multiple-get=E2=80=99? (That way, =E2=80=98http-multiple-= get=E2=80=99 would behave like >> =E2=80=98http-get=E2=80=99 in this respect.) >> >> Upon a =E2=80=98bad-response=E2=80=99, =E2=80=98fetch-narinfos=E2=80=99 = would return #f or the empty >> list or the partial narinfo list it has built so far. >> >> WDYT? >> >> I=E2=80=99d be happy with a patch along these lines! > > Tobias, do you plan to rework/rebase it? In the meantime, commit 5ff521452b9ec2aae9ed8e4bb7bdc250a581f203 added =E2=80=98bad-response=E2=80=99 handling (and more). We should take a close= r look, but it may be that this issue is now addressed. Ludo=E2=80=99.