From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 18 15:24:52 2020 Received: (at 26489) by debbugs.gnu.org; 18 Dec 2020 20:24:52 +0000 Received: from localhost ([127.0.0.1]:40081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqMJ1-0005aS-Th for submit@debbugs.gnu.org; Fri, 18 Dec 2020 15:24:52 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:46118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqMIz-0005aC-TM for 26489@debbugs.gnu.org; Fri, 18 Dec 2020 15:24:50 -0500 Received: by mail-wr1-f41.google.com with SMTP id d13so3595277wrc.13 for <26489@debbugs.gnu.org>; Fri, 18 Dec 2020 12:24:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=B6LDpXmEHMBkPF4MgZFEF6pYxooAgbAPjD8M0J6/wIA=; b=AbGzwUbYGmEhF2sWhia81bBw2Ah1zTgKcELbb1wotl7KubL/ANfYv0nnseEDWWTET5 QtW1mhu2DtEPRGhnX66A4/1W/D4ADkP5P2f2/XcAIUoMyLTn11t8IPx5O/bDt3FT006Z 6a/jOoSWv4ilG6iWM0sHGYmFsYau8ZX6CtwEzxjsf4tNk5bneoPXmoxy4b9zs+nvMDQ1 lURH51XvWM97obLTPqNs8Zbs5mvAqsXbLmMPb89FDFdVKLy4/8Uv1dOzOcesenuhxQ24 mroPfyYIaLVSV4SlVKi//zNLX7CCREH+k12IXDgDtxfdRk2D79Ic7EOFCDA+V0dqB32t ourQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=B6LDpXmEHMBkPF4MgZFEF6pYxooAgbAPjD8M0J6/wIA=; b=hOOq/eDQZUCELHvUxZAn1gBR7ldaCL7p3PymjzH1wZ7f0JfUe37m+IBXUvNijKfv+J zd6g9U3AEJYNmyqB4s3XgU68g2c4zj0nyKuxTZ58bO30VcuCABqsgrQ/Xn8nzQ0sAMix Gm0BUsxNeAuDYy/O9a67vnDevuWFLVXrO15EYDrEWSJ4N/ChdkIbUosXsnyHoYImWYE3 cUG4KcvQK1PYRXE4/+3de9pHJ2K3fCoXjolbd2ZZNz9QDNfWzWBqjH211vRe3k+58sOo lR6OpTcWxCVEDHJn/6uXD3mDdq6C2abVV4F6SqD0wegPAghX/me67Cqw6pKZI68VqYzf tr5w== X-Gm-Message-State: AOAM533n110RLjiBxeXFRx+pwF+f6gHN/a38DcPbIxUO1vd5BqMuCdfu i77FzRHeFVfCx4jMJKqXPJ8= X-Google-Smtp-Source: ABdhPJzHjZ5Hbmo6DzHQ76qXn6vLWEnspMd44lObwXc4LEy+EcU5c7K/0JzvisXpkFnlkULRgVC4Zg== X-Received: by 2002:a5d:4c4d:: with SMTP id n13mr6312344wrt.356.1608323084075; Fri, 18 Dec 2020 12:24:44 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id b19sm12199269wmj.37.2020.12.18.12.24.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Dec 2020 12:24:43 -0800 (PST) From: zimoun To: Tobias Geerinckx-Rice Subject: Re: bug#26489: [PATCH] substitute: Ignore bad responses. References: <20170414002755.32672-1-me@tobias.gr> <87lgr3gvqf.fsf@gnu.org> <87o9vc3eij.fsf@gnu.org> Date: Fri, 18 Dec 2020 21:19:16 +0100 In-Reply-To: <87o9vc3eij.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 01 May 2017 15:14:44 +0200") Message-ID: <861rfmvpdn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26489 Cc: 26489@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Tobias, Your patch #26489 sent a couple of years ago since lost in the vacuum of the crazy Debbugs. Patch is here: On Mon, 01 May 2017 at 15:14, ludo@gnu.org (Ludovic Court=C3=A8s) wrote: >> I think throwing an unhandled exception is definitely the wrong thing to >> do here =E2=80=94 this kills even =E2=80=98guix --keep-going --fallback= =E2=80=99. I'm less sure >> about the right place to do it > > Oh right, if that kills --fallback, that=E2=80=99s a problem. > > Back to your initial patch, what about moving =E2=80=98bad-response=E2=80= =99 handling to > the call site of =E2=80=98http-multiple-get=E2=80=99 instead of having it= in > =E2=80=98http-multiple-get=E2=80=99? (That way, =E2=80=98http-multiple-g= et=E2=80=99 would behave like > =E2=80=98http-get=E2=80=99 in this respect.) > > Upon a =E2=80=98bad-response=E2=80=99, =E2=80=98fetch-narinfos=E2=80=99 w= ould return #f or the empty > list or the partial narinfo list it has built so far. > > WDYT? > > I=E2=80=99d be happy with a patch along these lines! Tobias, do you plan to rework/rebase it? All the best, simon