From debbugs-submit-bounces@debbugs.gnu.org Wed May 10 13:52:00 2017 Received: (at 25928-done) by debbugs.gnu.org; 10 May 2017 17:52:00 +0000 Received: from localhost ([127.0.0.1]:37027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8VmK-0001Sf-Hc for submit@debbugs.gnu.org; Wed, 10 May 2017 13:52:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8VmI-0001SS-Hw for 25928-done@debbugs.gnu.org; Wed, 10 May 2017 13:51:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8Vm9-0004q1-JC for 25928-done@debbugs.gnu.org; Wed, 10 May 2017 13:51:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8Vm9-0004ph-Fz; Wed, 10 May 2017 13:51:49 -0400 Received: from ip112-245-209-87.adsl2.static.versatel.nl ([87.209.245.112]:50466 helo=antelope) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d8Vm8-0002RW-Qj; Wed, 10 May 2017 13:51:49 -0400 References: <87zih4ee7i.fsf@gnu.org> <20170313232428.0530762b@alma-ubu> <20170314231326.3ac43a08@alma-ubu> <87fuhu52c8.fsf@elephly.net> <87tw4skdns.fsf@gnu.org> <87k25ohj1j.fsf@elephly.net> <87shkck9ye.fsf@gnu.org> <87d1bghf1z.fsf@elephly.net> User-agent: mu4e 0.9.18; emacs 25.1.1 From: Roel Janssen To: Ricardo Wurmus Subject: Re: bug#25928: [PATCH] gnu: Add darktable. Message-ID: <87k25obnxm.fsf@gnu.org> In-reply-to: <87d1bghf1z.fsf@elephly.net> Date: Wed, 10 May 2017 19:51:42 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25928-done Cc: =?utf-8?Q?Bj=C3=B6rn_H=C3=B6fling?= , 25928-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Ricardo Wurmus writes: > Roel Janssen writes: > >> > I wonder if it would be possible to augment LDFLAGS and CPATH in >> > #:configure-flags or #:make-flags instead of using build phases (which I >> > find a bit crude). >> > >> > If that’s too hard I promise I won’t complain about doing it with build >> > phases :) > >> See attached patch. By adding the LDFLAGS part to either #:make-flags >> or #:configure-flags, the run-path validation phase fails at the end of >> the build process. > >> So, maybe we can settle half-way here? :-) > > Sure, looks good to me! > >> > Good to push with the change to the description. >> > Thanks! > >> Is this then finally the moment we get to have darktable in Guix? :-) > > Yay! Thank you! Pushed in 91a9c65c7bae73d999ccc2288833e909ce4a0871. Thanks! Kind regards, Roel Janssen