From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 01 19:15:02 2017 Received: (at 25925) by debbugs.gnu.org; 2 Mar 2017 00:15:02 +0000 Received: from localhost ([127.0.0.1]:35098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjEOb-0003I7-K4 for submit@debbugs.gnu.org; Wed, 01 Mar 2017 19:15:01 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:40867) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjEOZ-0003Hy-HK for 25925@debbugs.gnu.org; Wed, 01 Mar 2017 19:15:00 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id CB63B20896; Wed, 1 Mar 2017 19:14:58 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Wed, 01 Mar 2017 19:14:58 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=Gn7Z4/ltl6cxczlIACamFNVF1fc=; b=SMz5gx 8oJEM7OT5MX74kPeM/L7Q0E9zb9o2bVNfrCgfg8loR2saLRgkc07u85RD5RGLGYS jE5vYamEVciI5eHsuHzpXglwYi2A8zr7GhHQSe0nRFVXDqwNryXM+qQK3xEac2B5 XcPqYnoa+TPkQMz5UJAUiS1ibq+UclkBogRJ8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=Gn7Z4/ltl6cxcz lIACamFNVF1fc=; b=bJ1wVSHk9SyaJYtcUSSPjJf7szDjSUgreGvCYuQ3kltzkN 7Jm0ZKQlbyxb2gWVSHC2VvlTus1ylk3ZRPfmLkWWNYBr/RqMFDYHLFYPxHAhPOfw 9hyfO8L0NXy4PTUnw+VETSnMSy5E7/yEhcCmZblo1SMg/eLrOD74nw1v3laXM= X-ME-Sender: X-Sasl-enc: 5lali/+7uFuB1TgbxRDErpgPwMAMexQBo7P2HuqbSX6t 1488413698 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id 67A667E16B; Wed, 1 Mar 2017 19:14:58 -0500 (EST) From: Marius Bakke To: Roel Janssen , 25925@debbugs.gnu.org Subject: Re: bug#25925: [PATCH] gnu: Add fop. In-Reply-To: <874lzcft1s.fsf@gnu.org> References: <874lzcft1s.fsf@gnu.org> User-Agent: Notmuch/0.23.7 (https://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu) Date: Thu, 02 Mar 2017 01:14:56 +0100 Message-ID: <87k288sfen.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25925 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Roel Janssen writes: > Dear Guix, > > This package is a dependency for Darktable. Therefore, I would like to > add it. > >>From 99604dfc19cd9b68863fcc948ecbe4a853bc56f0 Mon Sep 17 00:00:00 2001 > From: Roel Janssen > Date: Thu, 2 Mar 2017 00:43:00 +0100 > Subject: [PATCH] gnu: Add fop. > > * gnu/packages/xml.scm (fop): New variable. > --- > gnu/packages/xml.scm | 42 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm > index b91471690..f7f861fbe 100644 > --- a/gnu/packages/xml.scm > +++ b/gnu/packages/xml.scm > @@ -14,6 +14,7 @@ > ;;; Copyright =C2=A9 2016 ng0 > ;;; Copyright =C2=A9 2016 Tobias Geerinckx-Rice > ;;; Copyright =C2=A9 2016 Marius Bakke > +;;; Copyright =C2=A9 2017 Roel Janssen > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -42,6 +43,7 @@ > #:use-module ((guix licenses) #:prefix license:) > #:use-module (guix packages) > #:use-module (guix download) > + #:use-module (guix build-system ant) > #:use-module (guix build-system cmake) > #:use-module (guix build-system gnu) > #:use-module (guix build-system perl) > @@ -71,6 +73,46 @@ stream-oriented parser in which an application registe= rs handlers for > things the parser might find in the XML document (like start tags).") > (license license:expat))) >=20=20 > +(define-public fop > + (package > + (name "fop") > + (version "2.1") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "mirror://apache/xmlgraphics/fop/source/fop-" > + version "-src.tar.gz")) > + (sha256 > + (base32 > + "165rx13q47l6qc29ppr7sg1z26vw830s3rkklj5ap7wgvy0ivbz5"))= )) Ahh...java. Can you try removing some of the 21 bundled JARs with a 'snippet' here? We do have a couple of them in Guix already. Even better if you can package some more. > + (build-system ant-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (replace 'build > + (lambda* (#:key inputs #:allow-other-keys) > + (system* (string-append (assoc-ref inputs "ant") "/bin/ant"= )))) I'm not very familiar with ant-build-system, but isn't ant available in PATH here (so you can simply (system* "ant"))? It should probably also be wrapped in a (zero? (system* ..)) so that the return value is checked. > + (replace 'install > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin"))) > + (mkdir-p bin) > + (install-file "build/fop.jar" bin) > + (install-file "build/fop-hyph.jar" bin) > + (install-file "build/fop-sandbox.jar" bin) > + (install-file "build/fop-transcoder-allinone.jar" bin) > + (install-file "build/fop-transcoder.jar" bin) > + (install-file "fop" bin))))))) "install-file" (or actually "copy-file" from reading (guix build utils) has an unspecified return value, so this phase should end with an explicit #t. > + (home-page "https://xmlgraphics.apache.org/fop/") > + (synopsis "Formatting objects processor") > + (description "Apache FOP is a print formatter driven by XSL formatti= ng > +objects (XSL-FO) and an output independent formatter. It is a Java appl= ication > +that reads a formatting object (FO) tree and renders the resulting pages= to a > +specified output. Output formats currently supported include PDF, PS, P= CL, > +AFP, XML (area tree representation), Print, AWT and PNG, and to a lesser > +extent, RTF and TXT. The primary output target is PDF.") > + (license license:asl2.0))) I did not do a license audit of this package, but please double check that all bundled software also carries this license (or mention theirs here). The rest LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAli3ZAEACgkQoqBt8qM6 VPoCKAf/ROFhqWwh/WvRCxJWQqR0KyR26jmw3z1ilPIFeNIq6FZ6h9t32G5FVE/e 1J7qpjQ0ePj1qO9tE+E864MXl4ErO0Ek4+KMhMVG8oJKEbFLoOyNGCaSSPDGms3Y T80d1v8sJTz+CTz1vT2yrBFrFSfPo/XcTfaDD3GoFva/Yr8X09kdgaiMPBHksoQ6 Y1xpXW9qhoehZHoo2WSOuqT/XiAmhhnHMSzqff35ZC7lYPuBS2xVVIvnD24gMffc wnBbOaFtgovWpuGtNcOel/V6EtuSBRMKj3LWpd1nq3E+XnkLuZLbn1nv3Gns4U9E Og+dF9ZDllscTXOLmIWqGdFG7RXzoA== =BO6N -----END PGP SIGNATURE----- --=-=-=--